From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02FB9C433EF for ; Wed, 24 Nov 2021 11:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6+N1Tn2G6/gXwUfZLEIVyUobnmQNRnv9H0zM5ZqS7zA=; b=WBz4tpyZEoah3s btXcAO97v5iAGmY4hvFt2kD3ksHOymLrqMTswKyF4yxAQhcLUqrQ40CUl6/7ALAub60sv3/4imwLt j+Nq7H/7U2oG3q1crRg3apRFuvYsixE56Q3jEE/TrPymmF1Vqwkjq9EoP0vZLauquPbOajcR986jp zDDlE4CHM/t3SefoGFSqkeNHBYsachs7ZALUKyqTi2+vKrunY5NfSRfLhfMIfp9AhU4hW2hNmEdvv evsYqqfWLsWzE5mtbPyG1Lvjka2YJViMyPYa/oZB5SxUkhi/nk+j7QAdPz0pInqyjYQnRCKgwGxfa T1w6XhftoGcFk+v3E/cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpq8h-004XYv-PK; Wed, 24 Nov 2021 11:08:36 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpq8d-004XXG-77 for linux-arm-kernel@lists.infradead.org; Wed, 24 Nov 2021 11:08:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637752109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=waH4hRzlVOpWIl+cTH6RBonEIb6tUAeusmu8efKZ6yQ=; b=SBZqbIldEPHVtDsI9lCCNDNdKzZbLHHmqQkaG0Oel8izYYW6xp8gqICSD6cS+mx5XTdyjw woiffO49uzzb13NZwzIsR6v+P93D2XAWFFCUDB0lxsyQs0D+SICG/KHPsmh62RroSLNP9G SKJl4o0xQ94Xd1ZOHHvfJKIS/u06HEc= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-133-fFNh9nIBOtSQNWa3jT-rlQ-1; Wed, 24 Nov 2021 06:08:28 -0500 X-MC-Unique: fFNh9nIBOtSQNWa3jT-rlQ-1 Received: by mail-ed1-f70.google.com with SMTP id f4-20020a50e084000000b003db585bc274so1951756edl.17 for ; Wed, 24 Nov 2021 03:08:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=waH4hRzlVOpWIl+cTH6RBonEIb6tUAeusmu8efKZ6yQ=; b=mMOx3XiYGrwxxvqCmp2YgkffsoyV+HyladkurV0H4/FrajA9aWWX7l5AOF6yJhkZR3 qV3gnq+XPKP4V6+w33eJlII+HU0UB50I1D3CtWFPEaa3FYpwCKCd2efflUqFMWKMYgWU 6afxk7BBPZhca10Oc6lNTPuvY9PZ2+eti+kzddX7oJfo7ZDbNjvy0yss7enhgmQhQ6k6 hw0YWbyOHY5tsCK5ozrEdN/Auq6+WIUBWDVUUWSGZRulRSN/NHFNQsO4x1/1W3/ZPmbn zWosKQhaJPB+VhvAO/f0vXOZ8knEZ0SYlib0cl1XPMzYfya0/xWyH2aeGihSUtsFGsaW sfcA== X-Gm-Message-State: AOAM53082MIjNnZXmTGEvqoGvdmtW9sK6TWMAx//MD/bfQwJAy4Rp91z aBgOpUzNTbBoXPB8NgzMZUBVV7hxpBddemZ8Z8YIjm7hGyzNWukiWWIRYFRl5mMUwQ7YClWj6pv rUae7ZvWoRRRdDmjqSPZP1ikcQXFqdbOU9Xw= X-Received: by 2002:a05:6402:50d4:: with SMTP id h20mr23601518edb.52.1637752107073; Wed, 24 Nov 2021 03:08:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwglewokYpugqHWrBhNdWGpHvZXynVUenV12dW1Fb7vRdTvAfPH5JZMz6PqUW3GovixbQIRJA== X-Received: by 2002:a05:6402:50d4:: with SMTP id h20mr23601480edb.52.1637752106917; Wed, 24 Nov 2021 03:08:26 -0800 (PST) Received: from gator.home (cst2-173-70.cust.vodafone.cz. [31.30.173.70]) by smtp.gmail.com with ESMTPSA id nd22sm6940051ejc.98.2021.11.24.03.08.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 03:08:26 -0800 (PST) Date: Wed, 24 Nov 2021 12:08:24 +0100 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: kvm@vger.kernel.org, maz@kernel.org, qemu-arm@nongnu.org, idan.horowitz@gmail.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, pbonzini@redhat.com, thuth@redhat.com Subject: Re: [kvm-unit-tests PATCH v8 01/10] docs: mention checkpatch in the README Message-ID: <20211124110824.yqrtjkbul3h3pv2i@gator.home> References: <20211118184650.661575-1-alex.bennee@linaro.org> <20211118184650.661575-2-alex.bennee@linaro.org> <20211124110659.jhjuuzez6ij5v7g7@gator.home> MIME-Version: 1.0 In-Reply-To: <20211124110659.jhjuuzez6ij5v7g7@gator.home> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_030831_380925_3BAEE26A X-CRM114-Status: GOOD ( 23.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 24, 2021 at 12:07:02PM +0100, Andrew Jones wrote: > On Thu, Nov 18, 2021 at 06:46:41PM +0000, Alex Benn=E9e wrote: > > Signed-off-by: Alex Benn=E9e > > --- > > README.md | 2 ++ > > 1 file changed, 2 insertions(+) > > = > > diff --git a/README.md b/README.md > > index b498aaf..5db48e5 100644 > > --- a/README.md > > +++ b/README.md > > @@ -182,3 +182,5 @@ the code files. We also start with common code and= finish with unit test > > code. git-diff's orderFile feature allows us to specify the order in a > > file. The orderFile we use is `scripts/git.difforder`; adding the con= fig > > with `git config diff.orderFile scripts/git.difforder` enables it. > > + > > +Please run the kernel's ./scripts/checkpatch.pl on new patches > = > This is a bit of a problem for kvm-unit-tests code which still has a mix > of styles since it was originally written with a strange tab and space > mixed style. If somebody is patching one of those files we've usually > tried to maintain the original style rather than reformat the whole > thing (in hindsight maybe we should have just reformatted). We're also > more flexible with line length than Linux, although Linux now only warns > for anything over 80 as long as it's under 100, which is probably good > enough for us too. Anyway, let's see what Paolo and Thomas say. Personally > I wouldn't mind adding this line to the documentation, so I'll ack it. > Anyway, we can also ignore our own advise when it suits us :-) > = > Acked-by: Andrew Jones > Forgot to CC Thomas and Paolo, am now. Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel