* [PATCH 1/6] PCI: pci-bridge-emul: Make expansion ROM Base Address register read-only
2021-11-24 15:59 [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Pali Rohár
@ 2021-11-24 15:59 ` Pali Rohár
2021-11-24 15:59 ` [PATCH 2/6] PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config space Pali Rohár
` (6 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Pali Rohár @ 2021-11-24 15:59 UTC (permalink / raw)
To: Thomas Petazzoni, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, Marek Behún
Cc: linux-pci, linux-arm-kernel, linux-kernel
If expansion ROM is unsupported (which is the case of pci-bridge-emul.c
driver) then ROM Base Address register must be implemented as read-only
register that return 0 when read, same as for unused Base Address
registers.
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space common logic")
Cc: stable@vger.kernel.org
---
drivers/pci/pci-bridge-emul.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
index db97cddfc85e..5de8b8dde209 100644
--- a/drivers/pci/pci-bridge-emul.c
+++ b/drivers/pci/pci-bridge-emul.c
@@ -139,8 +139,13 @@ struct pci_bridge_reg_behavior pci_regs_behavior[PCI_STD_HEADER_SIZEOF / 4] = {
.ro = GENMASK(7, 0),
},
+ /*
+ * If expansion ROM is unsupported then ROM Base Address register must
+ * be implemented as read-only register that return 0 when read, same
+ * as for unused Base Address registers.
+ */
[PCI_ROM_ADDRESS1 / 4] = {
- .rw = GENMASK(31, 11) | BIT(0),
+ .ro = ~0,
},
/*
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/6] PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config space
2021-11-24 15:59 [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Pali Rohár
2021-11-24 15:59 ` [PATCH 1/6] PCI: pci-bridge-emul: Make expansion ROM Base Address register read-only Pali Rohár
@ 2021-11-24 15:59 ` Pali Rohár
2021-11-24 15:59 ` [PATCH 3/6] PCI: pci-bridge-emul: Add definitions for missing capabilities registers Pali Rohár
` (5 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Pali Rohár @ 2021-11-24 15:59 UTC (permalink / raw)
To: Thomas Petazzoni, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, Marek Behún
Cc: linux-pci, linux-arm-kernel, linux-kernel
Some bits in PCI config space are reserved when device is PCIe. Properly
define behavior of PCI registers for PCIe emulated bridge and ensure that
it would not be possible change these reserved bits.
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space common logic")
Cc: stable@vger.kernel.org
---
drivers/pci/pci-bridge-emul.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
index 5de8b8dde209..0cbb4e3ca827 100644
--- a/drivers/pci/pci-bridge-emul.c
+++ b/drivers/pci/pci-bridge-emul.c
@@ -295,6 +295,27 @@ int pci_bridge_emul_init(struct pci_bridge_emul *bridge,
kfree(bridge->pci_regs_behavior);
return -ENOMEM;
}
+ /* These bits are applicable only for PCI and reserved on PCIe */
+ bridge->pci_regs_behavior[PCI_CACHE_LINE_SIZE / 4].ro &=
+ ~GENMASK(15, 8);
+ bridge->pci_regs_behavior[PCI_COMMAND / 4].ro &=
+ ~((PCI_COMMAND_SPECIAL | PCI_COMMAND_INVALIDATE |
+ PCI_COMMAND_VGA_PALETTE | PCI_COMMAND_WAIT |
+ PCI_COMMAND_FAST_BACK) |
+ (PCI_STATUS_66MHZ | PCI_STATUS_FAST_BACK |
+ PCI_STATUS_DEVSEL_MASK) << 16);
+ bridge->pci_regs_behavior[PCI_PRIMARY_BUS / 4].ro &=
+ ~GENMASK(31, 24);
+ bridge->pci_regs_behavior[PCI_IO_BASE / 4].ro &=
+ ~((PCI_STATUS_66MHZ | PCI_STATUS_FAST_BACK |
+ PCI_STATUS_DEVSEL_MASK) << 16);
+ bridge->pci_regs_behavior[PCI_INTERRUPT_LINE / 4].rw &=
+ ~((PCI_BRIDGE_CTL_MASTER_ABORT |
+ BIT(8) | BIT(9) | BIT(11)) << 16);
+ bridge->pci_regs_behavior[PCI_INTERRUPT_LINE / 4].ro &=
+ ~((PCI_BRIDGE_CTL_FAST_BACK) << 16);
+ bridge->pci_regs_behavior[PCI_INTERRUPT_LINE / 4].w1c &=
+ ~(BIT(10) << 16);
}
if (flags & PCI_BRIDGE_EMUL_NO_PREFETCHABLE_BAR) {
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/6] PCI: pci-bridge-emul: Add definitions for missing capabilities registers
2021-11-24 15:59 [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Pali Rohár
2021-11-24 15:59 ` [PATCH 1/6] PCI: pci-bridge-emul: Make expansion ROM Base Address register read-only Pali Rohár
2021-11-24 15:59 ` [PATCH 2/6] PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config space Pali Rohár
@ 2021-11-24 15:59 ` Pali Rohár
2021-11-24 15:59 ` [PATCH 4/6] PCI: pci-bridge-emul: Fix definitions of reserved bits Pali Rohár
` (4 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Pali Rohár @ 2021-11-24 15:59 UTC (permalink / raw)
To: Thomas Petazzoni, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, Marek Behún
Cc: linux-pci, linux-arm-kernel, linux-kernel
pci-bridge-emul driver already allocates buffer for capabilities up to the
PCI_EXP_SLTSTA2 register, but does not define bit access behavior for these
registers. Fix it by adding missing definitions.
Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <kabel@kernel.org>
Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space common logic")
Cc: stable@vger.kernel.org
---
drivers/pci/pci-bridge-emul.c | 43 +++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
index 0cbb4e3ca827..31ff7448bded 100644
--- a/drivers/pci/pci-bridge-emul.c
+++ b/drivers/pci/pci-bridge-emul.c
@@ -256,6 +256,49 @@ struct pci_bridge_reg_behavior pcie_cap_regs_behavior[PCI_CAP_PCIE_SIZEOF / 4] =
.ro = GENMASK(15, 0) | PCI_EXP_RTSTA_PENDING,
.w1c = PCI_EXP_RTSTA_PME,
},
+
+ [PCI_EXP_DEVCAP2 / 4] = {
+ /*
+ * Device capabilities 2 register has reserved bits [30:27].
+ * Also bits [26:24] are reserved for non-upstream ports.
+ */
+ .ro = BIT(31) | GENMASK(23, 0),
+ },
+
+ [PCI_EXP_DEVCTL2 / 4] = {
+ /*
+ * Device control 2 register is RW. Bit 11 is reserved for
+ * non-upstream ports.
+ *
+ * Device status 2 register is reserved.
+ */
+ .rw = GENMASK(15, 12) | GENMASK(10, 0),
+ },
+
+ [PCI_EXP_LNKCAP2 / 4] = {
+ /* Link capabilities 2 register has reserved bits [30:25] and 0. */
+ .ro = BIT(31) | GENMASK(24, 1),
+ },
+
+ [PCI_EXP_LNKCTL2 / 4] = {
+ /*
+ * Link control 2 register is RW.
+ *
+ * Link status 2 register has bits 5, 15 W1C;
+ * bits 10, 11 reserved and others are RO.
+ */
+ .rw = GENMASK(15, 0),
+ .w1c = (BIT(15) | BIT(5)) << 16,
+ .ro = (GENMASK(14, 12) | GENMASK(9, 6) | GENMASK(4, 0)) << 16,
+ },
+
+ [PCI_EXP_SLTCAP2 / 4] = {
+ /* Slot capabilities 2 register is reserved. */
+ },
+
+ [PCI_EXP_SLTCTL2 / 4] = {
+ /* Both Slot control 2 and Slot status 2 registers are reserved. */
+ },
};
/*
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/6] PCI: pci-bridge-emul: Fix definitions of reserved bits
2021-11-24 15:59 [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Pali Rohár
` (2 preceding siblings ...)
2021-11-24 15:59 ` [PATCH 3/6] PCI: pci-bridge-emul: Add definitions for missing capabilities registers Pali Rohár
@ 2021-11-24 15:59 ` Pali Rohár
2021-11-24 15:59 ` [PATCH 5/6] PCI: pci-bridge-emul: Correctly set PCIe capabilities Pali Rohár
` (3 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Pali Rohár @ 2021-11-24 15:59 UTC (permalink / raw)
To: Thomas Petazzoni, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, Marek Behún
Cc: linux-pci, linux-arm-kernel, linux-kernel
Some bits in PCI_EXP registers are reserved for non-root ports. Driver
pci-bridge-emul.c implements PCIe Root Port device therefore it should not
allow setting reserved bits of registers.
Properly define non-reserved bits for all PCI_EXP registers.
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space common logic")
Cc: stable@vger.kernel.org
---
drivers/pci/pci-bridge-emul.c | 36 ++++++++++++++++++++++++-----------
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
index 31ff7448bded..9a348f99641b 100644
--- a/drivers/pci/pci-bridge-emul.c
+++ b/drivers/pci/pci-bridge-emul.c
@@ -176,41 +176,55 @@ struct pci_bridge_reg_behavior pcie_cap_regs_behavior[PCI_CAP_PCIE_SIZEOF / 4] =
[PCI_CAP_LIST_ID / 4] = {
/*
* Capability ID, Next Capability Pointer and
- * Capabilities register are all read-only.
+ * bits [14:0] of Capabilities register are all read-only.
+ * Bit 15 of Capabilities register is reserved.
*/
- .ro = ~0,
+ .ro = GENMASK(30, 0),
},
[PCI_EXP_DEVCAP / 4] = {
- .ro = ~0,
+ /*
+ * Bits [31:29] and [17:16] are reserved.
+ * Bits [27:18] are reserved for non-upstream ports.
+ * Bits 28 and [14:6] are reserved for non-endpoint devices.
+ * Other bits are read-only.
+ */
+ .ro = BIT(15) | GENMASK(5, 0),
},
[PCI_EXP_DEVCTL / 4] = {
- /* Device control register is RW */
- .rw = GENMASK(15, 0),
+ /*
+ * Device control register is RW, except bit 15 which is
+ * reserved for non-endpoints or non-PCIe-to-PCI/X bridges.
+ */
+ .rw = GENMASK(14, 0),
/*
* Device status register has bits 6 and [3:0] W1C, [5:4] RO,
- * the rest is reserved
+ * the rest is reserved. Also bit 6 is reserved for non-upstream
+ * ports.
*/
- .w1c = (BIT(6) | GENMASK(3, 0)) << 16,
+ .w1c = GENMASK(3, 0) << 16,
.ro = GENMASK(5, 4) << 16,
},
[PCI_EXP_LNKCAP / 4] = {
- /* All bits are RO, except bit 23 which is reserved */
- .ro = lower_32_bits(~BIT(23)),
+ /*
+ * All bits are RO, except bit 23 which is reserved and
+ * bit 18 which is reserved for non-upstream ports.
+ */
+ .ro = lower_32_bits(~(BIT(23) | PCI_EXP_LNKCAP_CLKPM)),
},
[PCI_EXP_LNKCTL / 4] = {
/*
* Link control has bits [15:14], [11:3] and [1:0] RW, the
- * rest is reserved.
+ * rest is reserved. Bit 8 is reserved for non-upstream ports.
*
* Link status has bits [13:0] RO, and bits [15:14]
* W1C.
*/
- .rw = GENMASK(15, 14) | GENMASK(11, 3) | GENMASK(1, 0),
+ .rw = GENMASK(15, 14) | GENMASK(11, 9) | GENMASK(7, 3) | GENMASK(1, 0),
.ro = GENMASK(13, 0) << 16,
.w1c = GENMASK(15, 14) << 16,
},
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 5/6] PCI: pci-bridge-emul: Correctly set PCIe capabilities
2021-11-24 15:59 [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Pali Rohár
` (3 preceding siblings ...)
2021-11-24 15:59 ` [PATCH 4/6] PCI: pci-bridge-emul: Fix definitions of reserved bits Pali Rohár
@ 2021-11-24 15:59 ` Pali Rohár
2021-11-24 15:59 ` [PATCH 6/6] PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device Pali Rohár
` (2 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Pali Rohár @ 2021-11-24 15:59 UTC (permalink / raw)
To: Thomas Petazzoni, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, Marek Behún
Cc: linux-pci, linux-arm-kernel, linux-kernel
Older mvebu hardware provides PCIe Capability structure only in version 1.
New mvebu and aardvark hardware provides it in version 2. So do not force
version to 2 in pci_bridge_emul_init() and rather allow drivers to set
correct version. Drivers need to set version in pcie_conf.cap field without
overwriting PCI_CAP_LIST_ID register. Both drivers (mvebu and aardvark) do
not provide slot support yet, so do not set PCI_EXP_FLAGS_SLOT flag.
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space common logic")
Cc: stable@vger.kernel.org
---
drivers/pci/controller/pci-aardvark.c | 4 +++-
drivers/pci/controller/pci-mvebu.c | 8 ++++++++
drivers/pci/pci-bridge-emul.c | 5 +----
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c
index c5300d49807a..62fc55f2ed40 100644
--- a/drivers/pci/controller/pci-aardvark.c
+++ b/drivers/pci/controller/pci-aardvark.c
@@ -881,7 +881,6 @@ advk_pci_bridge_emul_pcie_conf_read(struct pci_bridge_emul *bridge,
return PCI_BRIDGE_EMUL_HANDLED;
}
- case PCI_CAP_LIST_ID:
case PCI_EXP_DEVCAP:
case PCI_EXP_DEVCTL:
*value = advk_readl(pcie, PCIE_CORE_PCIEXP_CAP + reg);
@@ -962,6 +961,9 @@ static int advk_sw_pci_bridge_init(struct advk_pcie *pcie)
/* Support interrupt A for MSI feature */
bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE;
+ /* Aardvark HW provides PCIe Capability structure in version 2 */
+ bridge->pcie_conf.cap = cpu_to_le16(2);
+
/* Indicates supports for Completion Retry Status */
bridge->pcie_conf.rootcap = cpu_to_le16(PCI_EXP_RTCAP_CRSVIS);
diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
index e0e50af8ced4..06f06085beba 100644
--- a/drivers/pci/controller/pci-mvebu.c
+++ b/drivers/pci/controller/pci-mvebu.c
@@ -584,6 +584,8 @@ static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
static void mvebu_pci_bridge_emul_init(struct mvebu_pcie_port *port)
{
struct pci_bridge_emul *bridge = &port->bridge;
+ u32 pcie_cap = mvebu_readl(port, PCIE_CAP_PCIEXP);
+ u8 pcie_cap_ver = ((pcie_cap >> 16) & PCI_EXP_FLAGS_VERS);
bridge->conf.vendor = PCI_VENDOR_ID_MARVELL;
bridge->conf.device = mvebu_readl(port, PCIE_DEV_ID_OFF) >> 16;
@@ -596,6 +598,12 @@ static void mvebu_pci_bridge_emul_init(struct mvebu_pcie_port *port)
bridge->conf.iolimit = PCI_IO_RANGE_TYPE_32;
}
+ /*
+ * Older mvebu hardware provides PCIe Capability structure only in
+ * version 1. New hardware provides it in version 2.
+ */
+ bridge->pcie_conf.cap = cpu_to_le16(pcie_cap_ver);
+
bridge->has_pcie = true;
bridge->data = port;
bridge->ops = &mvebu_pci_bridge_emul_ops;
diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
index 9a348f99641b..6c75dc296984 100644
--- a/drivers/pci/pci-bridge-emul.c
+++ b/drivers/pci/pci-bridge-emul.c
@@ -340,10 +340,7 @@ int pci_bridge_emul_init(struct pci_bridge_emul *bridge,
if (bridge->has_pcie) {
bridge->conf.capabilities_pointer = PCI_CAP_PCIE_START;
bridge->pcie_conf.cap_id = PCI_CAP_ID_EXP;
- /* Set PCIe v2, root port, slot support */
- bridge->pcie_conf.cap =
- cpu_to_le16(PCI_EXP_TYPE_ROOT_PORT << 4 | 2 |
- PCI_EXP_FLAGS_SLOT);
+ bridge->pcie_conf.cap |= cpu_to_le16(PCI_EXP_TYPE_ROOT_PORT << 4);
bridge->pcie_cap_regs_behavior =
kmemdup(pcie_cap_regs_behavior,
sizeof(pcie_cap_regs_behavior),
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 6/6] PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
2021-11-24 15:59 [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Pali Rohár
` (4 preceding siblings ...)
2021-11-24 15:59 ` [PATCH 5/6] PCI: pci-bridge-emul: Correctly set PCIe capabilities Pali Rohár
@ 2021-11-24 15:59 ` Pali Rohár
2021-11-30 13:26 ` [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Marek Behún
2021-12-06 12:19 ` Lorenzo Pieralisi
7 siblings, 0 replies; 12+ messages in thread
From: Pali Rohár @ 2021-11-24 15:59 UTC (permalink / raw)
To: Thomas Petazzoni, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, Marek Behún
Cc: linux-pci, linux-arm-kernel, linux-kernel
Since all PCI Express device Functions are required to implement the PCI
Express Capability structure, Capabilities List bit in PCI Status Register
must be hardwired to 1b. Capabilities Pointer register (which is already
set by pci-bride-emul.c driver) is valid only when Capabilities List is set
to 1b.
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space common logic")
Cc: stable@vger.kernel.org
---
drivers/pci/pci-bridge-emul.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
index 6c75dc296984..d11633999df5 100644
--- a/drivers/pci/pci-bridge-emul.c
+++ b/drivers/pci/pci-bridge-emul.c
@@ -339,6 +339,7 @@ int pci_bridge_emul_init(struct pci_bridge_emul *bridge,
if (bridge->has_pcie) {
bridge->conf.capabilities_pointer = PCI_CAP_PCIE_START;
+ bridge->conf.status |= cpu_to_le16(PCI_STATUS_CAP_LIST);
bridge->pcie_conf.cap_id = PCI_CAP_ID_EXP;
bridge->pcie_conf.cap |= cpu_to_le16(PCI_EXP_TYPE_ROOT_PORT << 4);
bridge->pcie_cap_regs_behavior =
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 0/6] PCI: pci-bridge-emul: Various fixes
2021-11-24 15:59 [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Pali Rohár
` (5 preceding siblings ...)
2021-11-24 15:59 ` [PATCH 6/6] PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device Pali Rohár
@ 2021-11-30 13:26 ` Marek Behún
2021-12-02 20:20 ` Pali Rohár
2021-12-06 12:19 ` Lorenzo Pieralisi
7 siblings, 1 reply; 12+ messages in thread
From: Marek Behún @ 2021-11-30 13:26 UTC (permalink / raw)
To: Pali Rohár
Cc: Thomas Petazzoni, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, linux-pci,
linux-arm-kernel, linux-kernel
On Wed, 24 Nov 2021 16:59:38 +0100
Pali Rohár <pali@kernel.org> wrote:
> This patch series contains various fixes for pci-bridge-emul code.
> This code is used only by pci-aardvark.c and pci-mvebu.c drivers.
>
> Pali Rohár (6):
> PCI: pci-bridge-emul: Make expansion ROM Base Address register
> read-only
> PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config
> space
> PCI: pci-bridge-emul: Add definitions for missing capabilities
> registers
> PCI: pci-bridge-emul: Fix definitions of reserved bits
> PCI: pci-bridge-emul: Correctly set PCIe capabilities
> PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
>
> drivers/pci/controller/pci-aardvark.c | 4 +-
> drivers/pci/controller/pci-mvebu.c | 8 ++
> drivers/pci/pci-bridge-emul.c | 113 ++++++++++++++++++++++----
> 3 files changed, 108 insertions(+), 17 deletions(-)
>
I will send v2 of this series with the third patch dropped, since it
will be applied via aardvark batch 3 series.
Marek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/6] PCI: pci-bridge-emul: Various fixes
2021-11-30 13:26 ` [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Marek Behún
@ 2021-12-02 20:20 ` Pali Rohár
0 siblings, 0 replies; 12+ messages in thread
From: Pali Rohár @ 2021-12-02 20:20 UTC (permalink / raw)
To: Marek Behún
Cc: Thomas Petazzoni, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, linux-pci,
linux-arm-kernel, linux-kernel
On Tuesday 30 November 2021 14:26:52 Marek Behún wrote:
> On Wed, 24 Nov 2021 16:59:38 +0100
> Pali Rohár <pali@kernel.org> wrote:
>
> > This patch series contains various fixes for pci-bridge-emul code.
> > This code is used only by pci-aardvark.c and pci-mvebu.c drivers.
> >
> > Pali Rohár (6):
> > PCI: pci-bridge-emul: Make expansion ROM Base Address register
> > read-only
> > PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config
> > space
> > PCI: pci-bridge-emul: Add definitions for missing capabilities
> > registers
> > PCI: pci-bridge-emul: Fix definitions of reserved bits
> > PCI: pci-bridge-emul: Correctly set PCIe capabilities
> > PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
> >
> > drivers/pci/controller/pci-aardvark.c | 4 +-
> > drivers/pci/controller/pci-mvebu.c | 8 ++
> > drivers/pci/pci-bridge-emul.c | 113 ++++++++++++++++++++++----
> > 3 files changed, 108 insertions(+), 17 deletions(-)
> >
>
> I will send v2 of this series with the third patch dropped, since it
> will be applied via aardvark batch 3 series.
>
> Marek
I marked third patch at patchwork as "Superseded" (as now it was applied
into pci/aardvark branch) and so there is no need to resend same patches
again.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/6] PCI: pci-bridge-emul: Various fixes
2021-11-24 15:59 [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Pali Rohár
` (6 preceding siblings ...)
2021-11-30 13:26 ` [PATCH 0/6] PCI: pci-bridge-emul: Various fixes Marek Behún
@ 2021-12-06 12:19 ` Lorenzo Pieralisi
2021-12-06 12:24 ` Pali Rohár
7 siblings, 1 reply; 12+ messages in thread
From: Lorenzo Pieralisi @ 2021-12-06 12:19 UTC (permalink / raw)
To: Bjorn Helgaas, Thomas Petazzoni, Pali Rohár, Rob Herring,
Marek Behún, Krzysztof Wilczyński
Cc: Lorenzo Pieralisi, linux-arm-kernel, linux-pci, linux-kernel
On Wed, 24 Nov 2021 16:59:38 +0100, Pali Rohár wrote:
> This patch series contains various fixes for pci-bridge-emul code.
> This code is used only by pci-aardvark.c and pci-mvebu.c drivers.
>
> Pali Rohár (6):
> PCI: pci-bridge-emul: Make expansion ROM Base Address register
> read-only
> PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config
> space
> PCI: pci-bridge-emul: Add definitions for missing capabilities
> registers
> PCI: pci-bridge-emul: Fix definitions of reserved bits
> PCI: pci-bridge-emul: Correctly set PCIe capabilities
> PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
>
> [...]
Applied to pci/bridge-emul, thanks!
[1/6] PCI: pci-bridge-emul: Make expansion ROM Base Address register read-only
https://git.kernel.org/lpieralisi/pci/c/1c1a3b4d3e
[2/6] PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config space
https://git.kernel.org/lpieralisi/pci/c/7b067ac63a
[3/6] PCI: pci-bridge-emul: Add definitions for missing capabilities registers
https://git.kernel.org/lpieralisi/pci/c/faa3e547f4
[4/6] PCI: pci-bridge-emul: Fix definitions of reserved bits
https://git.kernel.org/lpieralisi/pci/c/a3ab28a2e3
[5/6] PCI: pci-bridge-emul: Correctly set PCIe capabilities
https://git.kernel.org/lpieralisi/pci/c/0f7ba81700
[6/6] PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
https://git.kernel.org/lpieralisi/pci/c/32051099e8
Thanks,
Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/6] PCI: pci-bridge-emul: Various fixes
2021-12-06 12:19 ` Lorenzo Pieralisi
@ 2021-12-06 12:24 ` Pali Rohár
2021-12-06 14:26 ` Lorenzo Pieralisi
0 siblings, 1 reply; 12+ messages in thread
From: Pali Rohár @ 2021-12-06 12:24 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Bjorn Helgaas, Thomas Petazzoni, Rob Herring, Marek Behún,
Krzysztof Wilczyński, linux-arm-kernel, linux-pci,
linux-kernel
On Monday 06 December 2021 12:19:57 Lorenzo Pieralisi wrote:
> On Wed, 24 Nov 2021 16:59:38 +0100, Pali Rohár wrote:
> > This patch series contains various fixes for pci-bridge-emul code.
> > This code is used only by pci-aardvark.c and pci-mvebu.c drivers.
> >
> > Pali Rohár (6):
> > PCI: pci-bridge-emul: Make expansion ROM Base Address register
> > read-only
> > PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config
> > space
> > PCI: pci-bridge-emul: Add definitions for missing capabilities
> > registers
> > PCI: pci-bridge-emul: Fix definitions of reserved bits
> > PCI: pci-bridge-emul: Correctly set PCIe capabilities
> > PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
> >
> > [...]
>
> Applied to pci/bridge-emul, thanks!
>
> [1/6] PCI: pci-bridge-emul: Make expansion ROM Base Address register read-only
> https://git.kernel.org/lpieralisi/pci/c/1c1a3b4d3e
> [2/6] PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config space
> https://git.kernel.org/lpieralisi/pci/c/7b067ac63a
> [3/6] PCI: pci-bridge-emul: Add definitions for missing capabilities registers
> https://git.kernel.org/lpieralisi/pci/c/faa3e547f4
Hello Lorenzo! This patch "PCI: pci-bridge-emul: Add definitions for
missing capabilities registers" is now in your two different branches:
pci/bridge-emul and pci/aardvark. Not sure if you want to have this same
patch on two places... So please check.
> [4/6] PCI: pci-bridge-emul: Fix definitions of reserved bits
> https://git.kernel.org/lpieralisi/pci/c/a3ab28a2e3
> [5/6] PCI: pci-bridge-emul: Correctly set PCIe capabilities
> https://git.kernel.org/lpieralisi/pci/c/0f7ba81700
> [6/6] PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
> https://git.kernel.org/lpieralisi/pci/c/32051099e8
>
> Thanks,
> Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/6] PCI: pci-bridge-emul: Various fixes
2021-12-06 12:24 ` Pali Rohár
@ 2021-12-06 14:26 ` Lorenzo Pieralisi
0 siblings, 0 replies; 12+ messages in thread
From: Lorenzo Pieralisi @ 2021-12-06 14:26 UTC (permalink / raw)
To: Pali Rohár
Cc: Bjorn Helgaas, Thomas Petazzoni, Rob Herring, Marek Behún,
Krzysztof Wilczyński, linux-arm-kernel, linux-pci,
linux-kernel
On Mon, Dec 06, 2021 at 01:24:51PM +0100, Pali Rohár wrote:
> On Monday 06 December 2021 12:19:57 Lorenzo Pieralisi wrote:
> > On Wed, 24 Nov 2021 16:59:38 +0100, Pali Rohár wrote:
> > > This patch series contains various fixes for pci-bridge-emul code.
> > > This code is used only by pci-aardvark.c and pci-mvebu.c drivers.
> > >
> > > Pali Rohár (6):
> > > PCI: pci-bridge-emul: Make expansion ROM Base Address register
> > > read-only
> > > PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config
> > > space
> > > PCI: pci-bridge-emul: Add definitions for missing capabilities
> > > registers
> > > PCI: pci-bridge-emul: Fix definitions of reserved bits
> > > PCI: pci-bridge-emul: Correctly set PCIe capabilities
> > > PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
> > >
> > > [...]
> >
> > Applied to pci/bridge-emul, thanks!
> >
> > [1/6] PCI: pci-bridge-emul: Make expansion ROM Base Address register read-only
> > https://git.kernel.org/lpieralisi/pci/c/1c1a3b4d3e
> > [2/6] PCI: pci-bridge-emul: Properly mark reserved PCIe bits in PCI config space
> > https://git.kernel.org/lpieralisi/pci/c/7b067ac63a
> > [3/6] PCI: pci-bridge-emul: Add definitions for missing capabilities registers
> > https://git.kernel.org/lpieralisi/pci/c/faa3e547f4
>
> Hello Lorenzo! This patch "PCI: pci-bridge-emul: Add definitions for
> missing capabilities registers" is now in your two different branches:
> pci/bridge-emul and pci/aardvark. Not sure if you want to have this same
> patch on two places... So please check.
Dropped, thanks.
Lorenzo
> > [4/6] PCI: pci-bridge-emul: Fix definitions of reserved bits
> > https://git.kernel.org/lpieralisi/pci/c/a3ab28a2e3
> > [5/6] PCI: pci-bridge-emul: Correctly set PCIe capabilities
> > https://git.kernel.org/lpieralisi/pci/c/0f7ba81700
> > [6/6] PCI: pci-bridge-emul: Set PCI_STATUS_CAP_LIST for PCIe device
> > https://git.kernel.org/lpieralisi/pci/c/32051099e8
> >
> > Thanks,
> > Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread