From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E741C433F5 for ; Wed, 24 Nov 2021 16:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1vzt3M6nRNen1vNmZAm+MJZvnuLFra3B7Ohkx8EXCy4=; b=APWgQrKRrkr3/l yBeLIA5wYyMBfRYwL4rGFj+dUuzlwRM99GbBlZPbIUPClWNbvcoUcVbsmFsvxHo1vlbuE5T50ZJrM Kvt7dUUifuP475Xd9roIMdN/cS3mHkouIQz9hkqfmE5c0xAOP0Mh0hYKTgUygsBZZhBPvOO875cA6 WCQSfhLK8LpSnlzLMMWlc+NUrTZUKctOzXcQaqY+I/ZCF9keMzwriFS97rAwPqJ1mNpSvQhualvk9 08HQWlZUXdtujjSnRyLfzPRApD2Mzdg8Q8OF7RAU+gC/jcMQTreB/o4e6Ef/7jAQWX7CYFsyvbZ+M t+2GeadzDOW40EYwzdoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpvSP-005Jyv-Jv; Wed, 24 Nov 2021 16:49:18 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpvSG-005Jva-8l for linux-arm-kernel@lists.infradead.org; Wed, 24 Nov 2021 16:49:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637772546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9J3cD1dyyOWaeZtyt11eMPdAt6Sv3JFpKNvzxQVuJ5s=; b=Oq5EVYGLesKz89GaaZRFh31VvUR+dOceToWVNAgBN7DxbqXGGYIzaNw7i1Xj0v7gMxCYjr +nLzveLQ90riEGypIT9Xzmv9nbvsxF8uRv5XOoOKSL1CQ3DmEu4H5sbKn2GrVafoe0AYE0 AKRAwjw02Er70f/400Dzk7okb6AvcIA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-m5DmoyO7M_qHv5XY78GCQw-1; Wed, 24 Nov 2021 11:49:03 -0500 X-MC-Unique: m5DmoyO7M_qHv5XY78GCQw-1 Received: by mail-wm1-f70.google.com with SMTP id a64-20020a1c7f43000000b003335e5dc26bso1597442wmd.8 for ; Wed, 24 Nov 2021 08:49:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9J3cD1dyyOWaeZtyt11eMPdAt6Sv3JFpKNvzxQVuJ5s=; b=sGShR1voAl8Vqkgoo/IsUnaksBLQuPdxbV9l+ZSAyKIiqMM4A8gW1yKolkJdBwraBK JYdjuMefn6gRlz4TpFERtnL61nBeUoUCEdmA0+nsPVPMLsoapdZLmXclRmoiD1cT9TkY q4dlhgk8nTebWoS+nf5uVDJ5YlwZWTq6NAr8APPXeXkBWEVZ5QmOoidufoX/0nI66xi6 YoROMbcEWwKehR4ULCouygRPJfYI6ye3ia7sx/nJ+grZqNtX9eR+ZxYtJmOs6eHB09xO djP4XlyY+to9Cd3KukAKwonYisgioJ7zU0Ny1cJTQMgyQQUwrSlI3vtSsH4M5R5BrAFQ 2vDA== X-Gm-Message-State: AOAM530i36MZhDzPGjx5r1l40xBBHOXQ6oq0thhv6HZcDLylzrWcDib1 jANt6quWo1106GUaLYGTcE0lb4nfSxnvfdjXkuxBAWi3TFgdkA4dXihn0kArYNGNR+qJQCxM3u6 RRBN29opPEaDxrGOwupBsLmlG0Tkbkxb325w= X-Received: by 2002:a05:600c:202:: with SMTP id 2mr17343005wmi.134.1637772541880; Wed, 24 Nov 2021 08:49:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8+y4uHEYO0F0AY23C+bnwKrPr+F3pwAPTFQD3xgmryE/REWkJq9qNVUDwYJm7a9a1iDU8BA== X-Received: by 2002:a05:600c:202:: with SMTP id 2mr17342972wmi.134.1637772541675; Wed, 24 Nov 2021 08:49:01 -0800 (PST) Received: from gator (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id o4sm6354481wmq.31.2021.11.24.08.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 08:49:01 -0800 (PST) Date: Wed, 24 Nov 2021 17:48:59 +0100 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: kvm@vger.kernel.org, maz@kernel.org, qemu-arm@nongnu.org, idan.horowitz@gmail.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [kvm-unit-tests PATCH v8 04/10] run_tests.sh: add --config option for alt test set Message-ID: <20211124164859.4enqimrptr3pfdkp@gator> References: <20211118184650.661575-1-alex.bennee@linaro.org> <20211118184650.661575-5-alex.bennee@linaro.org> MIME-Version: 1.0 In-Reply-To: <20211118184650.661575-5-alex.bennee@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_084908_444179_8321CF5F X-CRM114-Status: GOOD ( 24.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 18, 2021 at 06:46:44PM +0000, Alex Benn=E9e wrote: > The upcoming MTTCG tests don't need to be run for normal KVM unit > tests so lets add the facility to have a custom set of tests. I think an environment variable override would be better than this command line override, because then we could also get mkstandalone to work with the new unittests.cfg files. Or, it may be better to just add them to the main unittests.cfg with lines like these groups =3D nodefault mttcg accel =3D tcg That'll "dirty" the logs with SKIP ... (test marked as manual run only) for each one, but at least we won't easily forget about running them from time to time. Thanks, drew > = > Signed-off-by: Alex Benn=E9e > --- > run_tests.sh | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > = > diff --git a/run_tests.sh b/run_tests.sh > index 9f233c5..b1088d2 100755 > --- a/run_tests.sh > +++ b/run_tests.sh > @@ -15,7 +15,7 @@ function usage() > { > cat < = > -Usage: $0 [-h] [-v] [-a] [-g group] [-j NUM-TASKS] [-t] > +Usage: $0 [-h] [-v] [-a] [-g group] [-j NUM-TASKS] [-t] [-c CONFIG] > = > -h, --help Output this help text > -v, --verbose Enables verbose mode > @@ -24,6 +24,7 @@ Usage: $0 [-h] [-v] [-a] [-g group] [-j NUM-TASKS] [-t] > -g, --group Only execute tests in the given group > -j, --parallel Execute tests in parallel > -t, --tap13 Output test results in TAP format > + -c, --config Override default unittests.cfg > = > Set the environment variable QEMU=3D/path/to/qemu-system-ARCH to > specify the appropriate qemu binary for ARCH-run. > @@ -42,7 +43,7 @@ if [ $? -ne 4 ]; then > fi > = > only_tests=3D"" > -args=3D$(getopt -u -o ag:htj:v -l all,group:,help,tap13,parallel:,verbos= e -- $*) > +args=3D$(getopt -u -o ag:htj:vc: -l all,group:,help,tap13,parallel:,verb= ose,config: -- $*) > [ $? -ne 0 ] && exit 2; > set -- $args; > while [ $# -gt 0 ]; do > @@ -73,6 +74,10 @@ while [ $# -gt 0 ]; do > -t | --tap13) > tap_output=3D"yes" > ;; > + -c | --config) > + shift > + config=3D$1 > + ;; > --) > ;; > *) > @@ -152,7 +157,7 @@ function run_task() > = > : ${unittest_log_dir:=3Dlogs} > : ${unittest_run_queues:=3D1} > -config=3D$TEST_DIR/unittests.cfg > +: ${config:=3D$TEST_DIR/unittests.cfg} > = > rm -rf $unittest_log_dir.old > [ -d $unittest_log_dir ] && mv $unittest_log_dir $unittest_log_dir.old > -- = > 2.30.2 > = > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel