Re: [PATCH v4 04/12] ARM: Add basic support for Airoha EN7523 SoC

Robin Murphy
2021-11-25T13:23:22Z

On 2021-11-25 11:07, Felix Fietkau wrote:
> From: John Crispin <john@phrozen.org>
>
> EN7523 is an armv8 based silicon used inside broadband access type devices
> such as xPON and xDSL. It shares various silicon blocks with MediaTek
> silicon such as the MT7622.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Bert Vermeulen <bert@biot.com>
> ---
> arch/arm/Kconfig | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f0f9e8bec83a..8468361a8721 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -573,6 +573,20 @@ config ARCH_VIRT
> select HAVE_ARM_ARCH_TIMER
> select ARCH_SUPPORTS_BIG_ENDIAN
>
> +config ARCH_AIROHA
> + bool "Airoha SoC Support"
> + depends on ARCH_MULTI_V7
> + select ARM_AMBA
> + select ARM_GIC
> + select ARM_GIC_V3
> + select ARM_DMA_USE_IOMMU

Is this really needed? TBH I'd be rather surprised to see IOMMUs in a
small-scale embedded router SoC, or are there others in a similar vein
to MT7623N with random multimedia bits thrown in as well?

> + select ARM_PSCI
> + select HAVE_ARM_ARCH_TIMER
> + select IOMMU_DMA

This does nothing (except bloat your image with some dead code which
won't be called).

Robin.

> + select COMMON_CLK
> + help
> + Support for Airoha EN7523 SoCs
> +
> #
> # This is sorted alphabetically by mach-* pathname. However, plat-*
> # Kconfigs may be included either alphabetically (according to the
>