From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B5E5C433F5 for ; Thu, 25 Nov 2021 12:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cXkLZAmN5yNifBZ61vYl4MwSDWkj19mgUyuExr7k5Fw=; b=ya0AiI2Z0p3tYL dkEgKIjniufpbx6eo0F1V3jj8nipWwi8jogcUyfi8h8jSQMbIRtb0+8YfGCII6eJWAnbKxBggyI/K i554RHqX+1DgNk+do4lk3tFYQhdO6tdRb99bDW1eCX05K6ZiaSfCqcVPD+g68Erak1EvW86M12M56 Z7TXeEEogfXv3pvzZ+CVl+Unre4jDGWB6TbR2HX46ATkN7ctdauUMS1+635yFkSW+PWQAdEUnkWRt ohEs6bM+HuKo2wwKMkW78s0lT93vRgdUCzx6L2cLvhx6NzsghPJ6XtHtMd7ev/B/U5qoX2U7kVJWw FeqRFvAEbdIcs/9GESHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqEJO-007XoP-Id; Thu, 25 Nov 2021 12:57:15 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqEBf-007TvN-Pa for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 12:49:17 +0000 Received: by mail-pl1-x62f.google.com with SMTP id u11so4493003plf.3 for ; Thu, 25 Nov 2021 04:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=k/MWypq4OBux59HLtphgq3y+jYzXV/Eny8GlcFdLOas=; b=DM++8XjiAdNVOKnR235uLPsu3V7ioJ1QiaC+hn444jiViWTXc5yAgQpulIzPk+NrLY XQCYP8RzntxdEvPGGN0EyiQS2OG7eT3j2VMMl8h4oGn36hpBuC6gVWAdynRpBvDmu/Wk 4RVrZo8uPamvn/VD8zk+pCcSoMePR/WGfJRRKrvfuuOldwOICc4mcFU/+xcbfhu30ywk DgRE4eZpWmCQXBAapS3uzd7ZyRpl0ymXw7qoFLjBWfxZXmWh6kH5JACONhYCVsKN/jiK PsfKsxpCgVoTgVjJBwb6JpBKlSC67YrF3VUsVcQEKllSXN8XCeoXpFT9Lh6KCXHfHIMS 2N9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=k/MWypq4OBux59HLtphgq3y+jYzXV/Eny8GlcFdLOas=; b=oxpEMlKeLgEPnFHO9QwFLSw5pubRA7uVI8RZUb8Ydp+OTN8uLcUxyBjv2yykdVdmiJ +TONGgWOpOo46pvaUDYRElj3JPbwarOKW7Js+3zIvBHw2lnqTlLYLtSzBU4O6k2ODxtl aqstT7hdY+GRYjfGFaJBKYC7Pel1jH+S1uFtlLXu75Dy8x+T1gtgj/j9jis7MYa31ZiT n9/jjMfiv5pHFFfXupmht58+JUBYyjTM8NelemIXprfLKd08GsM8D9iOz/ZXYuTanK28 GGxw4V17hsgNfberlvEwo3pyhZKSQMCmslqepdj1aZYWZ5HsdsjYS5t9yuOi0/X4HCWC i3bg== X-Gm-Message-State: AOAM530WpMEE8OMu9GCE/RVVNPD5JFyRowKhAf1dRMCnzQlxzV14vhmz MZcJCCvft80ItUEUlSofv79J3Q== X-Google-Smtp-Source: ABdhPJx2nsF+0S1dK+zNLc3mYLq8EgRxjoK6/V/RrnxgrXSeC55p+L34mPLMjCVch6FJ3HVwSObS+w== X-Received: by 2002:a17:90b:1b52:: with SMTP id nv18mr6767330pjb.43.1637844554786; Thu, 25 Nov 2021 04:49:14 -0800 (PST) Received: from leoy-ThinkPad-X240s ([66.23.193.248]) by smtp.gmail.com with ESMTPSA id t19sm2436110pgn.7.2021.11.25.04.49.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 04:49:14 -0800 (PST) Date: Thu, 25 Nov 2021 20:49:05 +0800 From: Leo Yan To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, James Clark , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , Mathieu Poirier , linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH 1/1] perf arm-spe: report all SPE records as "all" events Message-ID: <20211125124905.GC1599216@leoy-ThinkPad-X240s> References: <20211117142833.226629-1-german.gomez@arm.com> <20211125075358.GA1599216@leoy-ThinkPad-X240s> <3a84dd85-7bae-49ea-75cc-52f9a8220cc4@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3a84dd85-7bae-49ea-75cc-52f9a8220cc4@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_044915_904462_E4692A6F X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 25, 2021 at 11:54:16AM +0000, German Gomez wrote: > Hi Leo, > = > On 25/11/2021 07:53, Leo Yan wrote: > > On Wed, Nov 17, 2021 at 02:28:32PM +0000, German Gomez wrote: > >> [...] > > After checked the event types, I think "other" samples would include > > below raw event types: > > > > EV_EXCEPTION_GEN > > EV_RETIRED > > EV_NOT_TAKEN > > EV_ALIGNMENT > > EV_PARTIAL_PREDICATE > > EV_EMPTY_PREDICATE > > > > I am just wander if we can use sample.transaction to store these event > > types, otherwise, we cannot distinguish the event type for the samples. > = > I'm not familiar with the meaning of transactions in this context, but > I agree giving visibility of these remaining events is a good idea. I'm > just unsure where to place them from the available --itrace options. Please take a look in my another reply, I think it's good to consider to use event type + sample fields (flags/data_src/transactions) for better expressing samples. > Regarding the "all" events, we thought having quick access to a=A0 global > histogram of all the spe events is useful, and from all the --itrace > options it seemed to fit best under --itrace=3Do. Okay, I agree this is a distinct requirement and we can use this way to generate for all SPE records. But the question is if a user reviews "all" events, how user can easily understand the samples if only bases on fields sample::addr, e.g. we will have no idea if a sample is a memory operation or a branch operation, and I think the samples for memory operations will always set sample.addr as 0. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel