linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org
Subject: [arm64:devel/btrfs-live-lock-fix 2/4] mm/gup.c:1679:14: error: implicit declaration of function 'probe_subpage_user_writeable'; did you mean 'probe_subpage_user_writable'?
Date: Sat, 27 Nov 2021 10:53:30 +0800	[thread overview]
Message-ID: <202111271034.PqdO0145-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git devel/btrfs-live-lock-fix
head:   eade0a26bad9d83117f472f6eebd84b90cef0dae
commit: 01859d53b56e5d9eafe838c11532d072e40d4f53 [2/4] mm: Probe for sub-page faults in fault_in_writeable()
config: m68k-defconfig (https://download.01.org/0day-ci/archive/20211127/202111271034.PqdO0145-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?id=01859d53b56e5d9eafe838c11532d072e40d4f53
        git remote add arm64 https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
        git fetch --no-tags arm64 devel/btrfs-live-lock-fix
        git checkout 01859d53b56e5d9eafe838c11532d072e40d4f53
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   mm/gup.c: In function 'fault_in_writeable':
>> mm/gup.c:1679:14: error: implicit declaration of function 'probe_subpage_user_writeable'; did you mean 'probe_subpage_user_writable'? [-Werror=implicit-function-declaration]
    1679 |         if (!probe_subpage_user_writeable(uaddr, size))
         |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |              probe_subpage_user_writable
   cc1: some warnings being treated as errors


vim +1679 mm/gup.c

  1660	
  1661	/**
  1662	 * fault_in_writeable - fault in userspace address range for writing
  1663	 * @uaddr: start of address range
  1664	 * @size: size of address range
  1665	 *
  1666	 * Returns the number of bytes not faulted in (like copy_to_user() and
  1667	 * copy_from_user()).
  1668	 */
  1669	size_t fault_in_writeable(char __user *uaddr, size_t size)
  1670	{
  1671		char __user *start = uaddr, *end;
  1672	
  1673		if (unlikely(size == 0))
  1674			return 0;
  1675		/*
  1676		 * Probe the beginning of the buffer for sub-page faults within the
  1677		 * error margin of the corresponding uaccess.
  1678		 */
> 1679		if (!probe_subpage_user_writeable(uaddr, size))
  1680			return size;
  1681		if (!PAGE_ALIGNED(uaddr)) {
  1682			if (unlikely(__put_user(0, uaddr) != 0))
  1683				return size;
  1684			uaddr = (char __user *)PAGE_ALIGN((unsigned long)uaddr);
  1685		}
  1686		end = (char __user *)PAGE_ALIGN((unsigned long)start + size);
  1687		if (unlikely(end < start))
  1688			end = NULL;
  1689		while (uaddr != end) {
  1690			if (unlikely(__put_user(0, uaddr) != 0))
  1691				goto out;
  1692			uaddr += PAGE_SIZE;
  1693		}
  1694	
  1695	out:
  1696		if (size > uaddr - start)
  1697			return size - (uaddr - start);
  1698		return 0;
  1699	}
  1700	EXPORT_SYMBOL(fault_in_writeable);
  1701	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

                 reply	other threads:[~2021-11-27  2:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111271034.PqdO0145-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).