From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Wan Jiabing <wanjiabing@vivo.com>, Xu Wang <vulab@iscas.ac.cn>,
<linux-arm-kernel@lists.infradead.org>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH v2] iio: adc: stm32: fix null pointer on defer_probe error
Date: Sat, 27 Nov 2021 16:10:26 +0000 [thread overview]
Message-ID: <20211127161026.2e725d5a@jic23-huawei> (raw)
In-Reply-To: <20211122144501.000014a3@Huawei.com>
On Mon, 22 Nov 2021 14:45:01 +0000
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> On Mon, 22 Nov 2021 15:41:10 +0100
> Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
> > On 22.11.21 15:38, Olivier Moysan wrote:
> > > dev_err_probe() calls __device_set_deferred_probe_reason()
> > > on -EPROBE_DEFER error. If device pointer to driver core
> > > private structure is not initialized, an null pointer error occurs.
> > > This pointer is set on iio_device_register() call for iio device.
> > >
> > > dev_err_probe() must be called with the device which is probing.
> > > Replace iio device by its parent device.
> > >
> > > Fixes: 0e346b2cfa85 ("iio: adc: stm32-adc: add vrefint calibration support")
> > >
>
> I'll fix it when applying, but no blank line between Fixes tag and the others.
Applied to the fixes-togreg branch of iio.git.
I'll probably do a pull request later this week,
Jonathan
>
> > > Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> >
> > Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> >
> > > ---
> > > Changes in v2:
> > > - Use parent device from indio_dev instead of private structure
> > > ---
> > > drivers/iio/adc/stm32-adc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> > > index 7f1fb36c747c..341afdd342cc 100644
> > > --- a/drivers/iio/adc/stm32-adc.c
> > > +++ b/drivers/iio/adc/stm32-adc.c
> > > @@ -1986,7 +1986,7 @@ static int stm32_adc_populate_int_ch(struct iio_dev *indio_dev, const char *ch_n
> > > /* Get calibration data for vrefint channel */
> > > ret = nvmem_cell_read_u16(&indio_dev->dev, "vrefint", &vrefint);
> > > if (ret && ret != -ENOENT) {
> > > - return dev_err_probe(&indio_dev->dev, ret,
> > > + return dev_err_probe(indio_dev->dev.parent, ret,
> > > "nvmem access error\n");
> > > }
> > > if (ret == -ENOENT)
> > >
> >
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-11-27 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 14:38 [PATCH v2] iio: adc: stm32: fix null pointer on defer_probe error Olivier Moysan
2021-11-22 14:41 ` Ahmad Fatoum
2021-11-22 14:45 ` Jonathan Cameron
2021-11-27 16:10 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211127161026.2e725d5a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@foss.st.com \
--cc=vulab@iscas.ac.cn \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox