Re: [PATCH v5 12/13] gpio: Add support for Airoha EN7523 GPIO controller

Felix Fietkau
2021-12-12T07:01:12Z

On 2021-12-05 00:57, Linus Walleij wrote:
> On Thu, Dec 2, 2021 at 6:59 PM Felix Fietkau <nbd@nbd.name> wrote:
>
>> I just looked at the datasheet and the driver code again, and I think
>> EN7523 is too strange for proper generic GPIO support.
>
> Yup I see that John explained it to me in the past, no problem.
> Let's do it like this then, but just drop select GPIO_GENERIC
> from KConfig since it's not used.
>
> With that oneliner change:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij
The generic GPIO API is still used for the data register. The driver
calls bgpio_init(), so you suggested oneliner change won't work.

- Felix