From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84F2DC433EF for ; Mon, 29 Nov 2021 17:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h7MnG8jmSBKpkt2XyG4TpPGVlhogibJ8JDliEuK5VJk=; b=xYzEGCcVKwT1Pm e9Ya4t0L4tSZMuPB/8y6iMXvx4BuIXvF3zObVetWr4NW378cUz3+jRxs1LcbAXggMYv2bm8K9DiJd imzs8wITsjvXIIM7W5H2XzParc/+rE6ubDVtF+qQj8nH6VMUfLluY0zxE72kaOAkm8zZkIgfLIt8J 9qjFSE9R2hj3OAft0LKILjQ+H5PO0eVsiOxCE1usGxunNXA9j9+u6ho0YTVwUPoxjQbPDOpIH5UBa viEAQt6dV90cMn7EXFeS1P0ZUabfatktV+yTrdlASDEfweORwZrA2wJfHZVsIz9UsQWFKFEcoybbW +KVzFnfycXVyYSUTyv2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrk9e-001YWc-KD; Mon, 29 Nov 2021 17:09:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrk9Z-001YVs-U1 for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 17:09:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C9A31063; Mon, 29 Nov 2021 09:09:21 -0800 (PST) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 150B83F5A1; Mon, 29 Nov 2021 09:09:18 -0800 (PST) Date: Mon, 29 Nov 2021 17:09:11 +0000 From: Lorenzo Pieralisi To: Baruch Siach Cc: Andy Gross , Bjorn Andersson , Selvam Sathappan Periakaruppan , Kathiravan T , Bjorn Helgaas , Rob Herring , Thierry Reding , Jonathan Hunter , Jingoo Han , Gustavo Pimentel , Robert Marko , devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/3] PCI: qcom: add support for IPQ60xx PCIe controller Message-ID: <20211129170911.GA26953@lpieralisi> References: <87lf2wkugd.fsf@tarshish> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87lf2wkugd.fsf@tarshish> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_090922_107405_0E8D29AB X-CRM114-Status: GOOD ( 35.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 14, 2021 at 09:02:32AM +0300, Baruch Siach wrote: > Hi Andy, Bjorn, > > On Mon, Aug 30 2021, Baruch Siach wrote: > > From: Selvam Sathappan Periakaruppan > > > > IPQ60xx series of SoCs have one port of PCIe gen 3. Add support for that > > platform. > > > > The code is based on downstream[1] Codeaurora kernel v5.4 (branch > > win.linuxopenwrt.2.0). > > > > Split out the DBI registers access part from .init into .post_init. DBI > > registers are only accessible after phy_power_on(). > > > > [1] https://source.codeaurora.org/quic/qsdk/oss/kernel/linux-ipq-5.4/ > > Can I get your ack on this? DT bits are already in Linus' tree, as > well as the PHY. So this is the only missing part for IPQ60xx PCIe > support. I need their ACK to proceed. Thanks, Lorenzo > Thanks, > baruch > > > > > Signed-off-by: Selvam Sathappan Periakaruppan > > Signed-off-by: Baruch Siach > > --- > > v3: > > * Drop speed setup; rely on generic code (Rob Herring) > > > > * Drop unused CLK_RATE macros (Bjorn Helgaas) > > > > * Minor formatting fixes (Bjorn Helgaas) > > > > * Add reference to downstream Codeaurora kernel tree (Bjorn Helgaas) > > > > v2: > > * Drop ATU configuration; rely on common code instead > > > > * Use more common register macros > > > > * Use bulk clk and reset APIs > > --- > > drivers/pci/controller/dwc/pcie-designware.h | 1 + > > drivers/pci/controller/dwc/pcie-qcom.c | 141 +++++++++++++++++++ > > 2 files changed, 142 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > > index ea87809ee298..279c3778a13b 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware.h > > +++ b/drivers/pci/controller/dwc/pcie-designware.h > > @@ -76,6 +76,7 @@ > > > > #define GEN3_RELATED_OFF 0x890 > > #define GEN3_RELATED_OFF_GEN3_ZRXDC_NONCOMPL BIT(0) > > +#define GEN3_RELATED_OFF_RXEQ_RGRDLESS_RXTS BIT(13) > > #define GEN3_RELATED_OFF_GEN3_EQ_DISABLE BIT(16) > > #define GEN3_RELATED_OFF_RATE_SHADOW_SEL_SHIFT 24 > > #define GEN3_RELATED_OFF_RATE_SHADOW_SEL_MASK GENMASK(25, 24) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 8a7a300163e5..cb53fd574621 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -52,6 +52,10 @@ > > #define PCIE20_PARF_DBI_BASE_ADDR 0x168 > > #define PCIE20_PARF_SLV_ADDR_SPACE_SIZE 0x16C > > #define PCIE20_PARF_MHI_CLOCK_RESET_CTRL 0x174 > > +#define AHB_CLK_EN BIT(0) > > +#define MSTR_AXI_CLK_EN BIT(1) > > +#define BYPASS BIT(4) > > + > > #define PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT 0x178 > > #define PCIE20_PARF_AXI_MSTR_WR_ADDR_HALT_V2 0x1A8 > > #define PCIE20_PARF_LTSSM 0x1B0 > > @@ -168,6 +172,11 @@ struct qcom_pcie_resources_2_7_0 { > > struct clk *pipe_clk; > > }; > > > > +struct qcom_pcie_resources_2_9_0 { > > + struct clk_bulk_data clks[5]; > > + struct reset_control *rst; > > +}; > > + > > union qcom_pcie_resources { > > struct qcom_pcie_resources_1_0_0 v1_0_0; > > struct qcom_pcie_resources_2_1_0 v2_1_0; > > @@ -175,6 +184,7 @@ union qcom_pcie_resources { > > struct qcom_pcie_resources_2_3_3 v2_3_3; > > struct qcom_pcie_resources_2_4_0 v2_4_0; > > struct qcom_pcie_resources_2_7_0 v2_7_0; > > + struct qcom_pcie_resources_2_9_0 v2_9_0; > > }; > > > > struct qcom_pcie; > > @@ -1266,6 +1276,127 @@ static void qcom_pcie_post_deinit_2_7_0(struct qcom_pcie *pcie) > > clk_disable_unprepare(res->pipe_clk); > > } > > > > +static int qcom_pcie_get_resources_2_9_0(struct qcom_pcie *pcie) > > +{ > > + struct qcom_pcie_resources_2_9_0 *res = &pcie->res.v2_9_0; > > + struct dw_pcie *pci = pcie->pci; > > + struct device *dev = pci->dev; > > + int ret; > > + > > + res->clks[0].id = "iface"; > > + res->clks[1].id = "axi_m"; > > + res->clks[2].id = "axi_s"; > > + res->clks[3].id = "axi_bridge"; > > + res->clks[4].id = "rchng"; > > + > > + ret = devm_clk_bulk_get(dev, ARRAY_SIZE(res->clks), res->clks); > > + if (ret < 0) > > + return ret; > > + > > + res->rst = devm_reset_control_array_get_exclusive(dev); > > + if (IS_ERR(res->rst)) > > + return PTR_ERR(res->rst); > > + > > + return 0; > > +} > > + > > +static void qcom_pcie_deinit_2_9_0(struct qcom_pcie *pcie) > > +{ > > + struct qcom_pcie_resources_2_9_0 *res = &pcie->res.v2_9_0; > > + > > + clk_bulk_disable_unprepare(ARRAY_SIZE(res->clks), res->clks); > > +} > > + > > +static int qcom_pcie_init_2_9_0(struct qcom_pcie *pcie) > > +{ > > + struct qcom_pcie_resources_2_9_0 *res = &pcie->res.v2_9_0; > > + struct device *dev = pcie->pci->dev; > > + int ret; > > + > > + ret = reset_control_assert(res->rst); > > + if (ret) { > > + dev_err(dev, "reset assert failed (%d)\n", ret); > > + return ret; > > + } > > + > > + usleep_range(2000, 2500); > > + > > + ret = reset_control_deassert(res->rst); > > + if (ret) { > > + dev_err(dev, "reset deassert failed (%d)\n", ret); > > + return ret; > > + } > > + > > + /* > > + * Don't have a way to see if the reset has completed. > > + * Wait for some time. > > + */ > > + usleep_range(2000, 2500); > > + > > + ret = clk_bulk_prepare_enable(ARRAY_SIZE(res->clks), res->clks); > > + if (ret) > > + goto err_reset; > > + > > + return 0; > > + > > + /* > > + * Not checking for failure, will anyway return > > + * the original failure in 'ret'. > > + */ > > +err_reset: > > + reset_control_assert(res->rst); > > + > > + return ret; > > +} > > + > > +static int qcom_pcie_post_init_2_9_0(struct qcom_pcie *pcie) > > +{ > > + struct dw_pcie *pci = pcie->pci; > > + u16 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); > > + u32 val; > > + int i; > > + > > + writel(SLV_ADDR_SPACE_SZ, > > + pcie->parf + PCIE20_v3_PARF_SLV_ADDR_SPACE_SIZE); > > + > > + val = readl(pcie->parf + PCIE20_PARF_PHY_CTRL); > > + val &= ~BIT(0); > > + writel(val, pcie->parf + PCIE20_PARF_PHY_CTRL); > > + > > + writel(0, pcie->parf + PCIE20_PARF_DBI_BASE_ADDR); > > + > > + writel(DEVICE_TYPE_RC, pcie->parf + PCIE20_PARF_DEVICE_TYPE); > > + writel(BYPASS | MSTR_AXI_CLK_EN | AHB_CLK_EN, > > + pcie->parf + PCIE20_PARF_MHI_CLOCK_RESET_CTRL); > > + writel(GEN3_RELATED_OFF_RXEQ_RGRDLESS_RXTS > > + | GEN3_RELATED_OFF_GEN3_ZRXDC_NONCOMPL, > > + pci->dbi_base + GEN3_RELATED_OFF); > > + > > + writel(MST_WAKEUP_EN | SLV_WAKEUP_EN | MSTR_ACLK_CGC_DIS > > + | SLV_ACLK_CGC_DIS | CORE_CLK_CGC_DIS | > > + AUX_PWR_DET | L23_CLK_RMV_DIS | L1_CLK_RMV_DIS, > > + pcie->parf + PCIE20_PARF_SYS_CTRL); > > + > > + writel(0, pcie->parf + PCIE20_PARF_Q2A_FLUSH); > > + > > + dw_pcie_dbi_ro_wr_en(pci); > > + writel(PCIE_CAP_LINK1_VAL, pci->dbi_base + offset + PCI_EXP_SLTCAP); > > + > > + /* Configure PCIe link capabilities for ASPM */ > > + val = readl(pci->dbi_base + offset + PCI_EXP_LNKCAP); > > + val &= ~PCI_EXP_LNKCAP_ASPMS; > > + writel(val, pci->dbi_base + offset + PCI_EXP_LNKCAP); > > + > > + writel(PCI_EXP_DEVCTL2_COMP_TMOUT_DIS, pci->dbi_base + offset + > > + PCI_EXP_DEVCTL2); > > + > > + for (i = 0; i < 256; i++) > > + writel(0x0, pcie->parf + PCIE20_PARF_BDF_TO_SID_TABLE_N > > + + (4 * i)); > > + > > + return 0; > > +} > > + > > static int qcom_pcie_link_up(struct dw_pcie *pci) > > { > > u16 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); > > @@ -1456,6 +1587,15 @@ static const struct qcom_pcie_ops ops_1_9_0 = { > > .config_sid = qcom_pcie_config_sid_sm8250, > > }; > > > > +/* Qcom IP rev.: 2.9.0 Synopsys IP rev.: 5.00a */ > > +static const struct qcom_pcie_ops ops_2_9_0 = { > > + .get_resources = qcom_pcie_get_resources_2_9_0, > > + .init = qcom_pcie_init_2_9_0, > > + .post_init = qcom_pcie_post_init_2_9_0, > > + .deinit = qcom_pcie_deinit_2_9_0, > > + .ltssm_enable = qcom_pcie_2_3_2_ltssm_enable, > > +}; > > + > > static const struct dw_pcie_ops dw_pcie_ops = { > > .link_up = qcom_pcie_link_up, > > .start_link = qcom_pcie_start_link, > > @@ -1555,6 +1695,7 @@ static const struct of_device_id qcom_pcie_match[] = { > > { .compatible = "qcom,pcie-qcs404", .data = &ops_2_4_0 }, > > { .compatible = "qcom,pcie-sdm845", .data = &ops_2_7_0 }, > > { .compatible = "qcom,pcie-sm8250", .data = &ops_1_9_0 }, > > + { .compatible = "qcom,pcie-ipq6018", .data = &ops_2_9_0 }, > > { } > > }; > > > -- > ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel