Re: [PATCH v5 07/13] clk: en7523: Add clock driver for Airoha EN7523 SoC

kernel test robot
2021-12-02T17:36:04Z

Hi Felix,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on clk/clk-next v5.16-rc3 next-20211202]
[cannot apply to linusw-gpio/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Felix-Fietkau/dt-bindings-Add-vendor-prefix-for-Airoha/20211130-033938
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: mips-randconfig-s031-20211202 (https://download.01.org/0day-ci/archive/20211203/202112030121.BuKKR1T4-lkp@intel.com/config)
compiler: mips64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/f1c5b70976ce5352c8ac2ae85739e1be63f59ec2
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Felix-Fietkau/dt-bindings-Add-vendor-prefix-for-Airoha/20211130-033938
git checkout f1c5b70976ce5352c8ac2ae85739e1be63f59ec2
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=mips SHELL=/bin/bash drivers/clk/ drivers/gpio/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
command-line: note: in included file:
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQUIRE redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_SEQ_CST redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_ACQ_REL redefined
builtin:0:0: sparse: this was the original definition
builtin:1:9: sparse: sparse: preprocessor token __ATOMIC_RELEASE redefined
builtin:0:0: sparse: this was the original definition
drivers/clk/clk-en7523.c:202:27: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *np_base @@ got void [noderef] __iomem *base @@
drivers/clk/clk-en7523.c:202:27: sparse: expected void *np_base
drivers/clk/clk-en7523.c:202:27: sparse: got void [noderef] __iomem *base
>> drivers/clk/clk-en7523.c:206:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:206:29: sparse: expected void const volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:206:29: sparse: got void *
>> drivers/clk/clk-en7523.c:208:29: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:208:29: sparse: expected void volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:208:29: sparse: got void *
drivers/clk/clk-en7523.c:213:29: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:213:29: sparse: expected void volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:213:29: sparse: got void *
drivers/clk/clk-en7523.c:217:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:217:29: sparse: expected void const volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:217:29: sparse: got void *
drivers/clk/clk-en7523.c:220:37: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:220:37: sparse: expected void volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:220:37: sparse: got void *
drivers/clk/clk-en7523.c:222:36: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:222:36: sparse: expected void volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:222:36: sparse: got void *
drivers/clk/clk-en7523.c:224:37: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:224:37: sparse: expected void volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:224:37: sparse: got void *
drivers/clk/clk-en7523.c:229:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:229:29: sparse: expected void const volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:229:29: sparse: got void *
drivers/clk/clk-en7523.c:230:37: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:230:37: sparse: expected void volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:230:37: sparse: got void *
drivers/clk/clk-en7523.c:232:36: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:232:36: sparse: expected void volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:232:36: sparse: got void *
drivers/clk/clk-en7523.c:241:27: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *np_base @@ got void [noderef] __iomem *base @@
drivers/clk/clk-en7523.c:241:27: sparse: expected void *np_base
drivers/clk/clk-en7523.c:241:27: sparse: got void [noderef] __iomem *base
drivers/clk/clk-en7523.c:244:29: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:244:29: sparse: expected void const volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:244:29: sparse: got void *
drivers/clk/clk-en7523.c:246:29: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void volatile [noderef] __iomem *mem @@ got void * @@
drivers/clk/clk-en7523.c:246:29: sparse: expected void volatile [noderef] __iomem *mem
drivers/clk/clk-en7523.c:246:29: sparse: got void *

vim +206 drivers/clk/clk-en7523.c

198
199 static int en7523_pci_enable(struct clk_hw *hw)
200 {
201 struct en_clk_gate *cg = container_of(hw, struct en_clk_gate, hw);
202 void *np_base = cg->base;
203 u32 val, mask;
204
205 /* Need to pull device low before reset */
> 206 val = readl(np_base + REG_PCI_CONTROL);
207 val &= ~(REG_PCI_CONTROL_PERSTOUT1 | REG_PCI_CONTROL_PERSTOUT);
> 208 writel(val, np_base + REG_PCI_CONTROL);
209 usleep_range(1000, 2000);
210
211 /* Enable PCIe port 1 */
212 val |= REG_PCI_CONTROL_REFCLK_EN1;
213 writel(val, np_base + REG_PCI_CONTROL);
214 usleep_range(1000, 2000);
215
216 /* Reset to default */
217 val = readl(np_base + REG_RESET_CONTROL);
218 mask = REG_RESET_CONTROL_PCIE1 | REG_RESET_CONTROL_PCIE2 |
219 REG_RESET_CONTROL_PCIEHB;
220 writel(val & ~mask, np_base + REG_RESET_CONTROL);
221 usleep_range(1000, 2000);
222 writel(val | mask, np_base + REG_RESET_CONTROL);
223 msleep(100);
224 writel(val & ~mask, np_base + REG_RESET_CONTROL);
225 usleep_range(5000, 10000);
226
227 /* Release device */
228 mask = REG_PCI_CONTROL_PERSTOUT1 | REG_PCI_CONTROL_PERSTOUT;
229 val = readl(np_base + REG_PCI_CONTROL);
230 writel(val & ~mask, np_base + REG_PCI_CONTROL);
231 usleep_range(1000, 2000);
232 writel(val | mask, np_base + REG_PCI_CONTROL);
233 msleep(250);
234
235 return 0;
236 }
237

---
0-DAY CI Kernel Test Service, Intel Corporation