From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EFEFC433F5 for ; Wed, 1 Dec 2021 16:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OzmLLGZ1dF90EO61rNWunhDVZdlInPOLV1acoxSNm1E=; b=bBJ2B0IHAAMfrP fXPOov+2HWjrwS20ZTuAoMI7wc1LGOC8TweA4m/0Yhh4bcCytEEFIP8gzrzzjkblYQCRwIfLiK0uP tM5FpxECpx005irwGgAGUaUlYnV/Gyc6S3AHUq3fSEjSrlrjTrSWqyHTlG9wt1Tt74FS6TS4Ek33/ XkUuK6z7BxixfZYNOESQE/MR0pcfpCAh3+ejGw08g2qS0Vwnd9Kti8i/Mfch5ln2aOPspPkZ5gLCH QoLbrttZMixbQIMV7541GMYDy0fG/yg/56DrVvgQCgmmB9I4FCKFPc/DiFbHFdZUtnyhuUCHbwh6x Avbi8qAz/s811IY2a7gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msS6R-009JBG-1a; Wed, 01 Dec 2021 16:05:03 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msS6M-009J9g-Qi for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 16:05:00 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msS6G-00018X-SS; Wed, 01 Dec 2021 17:04:52 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1msS6D-0007gg-9U; Wed, 01 Dec 2021 17:04:49 +0100 Date: Wed, 1 Dec 2021 17:04:49 +0100 From: Sascha Hauer To: Rob Herring Cc: dri-devel , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree@vger.kernel.org, Sascha Hauer , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-15?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 09/12] arm64: dts: rockchip: rk356x: Add HDMI nodes Message-ID: <20211201160449.GF25697@pengutronix.de> References: <20211117143347.314294-1-s.hauer@pengutronix.de> <20211117143347.314294-10-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:03:19 up 286 days, 19:27, 150 users, load average: 0.49, 0.50, 0.37 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_080458_880415_A34603DF X-CRM114-Status: GOOD ( 27.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 17, 2021 at 09:13:33AM -0600, Rob Herring wrote: > On Wed, Nov 17, 2021 at 8:34 AM Sascha Hauer wrote: > > > > Add support for the HDMI port found on RK3568. > > > > Signed-off-by: Sascha Hauer > > --- > > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 65 ++++++++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > index 6ebf7c14e096a..53be61a7ce595 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > @@ -472,18 +472,36 @@ vp0: port@0 { > > #address-cells = <1>; > > #size-cells = <0>; > > reg = <0>; > > + > > + vp0_out_hdmi: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&hdmi_in_vp0>; > > + status = "disabled"; > > + }; > > }; > > > > vp1: port@1 { > > #address-cells = <1>; > > #size-cells = <0>; > > reg = <1>; > > + > > + vp1_out_hdmi: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&hdmi_in_vp1>; > > + status = "disabled"; > > + }; > > }; > > > > vp2: port@2 { > > #address-cells = <1>; > > #size-cells = <0>; > > reg = <2>; > > + > > + vp2_out_hdmi: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&hdmi_in_vp2>; > > + status = "disabled"; > > + }; > > }; > > }; > > }; > > @@ -499,6 +517,53 @@ vop_mmu: iommu@fe043e00 { > > status = "disabled"; > > }; > > > > + hdmi: hdmi@fe0a0000 { > > + compatible = "rockchip,rk3568-dw-hdmi"; > > + reg = <0x0 0xfe0a0000 0x0 0x20000>; > > + interrupts = ; > > + clocks = <&cru PCLK_HDMI_HOST>, > > + <&cru CLK_HDMI_SFR>, > > + <&cru CLK_HDMI_CEC>, > > + <&cru HCLK_VOP>; > > + clock-names = "iahb", "isfr", "cec", "hclk"; > > + power-domains = <&power RK3568_PD_VO>; > > + reg-io-width = <4>; > > + rockchip,grf = <&grf>; > > + #sound-dai-cells = <0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&hdmitx_scl &hdmitx_sda &hdmitxm0_cec>; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + hdmi_in: port@0 { > > > The schema says there is only 1 'port' node. Please run schema > validation when making DT changes. > > However, an HDMI bridge should also define an output port to a > connector node (or another bridge). So the fix is to allow 'port@0' > and add an output port. The rockchip bindings traditionally don't have a connector explicitly specified in their device trees. I'll stick to that for the next round. If necessary I'll look later what it takes to add a connector node. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel