From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55C6AC433EF for ; Wed, 1 Dec 2021 16:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y/IQ1YgyK6kp8o1GeQi2IksfSiBDtC4FtjA/WhS8zGE=; b=tMhxgeZJpQaxqC evDTgvw+iFXluOu28GqXF2GZ6BHL8v3LFBTXd/3t3u1pA5WDYgDCzKOGPgi15dYgZUyknMts3moFr EF5OXsom64amLXPF9eiPrOXsegc2OPnM3s547vAAKfJzkW7kUCWSMge8+er6BqrptPrXGwaFFoISZ ZY3CXkx3t0SU/sNovjO9PXHgIzGm7zPJUFMflfg28PZDSglqBBroUxjYECMY8vIdLgm3y10eauofF DTqcK2sp8ifSOo0sR4U4iz6vDSvcjgU8d01xOJDaoWuHmWA1ZuSr5ZPyuY6X04DwHeRG2cUV1ffcs hIwkkLsdL5OoQdkaobvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msSfR-009OlO-I7; Wed, 01 Dec 2021 16:41:13 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msSfN-009Ok1-3W for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 16:41:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638376866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnH7pitgX4lHmYlmAxxzezWYSXvVY830GNF3XqnXOcQ=; b=CGzh5whjJ7q3ePFVaPG5/oFoFm6Jj4DE9fkrgTSYONeE1w3jU0HJDlRYAmy5lLZIU/Swhk IlncOtRsXUl2n+0l20B9HatMlAzxD2i2p7hy+ex8E5wwDhyoe+eWFUmy+jhd1Ph2FlvL/n fh232Wrgkcj7Pawjf+joGyx5NzLyQ/o= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-iUnvFGmTPNCzLgHqfV8OCQ-1; Wed, 01 Dec 2021 11:41:05 -0500 X-MC-Unique: iUnvFGmTPNCzLgHqfV8OCQ-1 Received: by mail-ed1-f71.google.com with SMTP id m12-20020a056402430c00b003e9f10bbb7dso20812306edc.18 for ; Wed, 01 Dec 2021 08:41:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=SnH7pitgX4lHmYlmAxxzezWYSXvVY830GNF3XqnXOcQ=; b=qClM80z+mjnJgIqMYbs7hncgV57KrRrfzbEBqhemPQQYkF280N2w6xabbAQJ9tCxEK s9qfvO96HR7jeRFwDPSzd+1mo2/cdOH7tMWfgOQQzwtYa5g3BWi2sNhFTHniULqRJq4c zUqSqjewtQuvrqkRjWu/9mGHfd8ORRNiwAqOJJDOWrlyNGAOu0weEdGnarpWnH5pnhBv lN/zVSq5HrRuDCV5ifEnUS+1MUYD7INHdX7q8Bm9pQj08gcMkvmkU1hSKbjlNvhgp4UF 3CaRu6reio6FDcci7Wvq5I7FvbX1vJyKFI7EvkcdnHSm2tqIEYJCPz1lrWEKb/ReyGh2 118A== X-Gm-Message-State: AOAM532Z4qKF+enITwolnya6Mpn6/uQLH2ZnySQ2EqfqmAb0JeMhxkKb XNBZQEfSd7zTrreC9qKTCZIMkbM5RfbH/i1F0eQd+S+SsheWt6RwGmwFxvFUnnl1VuZXrZFVTzw e1yNNZMsZGBXr6H4HgUW9ApK+VR7ZBoUgn0Q= X-Received: by 2002:a17:907:7e96:: with SMTP id qb22mr8301417ejc.469.1638376864203; Wed, 01 Dec 2021 08:41:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7NgTpX038FPeTelSCzUfb+R+QmNIuw2Yq+6qAI1XJAIRnYJhRSKw++EkKdFdXuTjVs3aJVA== X-Received: by 2002:a17:907:7e96:: with SMTP id qb22mr8301380ejc.469.1638376863918; Wed, 01 Dec 2021 08:41:03 -0800 (PST) Received: from gator (cst2-173-70.cust.vodafone.cz. [31.30.173.70]) by smtp.gmail.com with ESMTPSA id s4sm174995ejn.25.2021.12.01.08.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 08:41:02 -0800 (PST) Date: Wed, 1 Dec 2021 17:41:00 +0100 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: kvm@vger.kernel.org, maz@kernel.org, qemu-arm@nongnu.org, idan.horowitz@gmail.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [kvm-unit-tests PATCH v8 04/10] run_tests.sh: add --config option for alt test set Message-ID: <20211201164100.57ima4v5ppqojmu7@gator> References: <20211118184650.661575-1-alex.bennee@linaro.org> <20211118184650.661575-5-alex.bennee@linaro.org> <20211124164859.4enqimrptr3pfdkp@gator> <87o860xpkr.fsf@linaro.org> MIME-Version: 1.0 In-Reply-To: <87o860xpkr.fsf@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_084109_271429_E5C7805E X-CRM114-Status: GOOD ( 25.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 01, 2021 at 04:20:02PM +0000, Alex Benn=E9e wrote: > = > Andrew Jones writes: > = > > On Thu, Nov 18, 2021 at 06:46:44PM +0000, Alex Benn=E9e wrote: > >> The upcoming MTTCG tests don't need to be run for normal KVM unit > >> tests so lets add the facility to have a custom set of tests. > > > > I think an environment variable override would be better than this comm= and > > line override, because then we could also get mkstandalone to work with > > the new unittests.cfg files. Or, it may be better to just add them to > > the main unittests.cfg with lines like these > > > > groups =3D nodefault mttcg > > accel =3D tcg > > > > That'll "dirty" the logs with SKIP ... (test marked as manual run only) > > for each one, but at least we won't easily forget about running them fr= om > > time to time. > = > So what is the meaning of accel here? Is it: > = > - this test only runs on accel FOO > = > or > = > - this test defaults to running on accel FOO > = > because while the tests are for TCG I want to run them on KVM (so I can > validate the test on real HW). If I have accel=3Dtcg then: > = > env ACCEL=3Dkvm QEMU=3D$HOME/lsrc/qemu.git/builds/all/qemu-system-aarch= 64 ./run_tests.sh -g mttcg > SKIP tlbflush-code::all_other (tcg only, but ACCEL=3Dkvm) > SKIP tlbflush-code::page_other (tcg only, but ACCEL=3Dkvm) > SKIP tlbflush-code::all_self (tcg only, but ACCEL=3Dkvm) > ... > = > so I can either drop the accel line and rely on nodefault to ensure it > doesn't run normally or make the env ACCEL processing less anal about > preventing me running TCG tests under KVM. What do you think? Just drop the 'accel =3D tcg' line. I only suggested it because I didn't know you also wanted to run the MTTCG "specific" tests under KVM. Now, that I do, I wonder why we wouldn't run them all the time, i.e. no nodefault group? Do the tests not exercise enough hypervisor code to be worth the energy used to run them? Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel