From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4FA6C433EF for ; Wed, 1 Dec 2021 17:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bbCCiscMzevLRQ/0FKp2GdwHPXiSmE6+qw0YhHqq5lQ=; b=O978iaJLAdmQ7u /w6Pj2j1ln6Zf8CxFak7msIf/TlIT1yLVfWu8bkMLD0V/oJQ9fQWdckhb6iZlpozz3BJfzLoLKUXr 2Mgb59abb4bCreAL60l7fvBNuS7TcQjx5Llj1OHYJIxJ/qBt+f4uNY7IT6XhR9MQKXeoUd7wYTt64 PH3vRWhMjUphRHTQ59D+QeNWUHVhjOhPiBFtPC2JBk+gv/CMnpNsG5Qrd78NXE9a0OxfsJdLki6iL 5CsjW+l9LrYDg1oG6O9t7a5OD962+lMBA0eAFNhY+HtRbXQafA1MmyehLbI/lK+F24Za1TW6fwd06 848Ebbb5sAV2lWM8wtog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msTEi-009XLe-7c; Wed, 01 Dec 2021 17:17:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msTBF-009W5o-PP; Wed, 01 Dec 2021 17:14:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5279414BF; Wed, 1 Dec 2021 09:14:04 -0800 (PST) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C0B623F766; Wed, 1 Dec 2021 09:14:02 -0800 (PST) Date: Wed, 1 Dec 2021 17:13:56 +0000 From: Lorenzo Pieralisi To: Andy Shevchenko Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Fainelli , Rob Herring , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Jim Quinlan , Nicolas Saenz Julienne Subject: Re: [PATCH v2 1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only Message-ID: <20211201171356.GA15686@lpieralisi> References: <20211115112000.23693-1-andriy.shevchenko@linux.intel.com> <163837398126.3058.11030158077196581603.b4-ty@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_091405_922714_45E94A6A X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 01, 2021 at 06:01:46PM +0200, Andy Shevchenko wrote: > On Wed, Dec 01, 2021 at 03:53:21PM +0000, Lorenzo Pieralisi wrote: > > On Mon, 15 Nov 2021 13:20:00 +0200, Andy Shevchenko wrote: > > > Use BIT() as __GENMASK() is for internal use only. The rationale > > > of switching to BIT() is to provide better generated code. The > > > GENMASK() against non-constant numbers may produce an ugly assembler > > > code. On contrary the BIT() is simply converted to corresponding shift > > > operation. > > > > > > Note, it's the only user of __GENMASK() in the kernel outside of its own realm. > > > > > > [...] > > > > Applied to pci/brcmstb, thanks! > > > > [1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only > > https://git.kernel.org/lpieralisi/pci/c/6ec6eb949d > > Thanks, but there is another patch which changes the logic a bit and cleans up > more. > > From: Florian Fainelli > Subject: [PATCH] PCI: brcmstb: Do not use __GENMASK Right, I pulled that one instead, thanks for the heads-up. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel