From: Kees Cook <keescook@chromium.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: daniel.lezcano@linaro.org, tglx@linutronix.de,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, van.freenix@gmail.com,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 1/2] clocksource/drivers/imx-sysctr: mark two variable with __ro_after_init
Date: Thu, 2 Dec 2021 16:05:19 -0800 [thread overview]
Message-ID: <202112021604.E65EDA8D6@keescook> (raw)
In-Reply-To: <20211201125030.2307746-1-peng.fan@oss.nxp.com>
On Wed, Dec 01, 2021 at 08:50:29PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> sys_ctr_base and cmpcr will not be updated after init, so mark
> as __ro_after_init.
>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Always nice to get more of these. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks!
-Kees
> ---
> drivers/clocksource/timer-imx-sysctr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-imx-sysctr.c b/drivers/clocksource/timer-imx-sysctr.c
> index 18b90fc56bfc..2b309af11266 100644
> --- a/drivers/clocksource/timer-imx-sysctr.c
> +++ b/drivers/clocksource/timer-imx-sysctr.c
> @@ -20,8 +20,8 @@
>
> #define SYS_CTR_CLK_DIV 0x3
>
> -static void __iomem *sys_ctr_base;
> -static u32 cmpcr;
> +static void __iomem *sys_ctr_base __ro_after_init;
> +static u32 cmpcr __ro_after_init;
>
> static void sysctr_timer_enable(bool enable)
> {
> --
> 2.25.1
>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-03 0:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 12:50 [PATCH 1/2] clocksource/drivers/imx-sysctr: mark two variable with __ro_after_init Peng Fan (OSS)
2021-12-01 12:50 ` [PATCH 2/2] clocksource: timer-imx-sysctr: set cpumask to cpu_possible_mask Peng Fan (OSS)
2021-12-02 10:22 ` Daniel Lezcano
2021-12-05 12:53 ` Peng Fan
2021-12-03 0:05 ` Kees Cook [this message]
2021-12-09 13:15 ` [PATCH 1/2] clocksource/drivers/imx-sysctr: mark two variable with __ro_after_init Daniel Lezcano
2021-12-14 8:25 ` Peng Fan
2021-12-14 9:19 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202112021604.E65EDA8D6@keescook \
--to=keescook@chromium.org \
--cc=daniel.lezcano@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=van.freenix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox