From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 864D6C433FE for ; Sat, 4 Dec 2021 10:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=81xeGhCQ+ddSDGXhaicajZbhy8OLd2HlBi+4uD6LSy8=; b=cEiuAXENXxD3FH GLIaLbiq/xNxHnLNxlV9qGs8OUPXLdekMPUiGuYPC/NwRNqZiYeKxwfJm5a+jg+ugyHwvBqf0njc+ gTU9++DR2nx+dT5rgBELYtB6w/gzGU9gfYiHLcd3usbo6Kh3ixuyRK8hV8zjQsFA33tVsvkspGyw5 z1plEMguFvcSPRSFVihz8tou2hshYN4zkhaxCui7pcIHQOF9O5h3QAgrGEX1f6DwpY6tY7yFjIQcL v9+gmxfuUuNlfMir2fjvVCzC/ec1h5UXGKpGVhfEpwfPY1slttLs9zT6L1wYBA9/YpoeXB8iXr+sG szGnSTvouxafzlDb2s6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtSHx-000CiZ-7X; Sat, 04 Dec 2021 10:29:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtSHt-000CiB-OS for linux-arm-kernel@lists.infradead.org; Sat, 04 Dec 2021 10:29:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 398B660BBA; Sat, 4 Dec 2021 10:29:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EE1CC341C4; Sat, 4 Dec 2021 10:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638613740; bh=zie+iNzyGc5QjUZyAraGpX3z1Dpe6EUlKoCCVJGtokA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eR+otevqZjQGxhdJ06uJjevrnOxBlTXIiPC0FWHtQ2i4J5Ne5KO+H/5nnhLqU2d4n ZHoH0fmRq5yFOfbfXs4TMtfz9xdOn41IqSgGkr4gxiFJJNvR0n+H2c37Byx77A5+EO +fUZiIzD0eNaQkpskaTMqvYCwnPgF2ByPhf5aBEaV1WpafgdmSyIYkmOstgvnab6So eJTAusGF/TF/apFjeLZRkQc6SsrjlHD7p2q2Sw+e9m/R8INshzSe2PXJUDjbgA+hhX 4ywqmxZJegvZJ8eNit3K/7+eEYRW7F4fHu+7majMbSqlIvmps1apLdtizzbVCgle2t +8SmDj1HlJcDA== Date: Sat, 4 Dec 2021 11:28:54 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Chris Packham Cc: andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] arm/arm64: dts: Add MV88E6393X to CN9130-CRB device tree Message-ID: <20211204112854.2f4aa818@thinkpad> In-Reply-To: <20211018011211.3836590-3-chris.packham@alliedtelesis.co.nz> References: <20211018011211.3836590-1-chris.packham@alliedtelesis.co.nz> <20211018011211.3836590-3-chris.packham@alliedtelesis.co.nz> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211204_022901_887883_2646C950 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chris, some nitpicks here, > + > + sfp: sfp { > + compatible = "sff,sfp"; > + i2c-bus = <&cp0_i2c1>; > + mod-def0-gpios = <&expander0 3 GPIO_ACTIVE_LOW>; > + los-gpio = <&expander0 15 GPIO_ACTIVE_HIGH>; > + tx-disable-gpio = <&expander0 2 GPIO_ACTIVE_HIGH>; > + tx-fault-gpio = <&cp0_gpio1 24 GPIO_ACTIVE_HIGH>; maximum-power-milliwatt = <3000>; AFAIK ... > + port@9 { > + reg = <9>; > + label = "p9"; > + phy-mode = "10gbase-r"; > + sfp = <&sfp>; > + managed = "in-band-status"; > + }; > + > + port@10 { port@a (hexadecimal in node name) > + reg = <10>; > + label = "cpu"; > + ethernet = <&cp0_eth0>; Marek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel