From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9A84C433EF for ; Sat, 4 Dec 2021 19:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GSqBMWMXrBcFzXdesWT8LiwKIs8HVaq8mstVQ5BQk3g=; b=Tg5nepqF5WmVnB cbz9TtiH4NB08F4lf29w683MnkVokyVlUB8LN0gBqMNZJx1dy0qbjfWbeXs1kw9HSgMsrSCFUQmXA +ymnDEBOBIkGXIAe28DczVZo/uFtE0igcvziO9B31p8gcomyJ5V5DHJgFEJa0q0zcP6nrZzNmROfq +T4LmP7HxkjHwcMOvAG50Ms0SSkJLseLhWR/1odynNk98qC5PRX3Icxk2zMTViNm1xcHww9uTyGlY 2TOC+/H6XKRp2iDEHYRN+AQSaoluG0DrF86gChvW4ruR04729uJOVK82QIo5eZobL7JIRWURorxE/ uAqITsxNK635unEydvVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtazB-000hEW-Q3; Sat, 04 Dec 2021 19:46:17 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mtaz7-000hDf-J6 for linux-arm-kernel@lists.infradead.org; Sat, 04 Dec 2021 19:46:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1Wx0sNFc4nRwhtP15w8D3y+GxIPogNNpQRDFakzYmm0=; b=hFNtobnXBDHvelC3AlP2yV1DEC 8lNkI+0+AhlngJ9q0LW3UGxj2Yns4Q6tC6ljiHqprE6kbnHOuIKoSsCFk2Q2qGM4fAmny9t8oHDo1 LAm4HAiOANCU1pjkYnpKZLz4jDNj8M6v6RGM2Y6UNLv2cCd4Cb+QKLCGNq8g3U8pOLpo=; Received: from p200300ccff382c001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff38:2c00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1mtayx-0006rL-SI; Sat, 04 Dec 2021 20:46:04 +0100 Date: Sat, 4 Dec 2021 20:46:02 +0100 From: Andreas Kemnade To: Alistair Francis Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, alistair23@gmail.com, dmitry.torokhov@gmail.com, linus.walleij@linaro.org, rydberg@bitmath.org, =?UTF-8?B?TXlsw6huZQ==?= Josserand , Maxime Ripard Subject: Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen Message-ID: <20211204204602.58b6cc12@aktux> In-Reply-To: <20211202122021.43124-2-alistair@alistair23.me> References: <20211202122021.43124-1-alistair@alistair23.me> <20211202122021.43124-2-alistair@alistair23.me> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211204_114613_853049_44CCEA91 X-CRM114-Status: GOOD ( 10.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, 2 Dec 2021 22:20:18 +1000 Alistair Francis wrote: > +static int cyttsp5_setup_input_device(struct device *dev) > +{ > + struct cyttsp5 *ts = dev_get_drvdata(dev); > + struct cyttsp5_sysinfo *si = &ts->sysinfo; > + int max_x, max_y, max_p; > + int max_x_tmp, max_y_tmp; > + int error; > + > + __set_bit(EV_REL, ts->input->evbit); > + > + max_x_tmp = si->sensing_conf_data.res_x; > + max_y_tmp = si->sensing_conf_data.res_y; > + max_x = max_x_tmp - 1; > + max_y = max_y_tmp - 1; > + max_p = si->sensing_conf_data.max_z; > + > + error = input_mt_init_slots(ts->input, si->tch_abs[CY_TCH_T].max, > + INPUT_MT_DROP_UNUSED | INPUT_MT_POINTER); > + if (error < 0) > + return error; still some issues with X, sometimes it is even a mouse, depending on config. hmm, why is it INPUT_MT_POINTER and not INPUT_MT_DIRECT? #define INPUT_MT_POINTER 0x0001 /* pointer device, e.g. trackpad */ #define INPUT_MT_DIRECT 0x0002 /* direct device, e.g. touchscreen */ Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel