From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CADE2C433F5 for ; Mon, 6 Dec 2021 07:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cU2oVyR629xqOzTMaLW82XOvG9Dod7VNiEpiMdS/bXs=; b=RyWuRnKP/VG5r+ KGsOeClaGJifkakd0oZDaLefDiLoIGCP1/OiYZWBIunFZb1NTRV2s/eLKgX28h7H/oqawl2KwZi4p yOG60qNzVYiwNQhtTKP+75mb9AB9IMZgNu1QXx7Pj7QhHGJuqklbb3ciRVKjQe4NgDymlcfn55ITP 9RkDR3PCqetFOcq+BK4GjPymmP0J3Z+1DHpyOqkye2KRQor/kDlzxflYVl+ejDMoQAGfyHDMff9o8 P25MtAHS6uJCTjtSXuqm8idwZfiGYUMMubekwIDMrypWvjlUqb8ZOGdUId47+LS7jdKEgirsWM7fg zyRySrd2SeGVfVhvdqcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mu82k-002jE9-4v; Mon, 06 Dec 2021 07:04:10 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mu82g-002jDE-Ns for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 07:04:08 +0000 Received: by mail-pf1-x42f.google.com with SMTP id p13so9335633pfw.2 for ; Sun, 05 Dec 2021 23:04:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HXwTAzkvUDjhhLa3JIAth4980gr9mc2XPQgpC9SXV2k=; b=EuuusfaKwDO78vIynmlmC+q9xyjLypNxyQP9l0ha5xjEPJsSBOFLbcyNcnc2GFaAKb nw3aVtAe1i4K/Ug9czH/IwJ7C46wF9bdREs1z52JztxkMFUnRtt252UskxMlFZx6zBJo tejOl1WwgLWCS/yEGnjSj+20CezTGG2hQ7QEJdRekC/DO1i/BjsC61LBTo65Pm+FIvK2 oeaKAgDINfVlfbM6hNMK5zibLodWrCPjuou+lCbBXibTJbYC+bYMFisqUE93N28THMR8 a3IyDuno6EUDuF06sT8VS83OlXcC4sdwuIm9rcVGyq/dji+tdR5Au/q16P2sD0LkDI0x iYFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HXwTAzkvUDjhhLa3JIAth4980gr9mc2XPQgpC9SXV2k=; b=yw8azedxHGnlCnnWLahWLgnxorBasiA142zc/Gcd1ptYlB1VhXLtwM7Ij0fNhui3mw zLnZ8HuENe5cE3BXWSq5kDOIRKLEZ1hOgd1PbcRlZf8pg9L509RqhCAdY3zUZ66NtTj6 ivep84zfU7eqAelhS6K4H9LBZuWKVu8sLydAhrolQ+k0Epwf5uLE4VGEcDAwKa7KpqAC YSna8hjRy4a2atGFO1Om6ab/3dQXF1vjzIJlxx2JS7FPyIOfauQsjNahFzwddcUplAfL m576IOzG00EtVueNAK9dCF/hoy89eMPjGXQ1ytOn2AcT9C4yVJkl8ja1ei2OJnvM7eOS mOeg== X-Gm-Message-State: AOAM530n0oRHyRLZbBpsm7wxHwA4GhbYF1G+Nu+TRc5weFHSIPmYonTX NihNTqZog4+F+ixiBNMM6bKn/AbJLUZjGT4s4p4= X-Google-Smtp-Source: ABdhPJzjLMthv5mO34i8EfRiYH7pph+S6Wp1Hk+X2XlKJmVy4wOGI/LF8C4azzeCKwWqapJQc8mjhQ== X-Received: by 2002:a63:8749:: with SMTP id i70mr17421400pge.511.1638774245629; Sun, 05 Dec 2021 23:04:05 -0800 (PST) Received: from leoy-ThinkPad-X240s (104.225.157.100.16clouds.com. [104.225.157.100]) by smtp.gmail.com with ESMTPSA id nh21sm9357961pjb.30.2021.12.05.23.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Dec 2021 23:04:05 -0800 (PST) Date: Mon, 6 Dec 2021 15:03:58 +0800 From: Leo Yan To: Leon Romanovsky Cc: "David S. Miller" , Jakub Kicinski , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Alexander Shishkin , Jan Harkes , coda@cs.cmu.edu, Paul Moore , Eric Paris , Balbir Singh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, codalist@coda.cs.cmu.edu, linux-audit@redhat.com Subject: Re: [PATCH v1 1/7] pid: Introduce helper task_is_in_root_ns() Message-ID: <20211206070358.GC42658@leoy-ThinkPad-X240s> References: <20211205145105.57824-1-leo.yan@linaro.org> <20211205145105.57824-2-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211205_230406_838316_78D43628 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Leon, On Mon, Dec 06, 2021 at 08:49:01AM +0200, Leon Romanovsky wrote: > On Sun, Dec 05, 2021 at 10:50:59PM +0800, Leo Yan wrote: [...] > > +static inline bool task_is_in_root_ns(struct task_struct *tsk) > > It is bad that this name doesn't reflect PID nature of this namespace. > Won't it better to name it task_is_in_init_pid_ns()? Yes, task_is_in_init_pid_ns() is more clear. Will respin for this. Thank you for suggestion! Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel