From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FD02C43217 for ; Mon, 6 Dec 2021 22:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=saVtA79TiuJqxoWVT5lgUbRLzwnRmSHp8E5tS1x+Xz8=; b=IkOAQXY3pN3Llc BON4bGB19gMtrGSiE+gWfooHV1vKTQJ2EB3aj92rA6tPls9HpKeImJRUEJv3n3/PJ6qKAiJcSQxVN NDOCGd6BlQptlBXQpQETqanSY6lvMwml9C0tZBmQaWu8swXOv/5FDhsVDzCYo2UvQQ3X/ZUkrqzT/ SdrGdRkNOi7EhXCyBkoINFLJNH8PjfZNsJp8fwX5n6Ai438eeuWuZFEe9IUt5l0neLf3wmME5evWp gAyFyWg7piIV5Y0AraF/XmyIPwn6qRJf04V/RniYi1Uf7KV0mjUgZr2eCJCyaAretY66rymhhS9T6 5ZNsDmJBVWDP4HT4YhRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muMdM-006FEG-G7; Mon, 06 Dec 2021 22:38:56 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muMdI-006FCw-KP for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 22:38:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 905BFB812A4; Mon, 6 Dec 2021 22:38:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 554F6C341C6; Mon, 6 Dec 2021 22:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638830329; bh=7SMczd1Ms9KPq4pJzopcSwHuEKGdzVZQ+Na/nRyxS7Y=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=b8berxhO3KkZKnh5IexHD2okQoHhzwaKr9iMhSGZDwmgJmfZiJDjCW90RWZoy9hL1 nC7mLgwgbxuGXFhXUajKr0vbQJ0WkdRdMy7G3z5sjJqiRyBQ1vy80v0UXJ56AtiVLU UQU3CN66VgPuDkiRbsYStFbKpLi7LYbUeyyTg/Dac3ai72wIf7Rh/qvifl+QuPebE5 yeiDn0A1kRaqdSmzCL1npP8kYQjrgL+7UgAIb6L1P6gLdes7ywWoaOv5JaRO1h3VXc J6JINQHlMbqFQ/+G5ojCywdKCROpyAKr6FmPmnFl3PSHL8BlEyY2APuPSP8Cl0tWuD FFvqLi7PvcX4Q== MIME-Version: 1.0 In-Reply-To: <20211204061042.1248028-7-Mr.Bossman075@gmail.com> References: <20211204061042.1248028-1-Mr.Bossman075@gmail.com> <20211204061042.1248028-7-Mr.Bossman075@gmail.com> Subject: Re: [PATCH v4 06/13] dt-bindings: clock: imx: Add documentation for i.MXRT clock From: Stephen Boyd Cc: mturquette@baylibre.com, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, gregkh@linuxfoundation.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com, adrian.hunter@intel.com, jirislaby@kernel.org, giulio.benetti@benettiengineering.com, nobuhiro1.iwamatsu@toshiba.co.jp, Mr.Bossman075@gmail.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, Jesse Taube , Rob Herring To: Jesse Taube , linux-imx@nxp.com Date: Mon, 06 Dec 2021 14:38:48 -0800 User-Agent: alot/0.9.1 Message-Id: <20211206223849.554F6C341C6@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_143852_991130_18630558 X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Jesse Taube (2021-12-03 22:10:35) > diff --git a/Documentation/devicetree/bindings/clock/imxrt-clock.yaml b/Documentation/devicetree/bindings/clock/imxrt-clock.yaml > new file mode 100644 > index 000000000000..8af48c59ff99 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imxrt-clock.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/imxrt-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Clock bindings for Freescale i.MXRT > + > +maintainers: > + - Giulio Benetti > + - Jesse Taube > + > +description: | > + The clock consumer should specify the desired clock by having the clock > + ID in its "clocks" phandle cell. See include/dt-bindings/clock/imxrt*-clock.h > + for the full list of i.MXRT clock IDs. > + > +properties: > + compatible: > + const: fsl,imxrt1050-ccm > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 2 > + > + clocks: > + minItems: 1 > + > + clock-names: > + minItems: 1 Why minitems vs. exactly 1 for osc? > + > + '#clock-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - '#clock-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + ccm@400fc000 { s/ccm/clock-controller/ > + compatible = "fsl,imxrt1050-ccm"; > + reg = <0x400fc000 0x4000>; > + interrupts = <95>, <96>; > + clocks = <&osc>; > + clock-names = "osc"; > + #clock-cells = <1>; > + }; > + > + Nitpick: Drop extra newline > + lpuart1: serial@40184000 { > + compatible = "fsl,imxrt1050-lpuart"; > + reg = <0x40184000 0x4000>; > + interrupts = <20>; > + clocks = <&clks IMXRT1050_CLK_LPUART1>; > + clock-names = "ipg"; > + }; > -- > 2.34.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel