From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97932C433F5 for ; Tue, 7 Dec 2021 21:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=3DSkGUgquLsDsMLC2euXpo7cekO25bDiJRnGjTRLZXg=; b=L7HG0N+auAXCPw h3Rhu3he9biDR6HzIRB+U6KPn/+g4DUBaVmytJdpwNDGzgLINLv/SKqWe8Otdl2Q3WvHxb3JOzrdj zZNBYaaqaLu3iarUWyKHMKnElgL8EtsQrnvag0AK0K2Oix1NClbiQH27156CBR+313+u7xcznFz8G K7+FrJnWz3KSXYdNsV5IkVVsCDQTnRTMek4UNVKyFpTtjOjlp2wvNFZZLldiyBybyySCFMyh4rZww srRVEZpOulzjGsLSBYL4tM9FcdmJNvldszmeuOhFUGj2S9hiwKUuu81x9/1HqwAy4EIg3wVXtEvFB wzG6vEjgBuP3PVITixvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muheX-00A7X1-IW; Tue, 07 Dec 2021 21:05:33 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muheQ-00A7Uk-Uw for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 21:05:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A06AFB81E86; Tue, 7 Dec 2021 21:05:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6C0FC341C3; Tue, 7 Dec 2021 21:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638911124; bh=SSlqi2avER7Dt/gWeQCpUUK2WPs6V3REpcTbyOpLSVo=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=CQtpmV/VopSugovJYtB6rKgOASfGm+plq9ohd+c4gicwGabcfRU6ytOddQjW3Ve3g tNsgaOjeq555aKWCr9jX9ODfSAmC5gTVJ3vse/nmE/bt6EDI8IgNQkIg/STXmf+7zE U64SEr9asqbhWIQiNhiBgpiH/BRtSY7WmUh34L91oWrRiTQR4AmZqrtRLVMJBHFyQ9 UasPXsz2PYCPtfItiij1woyf8fHZ+e13Xx+SVxc9GVYIn8V5Hs0PkqB4OagIliTaI+ V7FpgXy1X/0HnHOAWVtqEJ1pP+FwItrm6eFFL4yJzWnlD+4qQ//Q8RNQddmclqTqgt UL3+7UtH4ejJw== Date: Tue, 7 Dec 2021 15:05:22 -0600 From: Bjorn Helgaas To: Thomas Gleixner Cc: LKML , Marc Zygnier , Alex Williamson , Kevin Tian , Jason Gunthorpe , Megha Dey , Ashok Raj , linux-pci@vger.kernel.org, Cedric Le Goater , xen-devel@lists.xenproject.org, Juergen Gross , Greg Kroah-Hartman , Will Deacon , Santosh Shilimkar , iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org, Stuart Yoder , Laurentiu Tudor , Nishanth Menon , Tero Kristo , linux-arm-kernel@lists.infradead.org, Vinod Koul , Mark Rutland , Robin Murphy , Sinan Kaya Subject: Re: [patch V2 25/36] PCI/MSI: Provide MSI_FLAG_MSIX_CONTIGUOUS Message-ID: <20211207210522.GA77919@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211206210439.021277807@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_130527_205191_C53FB577 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 06, 2021 at 11:39:36PM +0100, Thomas Gleixner wrote: > Provide a domain info flag which makes the core code check for a contiguous > MSI-X index on allocation. That's simpler than checking it at some other > domain callback in architecture code. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Jason Gunthorpe Acked-by: Bjorn Helgaas > --- > drivers/pci/msi/irqdomain.c | 16 ++++++++++++++-- > include/linux/msi.h | 2 ++ > 2 files changed, 16 insertions(+), 2 deletions(-) > > --- a/drivers/pci/msi/irqdomain.c > +++ b/drivers/pci/msi/irqdomain.c > @@ -89,9 +89,21 @@ static int pci_msi_domain_check_cap(stru > if (pci_msi_desc_is_multi_msi(desc) && > !(info->flags & MSI_FLAG_MULTI_PCI_MSI)) > return 1; > - else if (desc->pci.msi_attrib.is_msix && !(info->flags & MSI_FLAG_PCI_MSIX)) > - return -ENOTSUPP; > > + if (desc->pci.msi_attrib.is_msix) { > + if (!(info->flags & MSI_FLAG_PCI_MSIX)) > + return -ENOTSUPP; > + > + if (info->flags & MSI_FLAG_MSIX_CONTIGUOUS) { > + unsigned int idx = 0; > + > + /* Check for gaps in the entry indices */ > + for_each_msi_entry(desc, dev) { > + if (desc->msi_index != idx++) > + return -ENOTSUPP; > + } > + } > + } > return 0; > } > > --- a/include/linux/msi.h > +++ b/include/linux/msi.h > @@ -376,6 +376,8 @@ enum { > MSI_FLAG_LEVEL_CAPABLE = (1 << 6), > /* Populate sysfs on alloc() and destroy it on free() */ > MSI_FLAG_DEV_SYSFS = (1 << 7), > + /* MSI-X entries must be contiguous */ > + MSI_FLAG_MSIX_CONTIGUOUS = (1 << 8), > }; > > int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel