From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2FDBC433F5 for ; Wed, 8 Dec 2021 17:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J2eJy6/mrYy9TFS22AnaBJKcsoys1x0aFh48VFDVOO0=; b=0t/QRJaVcdQqCP BzCj/nfOJBSpmk7uMut9C/ieBZ//BZkRGOikjTuwdjh390I3c5nHjZ2lO9iXRmbmRyxTexssjBklN lgAeCM/TG6CNE0LYfKl9luygOAbktQo8wG59/m6dD8RveMBlo9y3lHibgSE0gWug1NMP3lgg3V8JB UE5+ojWr8rALR+SigWrNkl1kwTIl3mk3YfZYQey18OPUzJdZZF8QAh/cVSVR6Vaf3t5hozq+IyPtY MpaLY2uGshVfR66ha2KBAybvS4GxqAQhBRM16zWCMgYUR8BTOLWVP5v8gV7gXAWwVmw3zSRzAFVQy hVuKA+wJnWJp2Ac8drpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv112-00DmZO-Kt; Wed, 08 Dec 2021 17:46:04 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv10y-00DmY4-TS for linux-arm-kernel@lists.infradead.org; Wed, 08 Dec 2021 17:46:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A62BEB82213; Wed, 8 Dec 2021 17:45:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9759FC341C8; Wed, 8 Dec 2021 17:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638985558; bh=Jx3EOS//BNcop0ND7pQzMMlMr2gVDNuw8TQ5ywrclRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kmNzrKQ3OnYmFnZ2a4Jomabp/a9q/yYrr0HjxsL29TK/HKq9JbbwZ3ySIjYUnI/Rf 9O1tlLVZmTmyMHxOO88CIxcuz8XvMCTo0yCShgw/35w7i7O3ws/48jZJefRhAgwz1d 2ZQUnXOH0H+xQstckdT5qaf83wv9Yg8QFtNbdzYH3jalwUGAn/tS+eLDhVSgG/lv3j JeAlClg3O55KUtlt74R5f607wI7FCCW02YiBl3GRebbX9Hvdd+zodgSzOV26+fDADx 1jPUJ2W4SSRHLld+gDMtUlGqszKEh/60YvQ+/SDYjprSMVmzV2bcXHjgH44C9sZ/sR rRB2DSjDB6ggg== Date: Wed, 8 Dec 2021 17:45:53 +0000 From: Will Deacon To: Quentin Perret Cc: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 4/6] KVM: arm64: Make __io_map_base static Message-ID: <20211208174552.GD820@willie-the-truck> References: <20211208152300.2478542-1-qperret@google.com> <20211208152300.2478542-5-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211208152300.2478542-5-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211208_094601_121557_59BD04BB X-CRM114-Status: GOOD ( 18.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 08, 2021 at 03:22:57PM +0000, Quentin Perret wrote: > The __io_map_base variable is used at EL2 to track the end of the > hypervisor's "private" VA range in nVHE protected mode. However it > doesn't need to be used outside of mm.c, so let's make it static to keep > all the hyp VA allocation logic in one place. > > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/hyp/include/nvhe/mm.h | 1 - > arch/arm64/kvm/hyp/nvhe/mm.c | 3 ++- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/hyp/include/nvhe/mm.h b/arch/arm64/kvm/hyp/include/nvhe/mm.h > index 3f60d6cc5368..2d08510c6cc1 100644 > --- a/arch/arm64/kvm/hyp/include/nvhe/mm.h > +++ b/arch/arm64/kvm/hyp/include/nvhe/mm.h > @@ -12,7 +12,6 @@ > > extern struct kvm_pgtable pkvm_pgtable; > extern hyp_spinlock_t pkvm_pgd_lock; > -extern u64 __io_map_base; > > int hyp_create_idmap(u32 hyp_va_bits); > int hyp_map_vectors(void); > diff --git a/arch/arm64/kvm/hyp/nvhe/mm.c b/arch/arm64/kvm/hyp/nvhe/mm.c > index 9e0ff5a700dd..526a7d6fa86f 100644 > --- a/arch/arm64/kvm/hyp/nvhe/mm.c > +++ b/arch/arm64/kvm/hyp/nvhe/mm.c > @@ -19,11 +19,12 @@ > > struct kvm_pgtable pkvm_pgtable; > hyp_spinlock_t pkvm_pgd_lock; > -u64 __io_map_base; > > struct memblock_region hyp_memory[HYP_MEMBLOCK_REGIONS]; > unsigned int hyp_memblock_nr; > > +static u64 __io_map_base; > + > static int __pkvm_create_mappings(unsigned long start, unsigned long size, > unsigned long phys, enum kvm_pgtable_prot prot) Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel