From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39EBBC433F5 for ; Wed, 8 Dec 2021 17:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6TII+qStGcHL4R8gIMrTGyzefJYZQtVPgRPf88KL0J4=; b=ICAIsysQvsiOSj EMmWJ7ZLcvY40gTUlMglCgdOdegRjuOkPdYSGP1y9JdAiLgKXbcNWQ/5IWbZlwprEchhndZXwpmZs DWsjxs3K7mb1q+e7cqlQqO+llrdb3PAcB5+XPPRhJvBci1V1RVGYVCaHUnz9kZCidJApyuV7S6Emq E3u7d6EpYEmwxZVZGg/HfGLm38p6+0oiFYMF3qjsZVr6mqmAXFVfJa4BWY9X4/ys+Trd6rze8BFo/ XXIr6LGb5JodujduMCAf73AsEi/TzwiwRSa4/gJGaMax4LfK2cwHvDl2KVhtnCArR3lMrJ8Ykpo1/ 3bdjsCn/ti0YsbFkD6Ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv15s-00DnRH-6U; Wed, 08 Dec 2021 17:51:04 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mv15o-00DnQ3-Id for linux-arm-kernel@lists.infradead.org; Wed, 08 Dec 2021 17:51:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C284DCE228F; Wed, 8 Dec 2021 17:50:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23BB0C00446; Wed, 8 Dec 2021 17:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638985857; bh=xb90MP/qB6HOV2i1jXMu36XCMenmbWiRSkd39nIEmlY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ud+CpWXkWyC0eQlPUzIkm8PiPlvtU5DesoGGVTezeiqznlT7eoggyRWIMxEuzAU+Q WZg2msTa2KghO/JnLvHJgxWeVkg4ao5NE4J8uBcJFuFFc0SySIaiCiKlfWGY0BJ5GI EqxD2xsgkVornOHroFGXZ/eiVoDoSM24hdYnWgB4cBSEJBFSTL2lblJEsMKXsWqTUl PBmHBMLWJe9AjEyrSiebEHAWncWHVFnT1HjDN1th/moeOf3OLITKzjyo9iLgkKUWTd lHo4pxlbXW1li6ogPTjyK/QIyO4rrQo62fC0nx81kh6WHqnWQkOnx/0LFcz2lg6Thm SwG7IKVUEjghA== Date: Wed, 8 Dec 2021 17:50:51 +0000 From: Will Deacon To: Quentin Perret Cc: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 6/6] KVM: arm64: pkvm: Make kvm_host_owns_hyp_mappings() robust to VHE Message-ID: <20211208175050.GF820@willie-the-truck> References: <20211208152300.2478542-1-qperret@google.com> <20211208152300.2478542-7-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211208152300.2478542-7-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211208_095100_833328_2EBABB9A X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 08, 2021 at 03:22:59PM +0000, Quentin Perret wrote: > The kvm_host_owns_hyp_mappings() function should return true if and only > if the host kernel is responsible for creating the hypervisor stage-1 > mappings. That is only possible in standard non-VHE mode, or during boot > in protected nVHE mode. But either way, non of this makes sense in VHE, Typo: non => none > so make sure to catch this case as well, hence making the function > return sensible values in any context (VHE or not). > > Suggested-by: Marc Zyngier > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/mmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 605c104eb030..ea840fa223b5 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -239,6 +239,9 @@ void free_hyp_pgds(void) > > static bool kvm_host_owns_hyp_mappings(void) > { > + if (is_kernel_in_hyp_mode()) > + return false; Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel