From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1BFEC433EF for ; Thu, 9 Dec 2021 10:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H7kvAaRVlzwsd0X+MS+oZuY/t02oQOJvURUZlQ+soq4=; b=MmCuE4ni1bQrYe C03FCQAXujBUFgBPDkR0Syckk0JqTPHSWDdI5Id1j3wY7eMreAtvtDgxnqDua5Dt1BcVTNJp5lHzS RQBwAbyEEBSsNwnnZsnHrXxvk5vdJijRVtDECpQ+3ro4fhKfmhY6LjJxDTyNVbfaJ2JO5laJl3zDt iyf3OKKc47FJvAJP98YzjQuK5LXBSahd8Psm10+xkLJ1IankNOSqraJ+DZNaJhD4UqEDwsIqJxaUe Y/VwSwzi2WeCSSZCVTss/Dai1WKzvlOM8++yZ8oyX6xfwlveLbppcHAjZHivCtt838BzCJ0sYQTwa 7QnxFwfGbI4U911qlgPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvGOJ-00FYFH-2G; Thu, 09 Dec 2021 10:11:07 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvGOF-00FYE8-7k for linux-arm-kernel@lists.infradead.org; Thu, 09 Dec 2021 10:11:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DB721B82418; Thu, 9 Dec 2021 10:11:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 656E9C004DD; Thu, 9 Dec 2021 10:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639044660; bh=RYhR2iP19QRA3Oma18FQhK2Re2fOq8fTvX1MIpeSMg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q0Lej2zGbp/4EwFGqRP+78kf2BC/Sm+ciMQgKeWUbFMnDtjpHrwIYQbZzzAqslzHY YJnSAYBaOAs5nj87BVV0sfc54c3u4kIJ8qV/LDS9x05irsm+RAie8Y2fPftfqXNMzt fdBHFxIzTm8A0gk7sjYOP0O0lTF5nf/yIfM/L8UrL5eEHdpUaKrqFKjA3cmM/gCzMJ TJ44niU8x6MyUA25i2UOy19P1uVMR2rVCOW/cAnvns6VmDQoqJ6HGLKDcjzUj/R38V MeBz0JaUo1U0DmuIKX+T7pK/DSBpgfJ32VZqohyGu56ZqsAa4foZZfm9+KslY71IuR rnOmwwuCvhKDg== Date: Thu, 9 Dec 2021 10:10:54 +0000 From: Will Deacon To: Quentin Perret Cc: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 01/15] KVM: arm64: Check if running in VHE from kvm_host_owns_hyp_mappings() Message-ID: <20211209101053.GA1833@willie-the-truck> References: <20211201170411.1561936-1-qperret@google.com> <20211201170411.1561936-2-qperret@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211201170411.1561936-2-qperret@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_021103_455871_A44D5DAC X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 01, 2021 at 05:03:55PM +0000, Quentin Perret wrote: > The kvm_host_owns_hyp_mappings() function should return true if and only > if the host kernel is responsible for creating the hypervisor stage-1 > mappings. That is only possible in standard non-VHE mode, or during boot > in protected nVHE mode. But either way, non of this makes sense in VHE, > so make sure to catch this case as well, hence making the function > return sensible values in any context (VHE or not). > > Suggested-by: Marc Zyngier > Signed-off-by: Quentin Perret > --- > arch/arm64/kvm/mmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 326cdfec74a1..f8f1096a297f 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -239,6 +239,9 @@ void free_hyp_pgds(void) > > static bool kvm_host_owns_hyp_mappings(void) > { > + if (is_kernel_in_hyp_mode()) > + return false; This looks identical to: https://lore.kernel.org/r/20211208152300.2478542-7-qperret@google.com Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel