From: Peter Collingbourne <pcc@google.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
YiFei Zhu <yifeifz2@illinois.edu>,
Mark Rutland <mark.rutland@arm.com>,
Frederic Weisbecker <frederic@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Andrey Konovalov <andreyknvl@gmail.com>,
Peter Collingbourne <pcc@google.com>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
Chris Hyser <chris.hyser@oracle.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Chris Wilson <chris@chris-wilson.co.uk>,
Arnd Bergmann <arnd@arndb.de>,
Dmitry Vyukov <dvyukov@google.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alexey Gladkov <legion@kernel.org>,
Ran Xiaokai <ran.xiaokai@zte.com.cn>,
David Hildenbrand <david@redhat.com>,
Xiaofeng Cao <caoxiaofeng@yulong.com>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Thomas Cedeno <thomascedeno@google.com>,
Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Evgenii Stepanov <eugenis@google.com>
Subject: [PATCH v4 7/7] selftests: test uaccess logging
Date: Thu, 9 Dec 2021 14:15:44 -0800 [thread overview]
Message-ID: <20211209221545.2333249-8-pcc@google.com> (raw)
In-Reply-To: <20211209221545.2333249-1-pcc@google.com>
Add a kselftest for the uaccess logging feature.
Link: https://linux-review.googlesource.com/id/I39e1707fb8aef53747c42bd55b46ecaa67205199
Signed-off-by: Peter Collingbourne <pcc@google.com>
---
tools/testing/selftests/Makefile | 1 +
.../testing/selftests/uaccess_buffer/Makefile | 4 +
.../uaccess_buffer/uaccess_buffer_test.c | 126 ++++++++++++++++++
3 files changed, 131 insertions(+)
create mode 100644 tools/testing/selftests/uaccess_buffer/Makefile
create mode 100644 tools/testing/selftests/uaccess_buffer/uaccess_buffer_test.c
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index c852eb40c4f7..291b62430557 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -71,6 +71,7 @@ TARGETS += timers
endif
TARGETS += tmpfs
TARGETS += tpm2
+TARGETS += uaccess_buffer
TARGETS += user
TARGETS += vDSO
TARGETS += vm
diff --git a/tools/testing/selftests/uaccess_buffer/Makefile b/tools/testing/selftests/uaccess_buffer/Makefile
new file mode 100644
index 000000000000..e6e5fb43ce29
--- /dev/null
+++ b/tools/testing/selftests/uaccess_buffer/Makefile
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
+TEST_GEN_PROGS := uaccess_buffer_test
+
+include ../lib.mk
diff --git a/tools/testing/selftests/uaccess_buffer/uaccess_buffer_test.c b/tools/testing/selftests/uaccess_buffer/uaccess_buffer_test.c
new file mode 100644
index 000000000000..051062e4fbf9
--- /dev/null
+++ b/tools/testing/selftests/uaccess_buffer/uaccess_buffer_test.c
@@ -0,0 +1,126 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include "../kselftest_harness.h"
+
+#include <linux/uaccess-buffer.h>
+#include <sys/prctl.h>
+#include <sys/utsname.h>
+
+FIXTURE(uaccess_buffer)
+{
+ uint64_t addr;
+};
+
+FIXTURE_SETUP(uaccess_buffer)
+{
+ ASSERT_EQ(0, prctl(PR_SET_UACCESS_DESCRIPTOR_ADDR_ADDR, &self->addr, 0,
+ 0, 0));
+}
+
+FIXTURE_TEARDOWN(uaccess_buffer)
+{
+ ASSERT_EQ(0, prctl(PR_SET_UACCESS_DESCRIPTOR_ADDR_ADDR, 0, 0, 0, 0));
+}
+
+TEST_F(uaccess_buffer, uname)
+{
+ struct uaccess_descriptor desc;
+ struct uaccess_buffer_entry entries[64];
+ struct utsname un;
+
+ desc.addr = (uint64_t)(unsigned long)entries;
+ desc.size = 64;
+ self->addr = (uint64_t)(unsigned long)&desc;
+ ASSERT_EQ(0, uname(&un));
+ ASSERT_EQ(0, self->addr);
+
+ if (desc.size == 63) {
+ ASSERT_EQ((uint64_t)(unsigned long)(entries + 1), desc.addr);
+
+ ASSERT_EQ((uint64_t)(unsigned long)&un, entries[0].addr);
+ ASSERT_EQ(sizeof(struct utsname), entries[0].size);
+ ASSERT_EQ(UACCESS_BUFFER_FLAG_WRITE, entries[0].flags);
+ } else {
+ /* See override_architecture in kernel/sys.c */
+ ASSERT_EQ(62, desc.size);
+ ASSERT_EQ((uint64_t)(unsigned long)(entries + 2), desc.addr);
+
+ ASSERT_EQ((uint64_t)(unsigned long)&un, entries[0].addr);
+ ASSERT_EQ(sizeof(struct utsname), entries[0].size);
+ ASSERT_EQ(UACCESS_BUFFER_FLAG_WRITE, entries[0].flags);
+
+ ASSERT_EQ((uint64_t)(unsigned long)&un.machine,
+ entries[1].addr);
+ ASSERT_EQ(UACCESS_BUFFER_FLAG_WRITE, entries[1].flags);
+ }
+}
+
+static bool handled;
+
+static void usr1_handler(int signo)
+{
+ handled = true;
+}
+
+TEST_F(uaccess_buffer, blocked_signals)
+{
+ struct uaccess_descriptor desc;
+ struct shared_buf {
+ bool ready;
+ bool killed;
+ } volatile *shared = mmap(NULL, getpagesize(), PROT_READ | PROT_WRITE,
+ MAP_ANON | MAP_SHARED, -1, 0);
+ struct sigaction act = {}, oldact;
+ int pid;
+
+ handled = false;
+ act.sa_handler = usr1_handler;
+ sigaction(SIGUSR1, &act, &oldact);
+
+ pid = fork();
+ if (pid == 0) {
+ /*
+ * Busy loop to synchronize instead of issuing syscalls because
+ * we need to test the behavior in the case where no syscall is
+ * issued by the parent process.
+ */
+ while (!shared->ready)
+ ;
+ kill(getppid(), SIGUSR1);
+ shared->killed = true;
+ _exit(0);
+ } else {
+ int i;
+
+ desc.addr = 0;
+ desc.size = 0;
+ self->addr = (uint64_t)(unsigned long)&desc;
+
+ shared->ready = true;
+ while (!shared->killed)
+ ;
+
+ /*
+ * The kernel should have IPI'd us by now, but let's wait a bit
+ * longer just in case.
+ */
+ for (i = 0; i != 1000000; ++i)
+ ;
+
+ ASSERT_FALSE(handled);
+
+ /*
+ * Returning from the waitpid syscall should trigger the signal
+ * handler. The signal itself may also interrupt waitpid, so
+ * make sure to handle EINTR.
+ */
+ while (waitpid(pid, NULL, 0) == -1)
+ ASSERT_EQ(EINTR, errno);
+ ASSERT_TRUE(handled);
+ }
+
+ munmap((void *)shared, getpagesize());
+ sigaction(SIGUSR1, &oldact, NULL);
+}
+
+TEST_HARNESS_MAIN
--
2.34.1.173.g76aa8bc2d0-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-09 22:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 22:15 [PATCH v4 0/7] kernel: introduce uaccess logging Peter Collingbourne
2021-12-09 22:15 ` [PATCH v4 1/7] include: split out uaccess instrumentation into a separate header Peter Collingbourne
2021-12-10 12:45 ` Marco Elver
2021-12-09 22:15 ` [PATCH v4 2/7] uaccess-buffer: add core code Peter Collingbourne
2021-12-10 3:52 ` Dmitry Vyukov
2021-12-10 12:39 ` Marco Elver
2021-12-09 22:15 ` [PATCH v4 3/7] fs: use copy_from_user_nolog() to copy mount() data Peter Collingbourne
2021-12-09 22:15 ` [PATCH v4 4/7] uaccess-buffer: add CONFIG_GENERIC_ENTRY support Peter Collingbourne
2021-12-11 11:50 ` Thomas Gleixner
2021-12-16 1:25 ` Peter Collingbourne
2021-12-16 13:05 ` Thomas Gleixner
2021-12-17 0:09 ` Peter Collingbourne
2021-12-17 18:42 ` Thomas Gleixner
2022-01-10 21:43 ` Peter Collingbourne
2021-12-09 22:15 ` [PATCH v4 5/7] arm64: add support for uaccess logging Peter Collingbourne
2021-12-09 22:15 ` [PATCH v4 6/7] Documentation: document " Peter Collingbourne
2021-12-09 22:15 ` Peter Collingbourne [this message]
2021-12-10 13:30 ` [PATCH v4 7/7] selftests: test " Marco Elver
2021-12-11 17:23 ` [PATCH v4 0/7] kernel: introduce " David Laight
2021-12-13 19:48 ` Peter Collingbourne
2021-12-13 23:07 ` David Laight
2021-12-14 3:47 ` Peter Collingbourne
2021-12-15 4:27 ` Peter Collingbourne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211209221545.2333249-8-pcc@google.com \
--to=pcc@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=arnd@arndb.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=caoxiaofeng@yulong.com \
--cc=catalin.marinas@arm.com \
--cc=chris.hyser@oracle.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.brauner@ubuntu.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=frederic@kernel.org \
--cc=glider@google.com \
--cc=gorcunov@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=krisman@collabora.com \
--cc=legion@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=thomascedeno@google.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=yifeifz2@illinois.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).