From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 739C6C433F5 for ; Mon, 13 Dec 2021 13:19:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I7Kgz3jz9voa+ryqfch/XAM1bYqBQHsFWVyLEnuIEzM=; b=XqNdGpnQ4RWWop aR14WDzWlUf9oJjeBiUAJ5W+W6uq7tyjX9kJfjChs5vqjJEdpCBxBQcGpv+beN8vTqjXwlPhT8rh2 ssogOr/HMHmCyYyu8YW4oRfZ7Rt3CZdNeyjlPk0AG/OvUG+WFI67nWxQQWOQUN4CIeZSCDtMWN4B6 iT9nNQaaWypldXW0SO1cF3VcIS7URHQ9J13aOnAL8muQERXcJxrVgJ1sspRj9hpgXCZ9e2Q0HP25N 2VLbWVONetRiOJbdJTnw6t+M4F+BEVPMMzsI4CaABS8PzPXF3Yc/TISi3ekLxWVgetBHCbyVbFI5F NuOSmjf+lFvXyWx1Eg0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlDA-009e7P-Nq; Mon, 13 Dec 2021 13:17:48 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlD4-009e5O-Rx for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 13:17:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639401461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1z/oXnKbigNR72V6rUxvYybH8ETpkht3CxfyFrpc7CE=; b=JsYtRDqrmZIT63T2uY7LMCI/XjPO9OjwtZuj+jvjxOHGYrz9vPvRDkGbI7imuziTB6B9A2 I1+KvPwzlaopAui7NusNLeg8vAbBfgXjIhvN7qNR3+n5VDxVyx8/U3A+WtdZ+tRs1HVbIf gzXXl3U4isxr58mKIRPInAgt7s2yEpo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-507-0KdNIwMXNGqYAfCoLdZT8w-1; Mon, 13 Dec 2021 08:17:36 -0500 X-MC-Unique: 0KdNIwMXNGqYAfCoLdZT8w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 810D38015CD; Mon, 13 Dec 2021 13:17:33 +0000 (UTC) Received: from localhost (ovpn-12-202.pek2.redhat.com [10.72.12.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10B5D18032; Mon, 13 Dec 2021 13:17:15 +0000 (UTC) Date: Mon, 13 Dec 2021 21:17:13 +0800 From: Baoquan He To: Zhen Lei Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou Subject: Re: [PATCH v17 01/10] x86: kdump: replace the hard-coded alignment with macro CRASH_ALIGN Message-ID: <20211213131713.GA23510@MiWiFi-R3L-srv> References: <20211210065533.2023-1-thunder.leizhen@huawei.com> <20211210065533.2023-2-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211210065533.2023-2-thunder.leizhen@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_051742_993039_1D526DF9 X-CRM114-Status: GOOD ( 20.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/10/21 at 02:55pm, Zhen Lei wrote: > From: Chen Zhou > > Move CRASH_ALIGN to header asm/kexec.h for later use. > > Suggested-by: Dave Young > Suggested-by: Baoquan He I remember Dave and I discussed and suggested this when reviewing. You can remove my Suggested-by. For this one, I would like to add ack: Acked-by: Baoquan He > Signed-off-by: Chen Zhou > Signed-off-by: Zhen Lei > Tested-by: John Donnelly > Tested-by: Dave Kleikamp > --- > arch/x86/include/asm/kexec.h | 3 +++ > arch/x86/kernel/setup.c | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/kexec.h b/arch/x86/include/asm/kexec.h > index 11b7c06e2828c30..3a22e65262aa70b 100644 > --- a/arch/x86/include/asm/kexec.h > +++ b/arch/x86/include/asm/kexec.h > @@ -18,6 +18,9 @@ > > # define KEXEC_CONTROL_CODE_MAX_SIZE 2048 > > +/* 16M alignment for crash kernel regions */ > +#define CRASH_ALIGN SZ_16M > + > #ifndef __ASSEMBLY__ > > #include > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index 6a190c7f4d71b05..5cc60996eac56d6 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -392,9 +392,6 @@ static void __init memblock_x86_reserve_range_setup_data(void) > > #ifdef CONFIG_KEXEC_CORE > > -/* 16M alignment for crash kernel regions */ > -#define CRASH_ALIGN SZ_16M > - > /* > * Keep the crash kernel below this limit. > * > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel