From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFB3DC433EF for ; Mon, 13 Dec 2021 14:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H7crZJ1pjPekVjY762/4zau+I+axEzPghYAGlrr2CLo=; b=Rsl301FljDvdJE 0ykSMtTJSKeo8fWyPyoF9Ex0VM9iOgTn2aPEkPYLouEAXzXThSRtQIhh42bQjIQcT/Zsg6ro1jHuU 6Vi+aY56A6KWJmuBfimhpTpfszIJpw9sZhUDCjXILUU/LPVBrGRqKCDKOuRaOMDUNQoab4F5sukcq XzMTcyphyBVNxMbP5M9WizI4wNc/lrvWzKui09YdayqM64BmMBcz1/QPhcPQQZo1reJWbs+o7+Vua CNHiArTr2b5kqP9mjBP/X68GWEHfV4ay+bT+OsUKwc1kIsGuTuL6KPAKr2O2BDquER1esIUWX8jss 6ezhaSoO613LbEF20AMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwm0L-009vPB-EQ; Mon, 13 Dec 2021 14:08:37 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlnW-009pr6-7Y for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 13:55:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1639403721; x=1670939721; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kICjwcYgnlN/vC0Y/CALYqqZD73fHuSRwpC4LyuLypo=; b=wlYO59R0xz9+Ui4JgYYO1oVs/8Ggc/9V1mU06VHsVwhBZlbJhkUUO7dZ zwHI988K1h0cMTPAB6FHuAGvwn7w9IfK0FDZHDmikxTof0wcNHuEEtbl0 hjJjwQqLpvkpAtT4SK7YksjKnQz09jJ4JiDXfyhjKIPK8noj3f41QmV2+ OKlHUUFUmEKPDypqXwsTO0Sfk5CgteR2s9Bcag5nRuJgjbSOcEoTQdntz I0BH2blO27MLNRnuc/YF51E5VYsQRSRpEOPRQPiKfUmeTl+r8ofTQT4b5 ctX/N8apz/iVuCsDaP/ysDz78tVc9DbNWfffrmvpMp7qw8UPAH0HCfwao w==; IronPort-SDR: RdVCTj6jOGRh3fZrZp35jgld4KmUpNYcVVi7Q8OL0eQcRT3gUTziejp6HAz4EGHqGwCB6fv4kK o3+bHAC7O159HuB9wbvrA2KyQso5m8Y7QKykSmpXZDC0HxskR+l2kfA0/j2kVkuyisaD+sQ3HX r/61utN/FzNY6xOLvkctgDX4JkhB4WaBQIejy/OCYG8+2LENwjmbvc9MVKQ/uzYAMxgNfoeSrq 0u1B21jEAna73wxi//cZNt8wX+/h8CHSTXwYOXB1wgbYHQCiQdqIdlh2GyxFDwru3sHkqbLCaX XCSdTwTgHqvgRdIL6TX97l4p X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="155270152" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2021 06:55:20 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 13 Dec 2021 06:55:20 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Mon, 13 Dec 2021 06:54:52 -0700 From: Eugen Hristev To: , , , , Subject: [PATCH v3 18/23] media: atmel: atmel-isc-base: add wb debug messages Date: Mon, 13 Dec 2021 15:49:35 +0200 Message-ID: <20211213134940.324266-19-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211213134940.324266-1-eugen.hristev@microchip.com> References: <20211213134940.324266-1-eugen.hristev@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_055522_355364_E25E0B89 X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Eugen Hristev , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add debug messages that make it easier to debug white balance algorithm. Signed-off-by: Eugen Hristev --- drivers/media/platform/atmel/atmel-isc-base.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index 53cac1aac0fd..f1f1019f9d82 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -1329,10 +1329,15 @@ static void isc_hist_count(struct isc_device *isc, u32 *min, u32 *max) if (!*min) *min = 1; + + v4l2_dbg(1, debug, &isc->v4l2_dev, + "isc wb: hist_id %u, hist_count %u", + ctrls->hist_id, *hist_count); } static void isc_wb_update(struct isc_ctrls *ctrls) { + struct isc_device *isc = container_of(ctrls, struct isc_device, ctrls); u32 *hist_count = &ctrls->hist_count[0]; u32 c, offset[4]; u64 avg = 0; @@ -1349,6 +1354,9 @@ static void isc_wb_update(struct isc_ctrls *ctrls) (u64)hist_count[ISC_HIS_CFG_MODE_GB]; avg >>= 1; + v4l2_dbg(1, debug, &isc->v4l2_dev, + "isc wb: green components average %llu\n", avg); + /* Green histogram is null, nothing to do */ if (!avg) return; @@ -1401,9 +1409,15 @@ static void isc_wb_update(struct isc_ctrls *ctrls) else gw_gain[c] = 1 << 9; + v4l2_dbg(1, debug, &isc->v4l2_dev, + "isc wb: component %d, s_gain %u, gw_gain %u\n", + c, s_gain[c], gw_gain[c]); /* multiply both gains and adjust for decimals */ ctrls->gain[c] = s_gain[c] * gw_gain[c]; ctrls->gain[c] >>= 9; + v4l2_dbg(1, debug, &isc->v4l2_dev, + "isc wb: component %d, final gain %u\n", + c, ctrls->gain[c]); } } @@ -1423,6 +1437,10 @@ static void isc_awb_work(struct work_struct *w) return; isc_hist_count(isc, &min, &max); + + v4l2_dbg(1, debug, &isc->v4l2_dev, + "isc wb mode %d: hist min %u , max %u\n", hist_id, min, max); + ctrls->hist_minmax[hist_id][HIST_MIN_INDEX] = min; ctrls->hist_minmax[hist_id][HIST_MAX_INDEX] = max; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel