From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C91B6C433F5 for ; Mon, 13 Dec 2021 14:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FJhAqGfQUvbcvRqlRe8r8q1ncsQUVwl8ES4/p+wTaJE=; b=tKBHy3XN8kqzUo W3uZcufNF6D3RQz6eWZPwGfzyzcfapI43nWJqe/doIa+nLptQkIIO3t4i1huujMXi5B3hi8g//m7W Ysdq5AeT3+eWah0FybaB5m8d9rsW402sx0QGXB0xAXheGQkYD7IE1vT48fUh9KXNRalDitHRs+H+A h8/XmsbtJqvIzyswbrWhcuA3krAZ+n0XwmPvifU8iAoCjH518jbqGuCG77AvowaSIJY9J+AbGjHgn 1XEg6KTpVLiE0GbJy7ceRe3wtDXP6EtqICHmi3y93Oex6Soh0aWFgx2K8SbhMzp+4A1o1yWuonH1a ZYglJ10DxPDP6lfch1gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwm1C-009vke-KH; Mon, 13 Dec 2021 14:09:32 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlnr-009pzk-5T for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 13:55:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1639403743; x=1670939743; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RKT4TsQbf9WhAC/BzpiLxsl35EXH1/8qpv9zRIsAbvo=; b=JbyPD8wrI3c3KluDJ5dPvD3pMzBjebjnavPTrx4+EnyzLdcDeKzNbJUi CqZeMDmI5tBLHKri5MAntlouIa2zRyczJ5eWa5oP4qUVqlbtGHdF6LEPB 3SQH9c8K/5gFSXZJzuneb817Iqn+gvLeAOOPcAh3X18Q9ifKDGReT79bX t14d6EpRnTDVTtLkpXTi8NFFCLbgz9SuLJapgMekZEsl+FG2fU4KHuaMF Ir5rpgnEygA8UHSFGz693yhmm2XqzBd3vrvmrzZ4UjX/g1tDtVJhXtLwA 9SW5pjs4h62p6EJ/j8GJecJCwS9W4stAitJLBrW3A0ZQH2/SQgeybO8Uw w==; IronPort-SDR: Sq4wjjOofCWVGyZv5eAq0hyYwQ/zg8wi+Ss0cDbu04rvODVG5OiCUpKDM3476jcg0AIPbExT2A 80EZBygae7WIOW3RZ/VGXqprbe2Jp4I6xxH+we1wqaGmPm7tZVFvgXC01FgmufxSi29Dh2u+Ba RaRn1FxcH/drgRbAOzGpBmcTNG4rr3/YUXik5uSpZLhnOTQP2QEJUredyAnEFIl5Iqs5GZOqWa h4w/gfxw8jeYs83IOg/nGzLuLzFnqKPa4SrOIiy3RQO7smLJon0gQXiwaspzvxra51O7bXmLQc NIDKXVR8jDw/078kzsvmzVGS X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="147032929" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2021 06:55:42 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 13 Dec 2021 06:55:41 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Mon, 13 Dec 2021 06:55:21 -0700 From: Eugen Hristev To: , , , , Subject: [PATCH v3 19/23] media: atmel: atmel-isc-base: clamp wb gain coefficients Date: Mon, 13 Dec 2021 15:49:36 +0200 Message-ID: <20211213134940.324266-20-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211213134940.324266-1-eugen.hristev@microchip.com> References: <20211213134940.324266-1-eugen.hristev@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_055543_247542_172800EC X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Eugen Hristev , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org White balance computed gains can overflow above the 13 bits hardware coefficient that can be used, in some specific scenarios like a subexposure from the sensor when the image is mostly black. In this case the computed gain has to be clamped to the maximum value allowed by the hardware. Signed-off-by: Eugen Hristev --- drivers/media/platform/atmel/atmel-isc-base.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index f1f1019f9d82..31c8e3029eee 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -1415,6 +1415,10 @@ static void isc_wb_update(struct isc_ctrls *ctrls) /* multiply both gains and adjust for decimals */ ctrls->gain[c] = s_gain[c] * gw_gain[c]; ctrls->gain[c] >>= 9; + + /* make sure we are not out of range */ + ctrls->gain[c] = clamp_val(ctrls->gain[c], 0, GENMASK(12, 0)); + v4l2_dbg(1, debug, &isc->v4l2_dev, "isc wb: component %d, final gain %u\n", c, ctrls->gain[c]); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel