From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7616FC433F5 for ; Mon, 13 Dec 2021 13:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ommDff645LwyLO2+FmEeKVr8kooFjIXHHUoUVbcu5C8=; b=H6WCVox9HPFU/T a5MRInJz8D/qGyi/BjB5PSK7IRxDOmRdfaF0o5q1xklsGNLVSPffbLF62w4Bo+r1EG8heScHq/MX3 BU58e+QWom+tsSU0zW1O2LkrN/SMxo6uWyMm3qSckiYXstMQ48TLKZKLOVZfqvZAEDwchDE8Avbdl iCZNQ7ij5+xDrMWRPNDjYWioDct2Ku3fiEEG7zEUdyG0yxpkL/M6sNqDS9ECRYQ56bspS9tYxfkDc fkAhFAGw6dnkvf83/h1KNjN3dXKFqkXFtNdetqZTnTpsKav1Ygdo94MZoAO6os+eS0hW8Ag7SbSRT 3ZTVeRgPZoIHaJQ+xXEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwlnW-009poQ-Ha; Mon, 13 Dec 2021 13:55:24 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwljm-009o3B-Vv for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 13:51:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1639403490; x=1670939490; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wUeEYEPhDkhIE88VVyIbkTbuZnTPC/eMEm62GBFIfCg=; b=io2+aFfMgow3iFBGNTl7k+I2eNy0SuGihNLtk7eEGXszyAKc0sHnAtTl NGeXTe6nCXGOmjY/1iMkrsRbvSygUTFgV95NbEia130vS+NFD6aTQvHAy SUK9dEiDoU5MzKoYhnQWulfP9FIQ4/QhAFpKEoS4OI8Fj4ePliJDrotMj ZwuI6AU1vAnANt+aPTHCGhtpV8mqUpKBKB/S559jPfPAzxjgKEIA6oyEd PZuki/Z+G7e3ZhPWD2mGBTvT1hgvqHCCsdv18LQ7XKirfq1TDceS3JHix Na4saihqG3EOWlKqrIMfRaMnj1LRplUoYtvAGH9XKZtPTQrEtBqx8q1+x Q==; IronPort-SDR: iOWr9/qqMBII2EZvciMl6OLfP8OcjV8d9+JYUbxQ+HXntaGSD9iu17KBbTTA48ZdrKC93SF+Nx SrQ25ZTmVmoIwW4bJYC2HItmuHYpTIbm5popNb1TwPb4CJCj6KPA6uNqUNZdr7x4jBZDkCN6pz VGF9KW1nhJwPYEFD1jU+dyIr038HJLphaz325sOHniykyz10IQMt9S+iED50yd//p8UWLroyuW a/3jsyLQtmm8gBB9LGLgHCiIzTqkZhgHob6BExIJV8bXbwE3QzQ/HlU2mr7UFiyM818yoq4fcI +V9wFXIXh396DQRxNtLS1zsC X-IronPort-AV: E=Sophos;i="5.88,202,1635231600"; d="scan'208";a="79361579" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2021 06:51:30 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 13 Dec 2021 06:51:29 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Mon, 13 Dec 2021 06:51:23 -0700 From: Eugen Hristev To: , , , , Subject: [PATCH v3 06/23] media: atmel: atmel-sama7g5-isc: fix ispck leftover Date: Mon, 13 Dec 2021 15:49:23 +0200 Message-ID: <20211213134940.324266-7-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211213134940.324266-1-eugen.hristev@microchip.com> References: <20211213134940.324266-1-eugen.hristev@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_055131_153891_64D75380 X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Eugen Hristev , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The ispck is not used for sama7g5 variant of the ISC. Calls to ispck have to be removed also from module insert/removal. Fixes: d7f26849ed7c ("media: atmel: fix the ispck initialization") Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi --- drivers/media/platform/atmel/atmel-sama7g5-isc.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-sama7g5-isc.c b/drivers/media/platform/atmel/atmel-sama7g5-isc.c index 5d1c76f680f3..2b1082295c13 100644 --- a/drivers/media/platform/atmel/atmel-sama7g5-isc.c +++ b/drivers/media/platform/atmel/atmel-sama7g5-isc.c @@ -556,7 +556,6 @@ static int microchip_xisc_remove(struct platform_device *pdev) v4l2_device_unregister(&isc->v4l2_dev); - clk_disable_unprepare(isc->ispck); clk_disable_unprepare(isc->hclock); isc_clk_cleanup(isc); @@ -568,7 +567,6 @@ static int __maybe_unused xisc_runtime_suspend(struct device *dev) { struct isc_device *isc = dev_get_drvdata(dev); - clk_disable_unprepare(isc->ispck); clk_disable_unprepare(isc->hclock); return 0; @@ -583,10 +581,6 @@ static int __maybe_unused xisc_runtime_resume(struct device *dev) if (ret) return ret; - ret = clk_prepare_enable(isc->ispck); - if (ret) - clk_disable_unprepare(isc->hclock); - return ret; } -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel