From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7900C433F5 for ; Mon, 13 Dec 2021 16:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eRxw7kDfUC/TiNMV3JhE4d2B3ObyNfKjXb7Z5AJvvZ8=; b=Cl9NGFL+9sMA4Q gmPu/Y6wo0evPMJe7pbFvaxMwkL1wppeczEeYaxw8OnAbJ4U+DDOjoLbERDK0BPYSuwbcjc5WbV7Q h4/SSMUVuFhlCZJWgeK/IXH3xLUX6/LGK1kr0xKoK53cz1HFN+DF3ZM9pLEOskvoKeYY/aEopjCXH IdKM5IB1S0ZtorUvPYqLyhd0cwXgo75by4iBIjXZR+4KXGnoxYFGR2Mf2UpkOxObhNHoQ+6H5TFum 2p7SoLBQmZ6pB4SbXeJZFdHlnf9aaboPnGnLhWElBgdQEGBUQGyvgAX3oL1Hj4d6PyDsmtvwaVcsF OqBg50WDn/YGHr1FY4iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwnjz-00ATKM-DD; Mon, 13 Dec 2021 15:59:51 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwnjv-00ATJC-3X for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 15:59:48 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BDFxUE3123019; Mon, 13 Dec 2021 09:59:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1639411170; bh=XwlN2vUIJ/kuSsvEp4gbGeljEYGLTZNc/OAIavCBqRQ=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=N2Uxz4217r0eQv/YhsVhzs8JOkZm5KlA5q9pCavcJ8GemahBfIowZgiplyAK1nNrX 86Ai8MCgiwAl/ifCXiQPTf9LBXR4N50qrg6Aoy37hXRn6KYRngB+UjB8uyBj813RNV YgYJDjltmbqUIwnU1DTHRHEavIUN62VJE2af9Dl4= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BDFxUd7091219 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 13 Dec 2021 09:59:30 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 13 Dec 2021 09:59:30 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 13 Dec 2021 09:59:30 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BDFxU81052740; Mon, 13 Dec 2021 09:59:30 -0600 Date: Mon, 13 Dec 2021 09:59:30 -0600 From: Nishanth Menon To: Miaoqian Lin CC: Santosh Shilimkar , , Subject: Re: [PATCH] soc: ti: Fix NULL vs IS_ERR() checking in dma_init Message-ID: <20211213155930.mcxlc5m3niqh77xi@annotate> References: <20211212071301.3011-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211212071301.3011-1-linmq006@gmail.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_075947_216009_C15927F9 X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07:13-20211212, Miaoqian Lin wrote: > Since devm_ioremap_resource() function return error pointers. > The pktdma_get_regs() function does not return NULL, It return error > pointers too. Using IS_ERR() to check the return value to fix this. Thanks.. but.. > > Signed-off-by: Miaoqian Lin > --- > drivers/soc/ti/knav_dma.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c > index 591d14ebcb11..9f82cf906949 100644 > --- a/drivers/soc/ti/knav_dma.c > +++ b/drivers/soc/ti/knav_dma.c > @@ -646,31 +646,31 @@ static int dma_init(struct device_node *cloud, struct device_node *dma_node) > } [...] > > dma->reg_tx_chan = pktdma_get_regs(dma, node, 1, &size); > - if (!dma->reg_tx_chan) > - return -ENODEV; > + if (IS_ERR(dma->reg_tx_cha)) > + return PTR_ERR(dma->reg_tx_cha); Did you mean reg_tx_chan instead of reg_tx_cha ? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel