From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A090FC433F5 for ; Mon, 13 Dec 2021 16:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jDAaAaAB5DAfM5ShKAmead9AZ3895slqkfMBz3vI2sM=; b=dKVWNlO3U0YtCkYTeJ7e4XuFSG POiRdQk9ydnB9+JUPWZBoY0GGS3PL9MR+3XPc+oGN+JwT440NThnSl5C5dERahtn8ItAL8xKlQoAS nvZQ/Dz4FYaXous5ptCiGO/umZMr3xHQLHZEnf1ZMUQT49SQ72TUNGIR+gFAzFIqV7BcU+eKf3Qm/ GK/HDSi8bAD5C67VnFiydtXoFzPGtQFZExHqBYZKek/cU60kHUpEH0PrQj/U/7jpbW+nMGQXvHUN/ qLn71jzq4NSmpQn3muE9KLeAFeWR/4e2MHjiMxHdvZpKbmfanYZuYTDCreI2Glt5BUMhlgkOxENmI DL08kaTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwoWS-00Ai3K-E0; Mon, 13 Dec 2021 16:49:56 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwoWN-00Ai1w-4n; Mon, 13 Dec 2021 16:49:52 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6FE5D5C01AF; Mon, 13 Dec 2021 11:49:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 13 Dec 2021 11:49:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=YR8VeegFDPxoDfL0lK0oeJBRnP+ ySZZJY/nuI2FLcso=; b=df5FiUN5KHmXuqEqH4suyrn6OeFKnwmw6LsX9YedqiN I6iV5w8q1ohKyjOxZwV3EsaTo0hRijTeXemaTXNQNy/stASYClfQF9uMPvyWv9Yj pU1a639kCHjWpYEI7u2V6+9Wr6EHVugWmYLQXj4OxyJXi67keb8fdqR3bvoGF0JE y5II3VlcA0GISkvyC8Thlz907LqmTsZLJ88rs1kSaqNqrfjPI+ZdIrV4N9R86bkX EZs9/p2UI0SaB0nNk1mVv8+dVbQg/sS7YH2HPguur94IenaigSU1Qahfrv0RmH7q OqqAmPjEYHsVk3ZE8HBGlHHVT10DBiQvq+0Ku48Brhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=YR8Vee gFDPxoDfL0lK0oeJBRnP+ySZZJY/nuI2FLcso=; b=YSThZgeMLZb7RMm/evfMNp eJ7jUbj22IDRi3DpHSZGMi5/g/jbB/J1vEuXXpmL3QB+QvrPAFr2uSyred59+v+x DSaP3THnhbl8mXdl4Hx9fyIUhBTieoR8SCdGIcE/4BWryjcP7s/RnDLriOjJMUok ldaJWKXZIF3wQKfc0dZMMlzTc3NyDkTgON8JQ+6zz+gBUs0v69Hb/Mj+7zCT8vls 1LkN+FqH/791i9rXZpvx52sHw3iULpt94H/EX4wDlgB5u7np4HLNX1c5MvBIpVwn ANWegwUoLWYTRqBTpkQh08xFxAG9+b55PMNPeG2No/5OYFkjomi7oc3vl1l3GNrw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrkeekgdelgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeduvdduhfekkeehgffftefflefgffdtheffudffgeevteffheeuiedvvdejvdfg veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Dec 2021 11:49:49 -0500 (EST) Date: Mon, 13 Dec 2021 17:49:47 +0100 From: Maxime Ripard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Cyril Brulebois , Dave Stevenson Subject: Re: [PATCH v2] ARM: dts: bcm2711-rpi-cm4-io: Add rtc on a pinctrl-muxed i2c bus Message-ID: <20211213164947.dzuarzi4gqo6gxzo@houat> References: <20211209181813.1312509-1-u.kleine-koenig@pengutronix.de> <22b563b0-8d9e-52a1-ebdc-e1f75a855d86@kleine-koenig.org> MIME-Version: 1.0 In-Reply-To: <22b563b0-8d9e-52a1-ebdc-e1f75a855d86@kleine-koenig.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_084951_295223_4A565A94 X-CRM114-Status: GOOD ( 26.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5498765801602681415==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5498765801602681415== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gzu5ikz5w3uxzxs7" Content-Disposition: inline --gzu5ikz5w3uxzxs7 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 09, 2021 at 10:21:39PM +0100, Uwe Kleine-K=F6nig wrote: > Hello, >=20 > I used the wrong git wrapper so this patch appeared with the wrong sender > address. If need be I can resend from the address used in the S-o-b. Your SoB seems to match the From header, so unless you'd like to contribute with your pengutronix it should be fine? > On 12/9/21 19:18, Uwe Kleine-K=F6nig wrote: > > From: Uwe Kleine-K=F6nig > >=20 > > The cm4-io board comes with an PCF85063. Add it to the device tree to m= ake > > it usable. The i2c0 bus can use two different pinmux settings to use > > different pins. To keep the bus appearing on the usual pin pair (gpio0 + > > gpio1) use a pinctrl-muxed setting as the upstream dts does. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > --- > > arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts | 35 ++++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > >=20 > > diff --git a/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts b/arch/arm/boot/d= ts/bcm2711-rpi-cm4-io.dts > > index 19600b629be5..5ddad146b541 100644 > > --- a/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts > > +++ b/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts > > @@ -18,6 +18,41 @@ led-pwr { > > linux,default-trigger =3D "default-on"; > > }; > > }; > > + > > + i2c0mux { > > + compatible =3D "i2c-mux-pinctrl"; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + i2c-parent =3D <&i2c0>; > > + > > + pinctrl-names =3D "i2c0", "i2c0-vc"; > > + pinctrl-0 =3D <&i2c0_gpio0>; > > + pinctrl-1 =3D <&i2c0_gpio44>; > > + > > + i2c@0 { > > + reg =3D <0>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + }; > > + > > + i2c@1 { > > + reg =3D <1>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + rtc@51 { > > + /* Attention: An alarm resets the machine */ > > + compatible =3D "nxp,pcf85063"; > > + reg =3D <0x51>; > > + }; > > + }; > > + }; > > +}; > > + > > +&i2c0 { > > + /delete-property/ pinctrl-names; > > + /delete-property/ pinctrl-0; > > }; > > &ddc0 { >=20 > Just some further information: >=20 > Cyril (who I talked to on irc) and I found that not only i2c0 can be used= to > access the gpio bus on pins 44/45 (as I did in v1) but that also &i2c1 can > drive these pins. However similar to &i2c0, &i2c1 is used on pins 2/3 per > default and so is also available on the default gpio header. >=20 > Also note that this is a breaking change, because overlays that added > devices to &i2c0 before (expecting them to be accessed via gpio0/1) need = to > modify /i2c0mux/i2c@0 now instead of /soc/i2c@7e205000 (aka &i2c0). We can mitigate that by setting the i2c0 label to the /i2c0mux/i2c@0 node, since the overlay will not resolve what i2c0 is connected to until it's applied. Also, I think it's worth noting that this change will mimic what the RPi kernel is doing. Maxime --gzu5ikz5w3uxzxs7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYbd5qwAKCRDj7w1vZxhR xZuMAP4+C9SXKQu+NZ6s/H5ggPoMrWZB/wCj1kjlgyggnvv/zgD/bJzjKg0BaYH9 1H62BC1UpTlFBIwUjXl2iDZsXvBNnA8= =V4HJ -----END PGP SIGNATURE----- --gzu5ikz5w3uxzxs7-- --===============5498765801602681415== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5498765801602681415==--