From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E985FC433EF for ; Mon, 13 Dec 2021 19:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VqaLCpSZPwL+03UszJA1oeLGnqdgkhXPL4IRjuBAtcM=; b=VlsKr1GyA5ztgZ DJb+xvH+E2/heNRzopQDOOjjiBE5kuyCElHslNoDOBP80iHBlky8R2zs5cmVk4WAfw5TKoVh3QXq3 qXSzMVOTu1MXyep14qDKMlDZ40YtAU3PRf/oPXeAfaFk5aVPN2dtXsjor+u8t6J3dGD82KnDb5XlO qzcnJHl3r/E5CKyOxqv4N/HXqks7jFZorajep8Q9/w3moObNE6cahRIMfrU6I8gvM9VKSYdBO8z0W YP3m4E3xErB5fIbXa04EkL0reCJSKvVVO4hZZKkT73OVwiMQ38hzYy8dYOInpTtQ4S4T6Hn1WWUaF aMZ3mcx1dcRlZCplXVBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwqs7-00B7dS-Jc; Mon, 13 Dec 2021 19:20:28 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwqs3-00B7cA-9r for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 19:20:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D5C9A611CB; Mon, 13 Dec 2021 19:20:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EB55C34602; Mon, 13 Dec 2021 19:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639423222; bh=sW9CU4aprjjMU/EXUeD9d+hsO1GDZHNaogjObAH+wIw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iEQ3eWp0w0QHoptdB4i1rSgFHEHoyzCoIet9JSliE+X9btY80ymE5zrLBJLEJNg7f CTo8yFuBDY2gRGBeqzJ90E4WGcFWTNtT1V+7wbMVIrHc1peABQyOl4S+K4Bn/9Xf4o gQJlJLL6N6Qxygmf/C8e+JhgTUQG8Kp7TJmAW92UgJYbEnMmG3w4zxXZCuDnv6EsBq UhBmIUgZq8kXfjeu6VxFBoUW0KCJ4jK6R6Ejf9gy36e9nt/F4v7cpym/Bd6PrHoVxt EyC5jS1LxFqQQ1wxn54QShAkRoJEcbmvx0MhsEhir7qaz4NLL0w30srwIiQHyuwArd Mn06H+SbBljMQ== Date: Mon, 13 Dec 2021 19:20:17 +0000 From: Will Deacon To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, boqun.feng@gmail.com, catalin.marinas@arm.com, peterz@infradead.org Subject: Re: [PATCH 1/5] arm64: atomics: format whitespace consistently Message-ID: <20211213192017.GA12868@willie-the-truck> References: <20211210151410.2782645-1-mark.rutland@arm.com> <20211210151410.2782645-2-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211210151410.2782645-2-mark.rutland@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_112023_471565_C66DFAD3 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 10, 2021 at 03:14:06PM +0000, Mark Rutland wrote: > The code for the atomic ops is formatted inconsistently, and while this > is not a functional problem it is rather distracting when working on > them. > > Some have ops have consistent indentation, e.g. > > | #define ATOMIC_OP_ADD_RETURN(name, mb, cl...) \ > | static inline int __lse_atomic_add_return##name(int i, atomic_t *v) \ > | { \ > | u32 tmp; \ > | \ > | asm volatile( \ > | __LSE_PREAMBLE \ > | " ldadd" #mb " %w[i], %w[tmp], %[v]\n" \ > | " add %w[i], %w[i], %w[tmp]" \ > | : [i] "+r" (i), [v] "+Q" (v->counter), [tmp] "=&r" (tmp) \ > | : "r" (v) \ > | : cl); \ > | \ > | return i; \ > | } > > While others have negative indentation for some lines, and/or have > misaligned trailing backslashes, e.g. > > | static inline void __lse_atomic_##op(int i, atomic_t *v) \ > | { \ > | asm volatile( \ > | __LSE_PREAMBLE \ > | " " #asm_op " %w[i], %[v]\n" \ > | : [i] "+r" (i), [v] "+Q" (v->counter) \ > | : "r" (v)); \ > | } > > This patch makes the indentation consistent and also aligns the trailing > backslashes. This makes the code easier to read for those (like myself) > who are easily distracted by these inconsistencies. > > This is intended as a cleanup. > There should be no functional change as a result of this patch. Looks the same to me: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel