From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71977C433F5 for ; Mon, 13 Dec 2021 18:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KNZfR+VgDujEbr4x82ApckK0t6GHBmHir/9rmtS9GKY=; b=SWeRHI0UyrMvxM PL1xBW6jCel3CirW9cRdAND9dT+6lUOlm3TyuKtLSlAmCWsg811IJVE2jMBZfr5TBl5f+VDE0kc2i wmCFTJriflYexMGGwQcYOOgw23qEglUhsnKXQdIXrZnwXdvyVta9iz1itc1DPSjL9dfy9F6hiH8z1 w7hEA7o8ZCbxOxwIWWhsYSaPj/hVDvQEoSLLJW1/KqtkWvjnA5WR85A31WlbINpP7Mgr7AYg3Zj/V upjNjaqiANiLahkfAEGDLS/JYv1O2X6D5VWJIKtFkL3elVWqAF77OP+cN1iKRPR5LGpqRf6EP+WFG DJn+mh8Cl0ZFRGj4CTZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwqNw-00B0eV-ED; Mon, 13 Dec 2021 18:49:16 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwqNt-00B0dR-E7 for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 18:49:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7KgDkATiU0RV/IfVLTSzsn/JOr6EcoRuymb7temF2c0=; b=duV+0Th6IUefxS61uwrRBfdARi vrDvGDfakFTlYNpd+A8TQsCt67+SvHZfnbW3XGO87RMAL0QOWxXc+lTBdYF3YZdqtG6aFUJxNrGLJ lEq+1JZ2cNMMAn9O+W9quGhpVgOPN4006Vws/aIVxB1YOGNxgVh92lQQG3y9HaaACPq8=; Received: from p200300ccff0a64001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0a:6400:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1mwqNn-0003kg-TG; Mon, 13 Dec 2021 19:49:08 +0100 Date: Mon, 13 Dec 2021 19:49:06 +0100 From: Andreas Kemnade To: Dmitry Torokhov Cc: Alistair Francis , Alistair Francis , linux-arm-kernel , devicetree , linux-input , Linux Kernel Mailing List , Mylene Josserand , Linus Walleij , Henrik Rydberg , Rob Herring , =?UTF-8?B?TXlsw6huZQ==?= Josserand , Maxime Ripard Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen Message-ID: <20211213194906.00fd028c@aktux> In-Reply-To: References: <20211103114830.62711-1-alistair@alistair23.me> <20211103114830.62711-2-alistair@alistair23.me> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_104913_683240_4814562A X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sun, 12 Dec 2021 21:45:48 -0800 Dmitry Torokhov wrote: > > > > + rc = devm_request_threaded_irq(dev, irq, NULL, cyttsp5_handle_irq, > > > > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > > > > > > Please do not override platform setup with hardcoded triggers. Also, it > > > is strongly recommended to use level interrupts for these peripherals. > > > > > > This is also likely unsafe if controller is not completely shut off and > > > is capable of generating interrupts given input device is not yet > > > allocated. > > > > I have dropped the `IRQF_TRIGGER_FALLING |` > > > > I have tried to use level interrupts, but I can't get the device > > working with them. > > That is weird, does the interrupt controller support level interrupts? > hmm, it should, at least on the imx6 I am using them for some other devices, I guess, on the imx7 they should work, too. I hope I find time to give that a try the next days. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel