From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA078C433EF for ; Wed, 15 Dec 2021 09:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GiSB9cSR2uXbcTzTxHrym7MBKd/OCKmHP6jXVlhsL6c=; b=do6Spo9+CEdAe2 OEg2JH/k1lQ2ReeEMGkCcDlg8ex+g/nSQ1yjAM3ImWDQ31uh2CBfs2m0QYtCPXCI+1ptPfnhJlkMc cPGDnlUzmFEPY8o0+xYsDsnf41SSkrsh6QQ1HSj71VCcbrtxS8f4nv3pZ1lx37GWwiKHu4lu11Mcw 7Up9M5t9HAvWI/16xcL8/pKAFtuumF+jJW9tTfTwt9zzQx8MGZe2y0v4okwJeF1ec8Q2oCz5ownAF xzc9rQqpcwr5kMLY7z86UTEZDEUvKgd/vnh/NIkGaspZAv95pyfc0pfu8q6gApSAsvWq5CpOVIrsq LodfcEIFNBX/QShy93tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxQV4-00HUFy-0I; Wed, 15 Dec 2021 09:23:02 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxQUz-00HUES-5X for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 09:22:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639560176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oUh0bcGmELD1OnjdrFkEycYt4atPMShERUPuuPbvtk8=; b=fktq+8/0tGXZDHrfys+5p9U/+tjRNKl5Tal3U/0XG+3YzIF63M/1G9RqMwPY0FxGvXx4nY B0WwImKscDwV0aXc6plNpDZX0gHrA/+zUnlcJv4FE+Psa4syB+ABDJlF1kJofWEErFf+D9 T8kRIL0uddkjwG4//yD4NSqwUO2tlEE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-247-j4UYqMpBM5a1H3pa9AG24w-1; Wed, 15 Dec 2021 04:22:49 -0500 X-MC-Unique: j4UYqMpBM5a1H3pa9AG24w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ABC2F190B2A3; Wed, 15 Dec 2021 09:22:46 +0000 (UTC) Received: from localhost (ovpn-12-120.pek2.redhat.com [10.72.12.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19135838E1; Wed, 15 Dec 2021 09:22:32 +0000 (UTC) Date: Wed, 15 Dec 2021 17:22:30 +0800 From: Baoquan He To: "Leizhen (ThunderTown)" Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , linux-kernel@vger.kernel.org, Dave Young , Vivek Goyal , Eric Biederman , kexec@lists.infradead.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Randy Dunlap , Feng Zhou , Kefeng Wang , Chen Zhou Subject: Re: [PATCH v17 04/10] x86: kdump: move xen_pv_domain() check and insert_resource() to setup_arch() Message-ID: <20211215092230.GE3023@MiWiFi-R3L-srv> References: <20211210065533.2023-1-thunder.leizhen@huawei.com> <20211210065533.2023-5-thunder.leizhen@huawei.com> <03bd43f3-14a1-dbd1-9fff-118c0885653c@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <03bd43f3-14a1-dbd1-9fff-118c0885653c@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_012257_299189_606236AF X-CRM114-Status: GOOD ( 28.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/15/21 at 04:56pm, Leizhen (ThunderTown) wrote: > > > On 2021/12/14 19:40, Leizhen (ThunderTown) wrote: > > > > > > On 2021/12/10 14:55, Zhen Lei wrote: > >> From: Chen Zhou > >> > >> We will make the functions reserve_crashkernel() as generic, the > >> xen_pv_domain() check in reserve_crashkernel() is relevant only to > >> x86, the same as insert_resource() in reserve_crashkernel[_low](). > >> So move xen_pv_domain() check and insert_resource() to setup_arch() > >> to keep them in x86. > >> > >> Suggested-by: Mike Rapoport > >> Signed-off-by: Chen Zhou > >> Signed-off-by: Zhen Lei > >> Tested-by: John Donnelly > >> Tested-by: Dave Kleikamp > >> Acked-by: Baoquan He > >> --- > >> arch/x86/kernel/setup.c | 19 +++++++++++-------- > >> 1 file changed, 11 insertions(+), 8 deletions(-) > >> > >> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > >> index bb2a0973b98059e..7ae00716a208f82 100644 > >> --- a/arch/x86/kernel/setup.c > >> +++ b/arch/x86/kernel/setup.c > >> @@ -456,7 +456,6 @@ static int __init reserve_crashkernel_low(void) > >> > >> crashk_low_res.start = low_base; > >> crashk_low_res.end = low_base + low_size - 1; > >> - insert_resource(&iomem_resource, &crashk_low_res); > >> #endif > >> return 0; > >> } > >> @@ -480,11 +479,6 @@ static void __init reserve_crashkernel(void) > >> high = true; > >> } > >> > >> - if (xen_pv_domain()) { > >> - pr_info("Ignoring crashkernel for a Xen PV domain\n"); > >> - return; > >> - } > >> - > >> /* 0 means: find the address automatically */ > >> if (!crash_base) { > >> /* > >> @@ -531,7 +525,6 @@ static void __init reserve_crashkernel(void) > >> > >> crashk_res.start = crash_base; > >> crashk_res.end = crash_base + crash_size - 1; > >> - insert_resource(&iomem_resource, &crashk_res); > >> } > >> #else > >> static void __init reserve_crashkernel(void) > >> @@ -1143,7 +1136,17 @@ void __init setup_arch(char **cmdline_p) > >> * Reserve memory for crash kernel after SRAT is parsed so that it > >> * won't consume hotpluggable memory. > >> */ > >> - reserve_crashkernel(); > > > > Hi Baoquan: > > How about move "#ifdef CONFIG_KEXEC_CORE" here, so that we can remove the > > empty reserve_crashkernel(). In fact, xen_pv_domain() is invoked only > > when CONFIG_KEXEC_CORE is enabled before. > > Hi Baoquan: > Did you miss this email? If no reply, I will keep it no change. I checked this patch, and it's no update since I acked it. Moving reserve_crashkernel() into the CONFIG_KEXEC_CORE ifdeffery is also fine to me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel