From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8C6DC433F5 for ; Wed, 15 Dec 2021 09:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aGSUIHRozqJ0P0EdCNvYuQFlXNG9B3fesngHEXdf7TI=; b=pJz5RsmeH+HeYcx/BeIIs9Zuw+ slMvri/A5DalmY67hcxSnqPdIBe+/v/a2fHDW6VdNMAqAY7k/ricUv4OzvD9IH8bN6dgkKKj2fdI+ fsAS4reQ8XtO7G7A+rdpVRpEMLHb3aTaPaJXDMlpdeMHzt2GxkQ5rR4Cs5f7nEZMc33QwPfMDTn+J Q9oEswJUwGX+W0wQ2qQVhhzi9uwsz7nLlQz2LKRtbTcWPbjaXkR0rKpMxxjoZBolbJsOZPXm4vXmo cxuSQFf1J3326txJdMYOElkMemZsAWfsg3nY9M4XoSv1xJtf6huWkIbsxNSRX6+lQX0qzGWchXid+ +C8zWbpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxR1l-0001y9-Iy; Wed, 15 Dec 2021 09:56:52 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxR1c-0001vP-HK; Wed, 15 Dec 2021 09:56:42 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 44E545C0488; Wed, 15 Dec 2021 04:56:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 15 Dec 2021 04:56:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=qrLgtx5qiOkpouVPEz1oAbv1V0M At4AXoQwHQhSnPyk=; b=mTllda4MiJ49VnYh4EpmRGF/q6oiGQchuM+BfPko6dV HVxhFcAl/bx1tuzpGcOVlsMZzpFdBqUdsGOT6YQVyV+ux0dgUf6pdhK3nfR/1oPR iMYNjVodnvlZo+yx3e3T6T4oJ1zsWBOXE8hqcZgXKt7GQc5L6DVI/QRxgo9x6saI 2aOulooDYebWhBZZ3Bh7XI0kMUzQZavHa0UZI2F4U5jVqsEQtpb7IilqSmTh86UI 4YuZAM5MZfMOrP8Fy3hYxqMu+l5v4P4rOwgEp+0fbV0LZpb5DgtVhZ6gNrdZb7i9 jOorNW5TyR+Aw49ncqK6pyb8c0uhIeuwW3GXdVzbOSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=qrLgtx 5qiOkpouVPEz1oAbv1V0MAt4AXoQwHQhSnPyk=; b=K0iB22kkKmMONeT/TPC/Ad 73imI5wZerdvoY+gbEFYHB8kgsw5Z5HGM97pyfiWKV3OrlA0eRprJ1iPgLaMy/5H DHt1ywiZgTsuPRVrEGUBZVJzDk5b8uIIDE6HeyV4pZDrdly6f5UfcbcdtN9kbOkT pebbUG3tU9USIkRNwsfgI1T4trdDU1K2CnfUcydSuzptOs3QD3NlsZyb6cuVcIaO LBQZd1P9YJoPVvbQvKrOyUoK7891Un5ly26njBjzW+q14Kz30LGE5HavOvMjFkMx TdWOUfF8euZTZI4EL/nX/NP/HjDdvFMNVvagl3gV6t8YMQTDUYsqmooOfbDzu64A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrledvgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeejkeekffdtfffhhfevvddutefgtdeljeevffevvddvteegledtgfeghfehvdei ffenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Dec 2021 04:56:38 -0500 (EST) Date: Wed, 15 Dec 2021 10:56:37 +0100 From: Maxime Ripard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Cyril Brulebois , Dave Stevenson Subject: Re: [PATCH v2] ARM: dts: bcm2711-rpi-cm4-io: Add rtc on a pinctrl-muxed i2c bus Message-ID: <20211215095637.dlrixu4iy3awpmek@houat> References: <20211209181813.1312509-1-u.kleine-koenig@pengutronix.de> <22b563b0-8d9e-52a1-ebdc-e1f75a855d86@kleine-koenig.org> <20211213164947.dzuarzi4gqo6gxzo@houat> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_015640_712439_D4559002 X-CRM114-Status: GOOD ( 43.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6362939701907443879==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6362939701907443879== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tmwbesryeqs7uxaj" Content-Disposition: inline --tmwbesryeqs7uxaj Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 13, 2021 at 09:25:16PM +0100, Uwe Kleine-K=F6nig wrote: > Hello Maxime, >=20 > On 12/13/21 17:49, Maxime Ripard wrote: > > On Thu, Dec 09, 2021 at 10:21:39PM +0100, Uwe Kleine-K=F6nig wrote: > > > I used the wrong git wrapper so this patch appeared with the wrong se= nder > > > address. If need be I can resend from the address used in the S-o-b. > >=20 > > Your SoB seems to match the From header, so unless you'd like to > > contribute with your pengutronix it should be fine? >=20 > The problem is that the sender of the patch (i.e. my pengutronix self) > didn't add a S-o-b. I don't think that's a problem, but I might be wrong > > > On 12/9/21 19:18, Uwe Kleine-K=F6nig wrote: > > > > From: Uwe Kleine-K=F6nig > > > >=20 > > > > The cm4-io board comes with an PCF85063. Add it to the device tree = to make > > > > it usable. The i2c0 bus can use two different pinmux settings to use > > > > different pins. To keep the bus appearing on the usual pin pair (gp= io0 + > > > > gpio1) use a pinctrl-muxed setting as the upstream dts does. > > > >=20 > > > > Signed-off-by: Uwe Kleine-K=F6nig > > > > --- > > > > arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts | 35 ++++++++++++++++++= ++++++ > > > > 1 file changed, 35 insertions(+) > > > >=20 > > > > diff --git a/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts b/arch/arm/bo= ot/dts/bcm2711-rpi-cm4-io.dts > > > > index 19600b629be5..5ddad146b541 100644 > > > > --- a/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts > > > > +++ b/arch/arm/boot/dts/bcm2711-rpi-cm4-io.dts > > > > @@ -18,6 +18,41 @@ led-pwr { > > > > linux,default-trigger =3D "default-on"; > > > > }; > > > > }; > > > > + > > > > + i2c0mux { > > > > + compatible =3D "i2c-mux-pinctrl"; > > > > + #address-cells =3D <1>; > > > > + #size-cells =3D <0>; > > > > + > > > > + i2c-parent =3D <&i2c0>; > > > > + > > > > + pinctrl-names =3D "i2c0", "i2c0-vc"; > > > > + pinctrl-0 =3D <&i2c0_gpio0>; > > > > + pinctrl-1 =3D <&i2c0_gpio44>; > > > > + > > > > + i2c@0 { > > > > + reg =3D <0>; > > > > + #address-cells =3D <1>; > > > > + #size-cells =3D <0>; > > > > + }; > > > > + > > > > + i2c@1 { > > > > + reg =3D <1>; > > > > + #address-cells =3D <1>; > > > > + #size-cells =3D <0>; > > > > + > > > > + rtc@51 { > > > > + /* Attention: An alarm resets the machine */ > > > > + compatible =3D "nxp,pcf85063"; > > > > + reg =3D <0x51>; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&i2c0 { > > > > + /delete-property/ pinctrl-names; > > > > + /delete-property/ pinctrl-0; > > > > }; > > > > &ddc0 { > > >=20 > > > Just some further information: > > >=20 > > > Cyril (who I talked to on irc) and I found that not only i2c0 can be = used to > > > access the gpio bus on pins 44/45 (as I did in v1) but that also &i2c= 1 can > > > drive these pins. However similar to &i2c0, &i2c1 is used on pins 2/3= per > > > default and so is also available on the default gpio header. > > >=20 > > > Also note that this is a breaking change, because overlays that added > > > devices to &i2c0 before (expecting them to be accessed via gpio0/1) n= eed to > > > modify /i2c0mux/i2c@0 now instead of /soc/i2c@7e205000 (aka &i2c0). > >=20 > > We can mitigate that by setting the i2c0 label to the /i2c0mux/i2c@0 > > node, since the overlay will not resolve what i2c0 is connected to until > > it's applied. >=20 > It depends on the overlay if that works or not. If the node to patch is > specified by label, this is fine. If however the node is referenced by pa= th > (which is the usual thing for mainline, as the dtbs are compiled without > -@), this change is a problem. I'm not sure that using path is as ubiquitous with mainline as you imply (I've never used or saw that myself), but yeah, any overlay that would use the path directly would be broken. > I'm not aware how bcm2711-rpi-cm4-io.dts could make the i2c0 label point = to > the i2c@0 node that is introduced here. After all the i2c label is defined > in another file. Is there some syntax to do that? >=20 > > Also, I think it's worth noting that this change will mimic what the RPi > > kernel is doing. >=20 > The commit log has "Use [...] as the upstream dts does.". Isn't that good > enough? Isn't upstream usually kernel.org kernels? Maxime --tmwbesryeqs7uxaj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYbm71AAKCRDj7w1vZxhR xc5fAP9W6qRS9WZZwM3x5gjdgTnjsP8VPdOFUK9/fFI1QasxLQEAhUG6+KshuYQO QMxsjrigPwhFdBSLIW37Yn2hC4E3vwM= =6vJ7 -----END PGP SIGNATURE----- --tmwbesryeqs7uxaj-- --===============6362939701907443879== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6362939701907443879==--