public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Tudor Ambarus <tudor.ambarus@microchip.com>
To: <vkoul@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
	mripard@kernel.org, linux-kernel@vger.kernel.org,
	ludovic.desroches@microchip.com, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 08/12] dmaengine: at_xdmac: Remove a level of indentation in at_xdmac_advance_work()
Date: Wed, 15 Dec 2021 13:01:11 +0200	[thread overview]
Message-ID: <20211215110115.191749-9-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <20211215110115.191749-1-tudor.ambarus@microchip.com>

It's easier to read code with fewer levels of indentation, remove a level
of indentation in at_xdmac_advance_work()

if (!foo() & !bar()) {
}

was replaced by:

if (foo() || bar())
	return;

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
 drivers/dma/at_xdmac.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index eeb03065d484..0b09ec752db4 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1593,14 +1593,14 @@ static void at_xdmac_advance_work(struct at_xdmac_chan *atchan)
 	 * If channel is enabled, do nothing, advance_work will be triggered
 	 * after the interruption.
 	 */
-	if (!at_xdmac_chan_is_enabled(atchan) && !list_empty(&atchan->xfers_list)) {
-		desc = list_first_entry(&atchan->xfers_list,
-					struct at_xdmac_desc,
-					xfer_node);
-		dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc);
-		if (!desc->active_xfer)
-			at_xdmac_start_xfer(atchan, desc);
-	}
+	if (at_xdmac_chan_is_enabled(atchan) || list_empty(&atchan->xfers_list))
+		return;
+
+	desc = list_first_entry(&atchan->xfers_list, struct at_xdmac_desc,
+				xfer_node);
+	dev_vdbg(chan2dev(&atchan->chan), "%s: desc 0x%p\n", __func__, desc);
+	if (!desc->active_xfer)
+		at_xdmac_start_xfer(atchan, desc);
 }
 
 static void at_xdmac_handle_cyclic(struct at_xdmac_chan *atchan)
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-12-15 11:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 11:01 [PATCH v3 00/12] dmaengine: at_xdmac: Various fixes Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 01/12] dmaengine: at_xdmac: Don't start transactions at tx_submit level Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 02/12] dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 03/12] dmaengine: at_xdmac: Print debug message after realeasing the lock Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 04/12] dmaengine: at_xdmac: Fix concurrency over chan's completed_cookie Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 05/12] dmaengine: at_xdmac: Fix race for the tx desc callback Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 06/12] dmaengine: at_xdmac: Move the free desc to the tail of the desc list Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 07/12] dmaengine: at_xdmac: Fix concurrency over xfers_list Tudor Ambarus
2021-12-15 11:01 ` Tudor Ambarus [this message]
2021-12-15 11:01 ` [PATCH v3 09/12] dmaengine: at_xdmac: Fix lld view setting Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 10/12] dmaengine: at_xdmac: Fix at_xdmac_lld struct definition Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 11/12] dmaengine: at_xdmac: Remove a level of indentation in at_xdmac_tasklet() Tudor Ambarus
2021-12-15 11:01 ` [PATCH v3 12/12] dmaengine: at_xdmac: Fix race over irq_status Tudor Ambarus
2022-01-05 10:20 ` [PATCH v3 00/12] dmaengine: at_xdmac: Various fixes Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211215110115.191749-9-tudor.ambarus@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=mripard@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox