From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92FBFC433EF for ; Thu, 16 Dec 2021 05:54:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f4ogt8S+VqSPSKPRBt9TlrAjRxWwr/BRls0oM9n2DtA=; b=c/hxilzGsAGAcW khUnw1y+yJUtVkLiVk+KJ66/RAPqE3yaLaB9y/IclBLjBPorpjr2nwLRrq2gKulR5+3IF8ikmjFpl uRjA6HRgU/BUpdZqg8cts654I+dHcVW1yLde8ssTg1Kw8mO04iwdJT5P+2Eu6Um81toD62e0h0Eus Bisgw4915x3ht0OcStNNZJwdbZ4kAHIhV+Qufn4GRhIe7pFXXOgiiGeJdTAV4CtDGHddWROgJfUBS oqVyPvyJfspYnbaYEPsPqC6Bl8IZgcEaozw5FN1JM8R1TWu6cHclvLk0QXEejnUKLFKLr2OCYR3Ad BtikreuBHe3US96DghHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxjhH-003dfs-07; Thu, 16 Dec 2021 05:52:55 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxjhD-003dfJ-7t for linux-arm-kernel@lists.infradead.org; Thu, 16 Dec 2021 05:52:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 75751CE1FD9; Thu, 16 Dec 2021 05:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 687F2C36AE0; Thu, 16 Dec 2021 05:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639633966; bh=yDB3JSBtCO2FSCaWm7lUt8DS3v+DDe2jEQ73h/juHC4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aGzGwxe8GY24j03AbRcofgFM9tim1QE/tW5xGjnIiBoidQrYdI0HUFAaOQNXyntDP Ex73srgBrKRRADOei5gyZAkqsmE+0orUNqNL+9xNwN52LGDhQIjMjy0kxjCGcV0w1K sUsoMqTXPFB8gxGW+vv0xQWKs2mOeVhP9M/551HjZUQmmEvt5jz8vAh+kuZCIQrTss eppj/TvwyUWjcdj0NlwXvWjQSySpDm+5i4bMreGy7pFLgTYAt1dPkUVlZvsq0U7aYm nJXyOX0djc01+rFJ3jFvPgeXNcXcegoR8CGttBsIKrvO2DBm4cbKVHOEmnxCkR+tnD sRtp9uRqvUDmQ== Date: Thu, 16 Dec 2021 13:52:41 +0800 From: Shawn Guo To: Lucas Stach Cc: Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-arm-kernel@lists.infradead.org, "Lukas F . Hartmann" Subject: Re: [PATCH 1/3] arm64: dts: mnt-reform2: add internal display support Message-ID: <20211216055240.GT4216@dragon> References: <20211212134912.1988208-1-dev@lynxeye.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211212134912.1988208-1-dev@lynxeye.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_215251_669910_3FC8C573 X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Dec 12, 2021 at 02:49:10PM +0100, Lucas Stach wrote: > This adds support for the internal display of the Reform2 Laptop, which > is connected to the i.MX8MQ via a MIPI-DSI->eDP bridge chip. Clocking > is derived from a system PLL, which provides quite good rate matching > for the single supported display mode and keeps the video PLL free for > usage with the external display, which isn't supported yet. > > Signed-off-by: Lucas Stach > --- > .../boot/dts/freescale/imx8mq-mnt-reform2.dts | 139 ++++++++++++++++++ > 1 file changed, 139 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts > index 4f2db6197b39..b96825799f3d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts > @@ -13,6 +13,30 @@ / { > model = "MNT Reform 2"; > compatible = "mntre,reform2", "boundary,imx8mq-nitrogen8m-som", "fsl,imx8mq"; > > + backlight: backlight { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_backlight>; > + compatible = "pwm-backlight"; Let's start properties with compatible. > + pwms = <&pwm2 0 10000>; > + power-supply = <®_main_usb>; > + enable-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; > + brightness-levels = <0 32 64 128 160 200 255>; > + default-brightness-level = <6>; > + }; > + > + panel { > + compatible = "innolux,n125hce-gn1", "simple-panel"; > + power-supply = <®_main_3v3>; > + backlight = <&backlight>; > + no-hpd; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&edp_bridge_out>; > + }; > + }; > + }; > + > pcie1_refclk: clock-pcie1-refclk { > compatible = "fixed-clock"; > #clock-cells = <0>; > @@ -41,6 +65,22 @@ reg_main_usb: regulator-main-usb { > vin-supply = <®_main_5v>; > }; > > + reg_main_1v8: regulator-main-1v8 { > + compatible = "regulator-fixed"; > + regulator-name = "1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + vin-supply = <®_main_3v3>; > + }; > + > + reg_main_1v2: regulator-main-1v2 { > + compatible = "regulator-fixed"; > + regulator-name = "1V2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + vin-supply = <®_main_5v>; > + }; > + > sound { > compatible = "fsl,imx-audio-wm8960"; > audio-cpu = <&sai2>; > @@ -60,6 +100,13 @@ sound { > }; > }; > > +&dphy { > + status = "okay"; Let's end properties with status. > + assigned-clocks = <&clk IMX8MQ_CLK_DSI_PHY_REF>; > + assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_800M>; > + assigned-clock-rates = <25000000>; > +}; > + > &fec1 { > status = "okay"; > }; > @@ -83,6 +130,66 @@ rtc@68 { > }; > }; > > +&i2c4 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c4>; > + status = "okay"; > + > + edp_bridge: bridge@2c { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_edp_bridge>; > + compatible = "ti,sn65dsi86"; Same here. > + reg = <0x2c>; > + enable-gpios = <&gpio3 20 GPIO_ACTIVE_HIGH>; > + vccio-supply = <®_main_1v8>; > + vpll-supply = <®_main_1v8>; > + vcca-supply = <®_main_1v2>; > + vcc-supply = <®_main_1v2>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + edp_bridge_in: endpoint { > + remote-endpoint = <&mipi_dsi_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + edp_bridge_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > + }; > +}; > + > +&lcdif { > + status = "okay"; Same here. Shawn > + assigned-clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>; > + assigned-clock-parents = <&clk IMX8MQ_SYS1_PLL_800M>; > + /delete-property/assigned-clock-rates; > +}; > + > +&mipi_dsi { > + status = "okay"; > + > + ports { > + port@1 { > + reg = <1>; > + > + mipi_dsi_out: endpoint { > + remote-endpoint = <&edp_bridge_in>; > + }; > + }; > + }; > +}; > + > &pcie1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_pcie1>; > @@ -95,6 +202,13 @@ &pcie1 { > status = "okay"; > }; > > +&pwm2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm2>; > + status = "okay"; > +}; > + > + > ®_1p8v { > vin-supply = <®_main_5v>; > }; > @@ -168,6 +282,18 @@ &usdhc2 { > }; > > &iomuxc { > + pinctrl_backlight: backlightgrp { > + fsl,pins = < > + MX8MQ_IOMUXC_GPIO1_IO10_GPIO1_IO10 0x3 > + >; > + }; > + > + pinctrl_edp_bridge: edpbridgegrp { > + fsl,pins = < > + MX8MQ_IOMUXC_SAI5_RXC_GPIO3_IO20 0x1 > + >; > + }; > + > pinctrl_i2c3: i2c3grp { > fsl,pins = < > MX8MQ_IOMUXC_I2C3_SCL_I2C3_SCL 0x4000007f > @@ -175,12 +301,25 @@ MX8MQ_IOMUXC_I2C3_SDA_I2C3_SDA 0x4000007f > >; > }; > > + pinctrl_i2c4: i2c4grp { > + fsl,pins = < > + MX8MQ_IOMUXC_I2C4_SCL_I2C4_SCL 0x40000022 > + MX8MQ_IOMUXC_I2C4_SDA_I2C4_SDA 0x40000022 > + >; > + }; > + > pinctrl_pcie1: pcie1grp { > fsl,pins = < > MX8MQ_IOMUXC_SAI5_RXD2_GPIO3_IO23 0x16 > >; > }; > > + pinctrl_pwm2: pwm2grp { > + fsl,pins = < > + MX8MQ_IOMUXC_SPDIF_RX_PWM2_OUT 0x3 > + >; > + }; > + > pinctrl_sai2: sai2grp { > fsl,pins = < > MX8MQ_IOMUXC_SAI2_RXD0_SAI2_RX_DATA0 0xd6 > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel