linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: stm32mp1: remove redundant assignment to pointer data
@ 2021-11-26 22:12 Colin Ian King
  2021-12-16  6:48 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2021-11-26 22:12 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Maxime Coquelin,
	Alexandre Torgue, linux-clk, linux-stm32, linux-arm-kernel
  Cc: kernel-janitors, linux-kernel

The pointer data is being initialized with a value and a few lines
later on being re-assigned the same value, so this re-assignment is
redundant. Clean up the code and remove it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/clk/clk-stm32mp1.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/clk/clk-stm32mp1.c b/drivers/clk/clk-stm32mp1.c
index 4bd1fe7d8af4..863274aa50e3 100644
--- a/drivers/clk/clk-stm32mp1.c
+++ b/drivers/clk/clk-stm32mp1.c
@@ -2253,8 +2253,6 @@ static int stm32_rcc_reset_init(struct device *dev, void __iomem *base,
 	const struct stm32_rcc_match_data *data = match->data;
 	struct stm32_reset_data *reset_data = NULL;
 
-	data = match->data;
-
 	reset_data = kzalloc(sizeof(*reset_data), GFP_KERNEL);
 	if (!reset_data)
 		return -ENOMEM;
-- 
2.33.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: stm32mp1: remove redundant assignment to pointer data
  2021-11-26 22:12 [PATCH] clk: stm32mp1: remove redundant assignment to pointer data Colin Ian King
@ 2021-12-16  6:48 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2021-12-16  6:48 UTC (permalink / raw)
  To: Alexandre Torgue, Colin Ian King, Maxime Coquelin,
	Michael Turquette, linux-arm-kernel, linux-clk, linux-stm32
  Cc: kernel-janitors, linux-kernel

Quoting Colin Ian King (2021-11-26 14:12:39)
> The pointer data is being initialized with a value and a few lines
> later on being re-assigned the same value, so this re-assignment is
> redundant. Clean up the code and remove it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---

Applied to clk-next

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-16  6:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-26 22:12 [PATCH] clk: stm32mp1: remove redundant assignment to pointer data Colin Ian King
2021-12-16  6:48 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).