From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B566C433F5 for ; Fri, 17 Dec 2021 06:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2vFxLLHOI9TKwF5UJ3GsEEKZ9Vn9sU5m2TKJuv7i0Wo=; b=3KVeZXl9Px2TfM ydam0Brn8MU6laDw4tZLo+fEG0zAa+Yc0M0vJyrnwwk/KJvRQxRxMnZPePmcSAtv7UJaKma88wPYG DX7CdJhMtm/zv+aGvsmN2qCnbLhXJbcbTHTYifEgLLQFzMIPIZCz84BjfZTuCfQnOZ56R29EBuOdn qamr+Z1DiltwBZ/I3gev9Kox6bk79QVMxeU2J/wN6fc8KrL2wArP1ReaJ8luMMkXCzeawawJ9SV+D 104VHAbOCVEJIl700GpLx6EJmJQV6exwbqbeTvh/xnxZ67ec0UzfWvysEUOSPGacwcTuaOomh9vNG i6YsOzpvg1f5pd3zWeOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1my6HN-008iLD-Jy; Fri, 17 Dec 2021 05:59:41 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1my6HK-008i4q-8D for linux-arm-kernel@lists.infradead.org; Fri, 17 Dec 2021 05:59:39 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10200"; a="263859499" X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="263859499" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2021 21:57:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="465011786" Received: from linux.intel.com ([10.54.29.200]) by orsmga003.jf.intel.com with ESMTP; 16 Dec 2021 21:57:35 -0800 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 6ACF4580127; Thu, 16 Dec 2021 21:57:32 -0800 (PST) Date: Fri, 17 Dec 2021 13:57:29 +0800 From: Wong Vee Khee To: "Russell King (Oracle)" Cc: Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Coquelin , Andrew Lunn , "David S. Miller" , Heiner Kallweit , Jakub Kicinski , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: Re: [PATCH CFT net-next 0/6] net: stmmac/xpcs: modernise PCS support Message-ID: <20211217055729.GA14835@linux.intel.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211216_215938_335059_376448A4 X-CRM114-Status: GOOD ( 31.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 16, 2021 at 01:11:40PM +0000, Russell King (Oracle) wrote: > Hi, > > This series updates xpcs and stmmac for the recent changes to phylink > to better support split PCS and to get rid of private MAC validation > functions. > > This series is slightly more involved than other conversions as stmmac > has already had optional proper split PCS support. > > The patches: > > 1) Provide a function to query the xpcs for the interface modes that > are supported. > > 2) Populates the MAC capabilities and switches stmmac_validate() to use > phylink_get_linkmodes(). We do not use phylink_generic_validate() yet > as (a) we do not always have the supported interfaces populated, and > (b) the existing code does not restrict based on interface. There > should be no functional effect from this patch. > > 3) Populates phylink's supported interfaces from the xpcs when the xpcs > is configured by firmware and also the firmware configured interface > mode. Note: this will restrict stmmac to only supporting these > interfaces modes - stmmac maintainers need to verify that this > behaviour is acceptable. > > 4) stmmac_validate() tail-calls xpcs_validate(), but we don't need it to > now that PCS have their own validation method. Convert stmmac and > xpcs to use this method instead. > > 5) xpcs sets the poll field of phylink_pcs to true, meaning xpcs > requires its status to be polled. There is no need to also set the > phylink_config.pcs_poll. Remove this. > > 6) Switch to phylink_generic_validate(). This is probably the most > contravertial change in this patch set as this will cause the MAC to > restrict link modes based on the interface mode. From an inspection > of the xpcs driver, this should be safe, as XPCS only further > restricts the link modes to a subset of these (whether that is > correct or not is not an issue I am addressing here.) For > implementations that do not use xpcs, this is a more open question > and needs feedback from stmmac maintainers. > > Please review and test this series. Thanks! > Tested this patch series on my Intel Elkhart Lake setup with Marvell 88E1510 PHY. Everything works perfectly! > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 144 ++++++---------------- > drivers/net/pcs/pcs-xpcs.c | 41 +++--- > include/linux/pcs/pcs-xpcs.h | 3 +- > 3 files changed, 67 insertions(+), 121 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel