Re: [PATCH v7 06/14] dt-bindings: Add en7523-scu device tree binding documentation

Stephen Boyd
2022-01-06T01:32:11Z

Quoting Felix Fietkau (2021-12-17 03:23:36)
> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> new file mode 100644
> index 000000000000..79660f8126fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/airoha,en7523-scu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: EN7523 Clock Device Tree Bindings
> +
> +maintainers:
> + - Felix Fietkau <nbd@nbd.name>
> + - John Crispin <nbd@nbd.name>
> +
> +description: |
> + This node defines the System Control Unit of the EN7523 SoC,
> + a collection of registers configuring many different aspects of the SoC.
> +
> + The clock driver uses it to read and configure settings of the
> + PLL controller, which provides clocks for the CPU, the bus and
> + other SoC internal peripherals.
> +
> + Each clock is assigned an identifier and client nodes use this identifier
> + to specify which clock they consume.
> +
> + All these identifiers can be found in:
> + [1]: <include/dt-bindings/clock/en7523-clk.h>.
> +
> + The clocks are provided inside a system controller node.
> +
> +properties:
> + compatible:
> + items:
> + - const: airoha,en7523-scu
> +
> + reg:
> + maxItems: 2
> +
> + "#clock-cells":
> + description:
> + The first cell indicates the clock number, see [1] for available
> + clocks.
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> +

Any input clocks?

> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/en7523-clk.h>
> + scu: scu@1fa20000 {

Maybe that should be system-controller@1fa20000 instead?

> + compatible = "airoha,en7523-scu";
> + reg = <0x1fa20000 0x400>,
> + <0x1fb00000 0x1000>;
> + #clock-cells = <1>;
> + };