From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD653C433F5 for ; Sat, 18 Dec 2021 22:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oyK5rjH+pnNzk2W3W3yk5DQPHUEMaqI+gkp/nU13rUg=; b=wcXqPf/iqCBO4+ SBcWOTRrc8Sb9JnW+v3mu7i3HPdY0/yv5nqPxf/Oxn8w8uK433kh89g/4Q4EudbEkBSPUDQqroGvI XnTmLKVx/K3QJ4e3brr59Kseaq6BSwe6rXBofwfxyx4uP6sZ6UMpHfPU3/zU+5LpPGsttTj4A643X 9mbKUzj6HWdEKrf8eLDb3nVLyYivOhRw2bMFAXvSAgel7m+db9ImvezD5kfYKYG7SCfMPeaCFyoJp sMfI406yvTw8E4OYYX8vqq4RMW1LjeLyVBtejBgWqZeCa14UEyw0PLYyUR5jfESXxyIZurObh9ShC FaOkWonWkjBGFz1V+RlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1myi2D-00Esyx-N8; Sat, 18 Dec 2021 22:18:33 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1myi2A-00EsyA-Da for linux-arm-kernel@lists.infradead.org; Sat, 18 Dec 2021 22:18:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZMb51E6KIpSjsQW+jd8frtGaT6vhwW8/i2odCT2vAkc=; b=XBI56e9pvCS2EE1UewcJjtmWql KVws55FcQfcMhNmLZK7cYabJmrMSN+da+bquFXyb+Vlq5FBPs/jTI3TSYeccu8FrU5kckI0tR0+pm 3idhvUThxqYJaP9Py2YdBpRVahyAiDZE+PXZ9aiqFoH9Uvbw4JUBBiZMtVUtmnKvnDeI=; Received: from p200300ccff35fb001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff35:fb00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1myi24-0007me-8c; Sat, 18 Dec 2021 23:18:24 +0100 Date: Sat, 18 Dec 2021 23:18:23 +0100 From: Andreas Kemnade To: Dmitry Torokhov Cc: Alistair Francis , Alistair Francis , linux-arm-kernel , devicetree , linux-input , Linux Kernel Mailing List , Mylene Josserand , Linus Walleij , Henrik Rydberg , Rob Herring , =?UTF-8?B?TXlsw6huZQ==?= Josserand , Maxime Ripard Subject: Re: [PATCH v2 1/4] Input: Add driver for Cypress Generation 5 touchscreen Message-ID: <20211218231823.49a72256@aktux> In-Reply-To: References: <20211103114830.62711-1-alistair@alistair23.me> <20211103114830.62711-2-alistair@alistair23.me> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211218_141830_672526_FBC01CD7 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sun, 12 Dec 2021 21:45:48 -0800 Dmitry Torokhov wrote: [...] > > > This is also likely unsafe if controller is not completely shut off and > > > is capable of generating interrupts given input device is not yet > > > allocated. > > > > I have dropped the `IRQF_TRIGGER_FALLING |` > > > > I have tried to use level interrupts, but I can't get the device > > working with them. > > That is weird, does the interrupt controller support level interrupts? > I have set level interrupts via the devicetree, things seem to work on Kobo Clara HD: /proc/interrupts 203: 37402 gpio-mxc 6 Level tt21000 touchscreen@24 { compatible = "cypress,tt21000"; reg = <0x24>; pinctrl-names = "default","sleep"; pinctrl-0 = <&pinctrl_cyttsp5_gpio>; pinctrl-1 = <&pinctrl_cyttsp5_gpio_sleep>; interrupt-parent = <&gpio5>; interrupts = <6 IRQ_TYPE_LEVEL_LOW>; reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>; }; Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel