Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Jiankang Chen <jkchen@linux.alibaba.com>
Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	mike.leach@linaro.org, zhangliguang@linux.alibaba.com
Subject: Re: [RFC V2 PATCH] coresight: change tmc from misc device to cdev device
Date: Mon, 20 Dec 2021 10:37:46 +0800	[thread overview]
Message-ID: <20211220023746.GA1006298@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <6db4c901-a12b-3176-5895-3c1832941f04@linux.alibaba.com>

Hi Jay,

On Mon, Dec 20, 2021 at 10:32:21AM +0800, Jiankang Chen wrote:

[...]

> > > +module_init(tmc_init);

> > Should invoke tmc_init() in an ealier phase so it can prepare device class
> > prior to the TMC devices registration?  In other words, I think here
> > should be:
> > 
> >    subsys_initcall(tmc_init);
> > 
> Your suggestion is very good. I will revise it according to your suggestion;

As I clarified for Mathieu's concerning in another reply, please ignore
this comment.

Thanks,
Leo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-20  2:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17  3:42 [RFC V2 PATCH] coresight: change tmc from misc device to cdev device Jay Chen
2021-12-17  7:54 ` Leo Yan
2021-12-17 17:18   ` Mathieu Poirier
2021-12-18  4:21     ` Leo Yan
2021-12-20  2:32   ` Jiankang Chen
2021-12-20  2:37     ` Leo Yan [this message]
2021-12-20  2:41       ` Jiankang Chen
2021-12-17 17:15 ` Mathieu Poirier
2021-12-20  9:48   ` Jiankang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211220023746.GA1006298@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=coresight@lists.linaro.org \
    --cc=jkchen@linux.alibaba.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    --cc=zhangliguang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox