From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBB1EC433F5 for ; Wed, 22 Dec 2021 18:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MXqj3epQD/REA4m1iwSVqZc5Sz9nAwh9P1vNDHY/rNM=; b=gZj7EBmBnsAUIB mv8FtT06AJoBYyjtzkmW2D0nwaiyogcAShKc7ryJvwqWYkXegK/k/f0BhLHJfBTIHLsuXQiIQNI3N +mMwr2QnXpRcQSGt9+PyAu+7Jit8mxZSvZQplNrKa1AC9AHjjHTpWeu/2SWO+Ggv/vOyNeep/9IW3 LGBppybRPu7zpEsJBHiSq4E78d8S9IXeNcQGNM8rRentU0wCXYQvIaKRdRgC1vMQIKscWCYqzEKdm tGccMpFj6VedtBMFyLD5HyfzWOGp0IrOZMF9vWmY6Ix8Tpc8+/DFsKAYufrEWkcy8lLjrlaILp3m0 hK6oMLIo8CTWS9k+5HUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0693-00B3NM-Qr; Wed, 22 Dec 2021 18:15:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0690-00B3MG-5c for linux-arm-kernel@lists.infradead.org; Wed, 22 Dec 2021 18:15:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A613D1FB; Wed, 22 Dec 2021 10:15:15 -0800 (PST) Received: from bogus (unknown [10.57.36.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 64F953F5A1; Wed, 22 Dec 2021 10:15:14 -0800 (PST) Date: Wed, 22 Dec 2021 18:15:11 +0000 From: Sudeep Holla To: trix@redhat.com Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: replace resevered identifiers in macros Message-ID: <20211222181511.n262joky3gw7h2gr@bogus> References: <20211222172519.3209478-1-trix@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211222172519.3209478-1-trix@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_101518_282222_7F5E65DD X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 22, 2021 at 09:25:19AM -0800, trix@redhat.com wrote: > From: Tom Rix > > Identifiers starting with __ are resevered. Replace __X with X. > > The arguments to these macros are pointers. The macros only reads > values. There is no need to make copies of the pointers, use them > directly. > Agreed and thanks for the patch. However the original patch was modified and these macros were moved to inline functions[0] after the initial build warnings from the build bot[1]. Sorry my reply to the bot seems to have got lost and didn't make it to the list. -- Regards, Sudeep [0] https://git.kernel.org/sudeep.holla/c/a690b7e6e7 [1] https://lore.kernel.org/lkml/202112211457.TlWRYcoq-lkp@intel.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel