* [PATCH] pinctrl: imx: fix assigning groups names
@ 2021-12-27 12:22 Rafał Miłecki
2021-12-27 12:34 ` Fabio Estevam
2022-01-02 6:34 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Rafał Miłecki @ 2021-12-27 12:22 UTC (permalink / raw)
To: Linus Walleij
Cc: Dong Aisheng, Fabio Estevam, Shawn Guo, Stefan Agner,
Pengutronix Kernel Team, Sascha Hauer, NXP Linux Team, linux-gpio,
linux-arm-kernel, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
This fixes regression caused by incorrect array indexing.
Reported-by: Fabio Estevam <festevam@gmail.com>
Fixes: 02f117134952 ("pinctrl: imx: prepare for making "group_names" in "function_desc" const")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/pinctrl/freescale/pinctrl-imx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 16bc1bfc03e4..fa3cc0b80ede 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -649,7 +649,7 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
struct function_desc *func;
struct group_desc *grp;
const char **group_names;
- u32 i = 0;
+ u32 i;
dev_dbg(pctl->dev, "parse function(%d): %pOFn\n", index, np);
@@ -669,10 +669,12 @@ static int imx_pinctrl_parse_functions(struct device_node *np,
sizeof(char *), GFP_KERNEL);
if (!group_names)
return -ENOMEM;
+ i = 0;
for_each_child_of_node(np, child)
- group_names[i] = child->name;
+ group_names[i++] = child->name;
func->group_names = group_names;
+ i = 0;
for_each_child_of_node(np, child) {
grp = devm_kzalloc(ipctl->dev, sizeof(struct group_desc),
GFP_KERNEL);
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: imx: fix assigning groups names
2021-12-27 12:22 [PATCH] pinctrl: imx: fix assigning groups names Rafał Miłecki
@ 2021-12-27 12:34 ` Fabio Estevam
2022-01-02 6:34 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2021-12-27 12:34 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Linus Walleij, Dong Aisheng, Shawn Guo, Stefan Agner,
Pengutronix Kernel Team, Sascha Hauer, NXP Linux Team,
open list:GPIO SUBSYSTEM,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rafał Miłecki
Hi Rafał,
On Mon, Dec 27, 2021 at 9:23 AM Rafał Miłecki <zajec5@gmail.com> wrote:
>
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This fixes regression caused by incorrect array indexing.
>
> Reported-by: Fabio Estevam <festevam@gmail.com>
> Fixes: 02f117134952 ("pinctrl: imx: prepare for making "group_names" in "function_desc" const")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
This fixes the "invalid group" errors I was seeing on an imx7s-warp
board, thanks:
Tested-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: imx: fix assigning groups names
2021-12-27 12:22 [PATCH] pinctrl: imx: fix assigning groups names Rafał Miłecki
2021-12-27 12:34 ` Fabio Estevam
@ 2022-01-02 6:34 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-01-02 6:34 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Dong Aisheng, Fabio Estevam, Shawn Guo, Stefan Agner,
Pengutronix Kernel Team, Sascha Hauer, NXP Linux Team, linux-gpio,
linux-arm-kernel, Rafał Miłecki
On Mon, Dec 27, 2021 at 1:23 PM Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This fixes regression caused by incorrect array indexing.
>
> Reported-by: Fabio Estevam <festevam@gmail.com>
> Fixes: 02f117134952 ("pinctrl: imx: prepare for making "group_names" in "function_desc" const")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Patch applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-02 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-27 12:22 [PATCH] pinctrl: imx: fix assigning groups names Rafał Miłecki
2021-12-27 12:34 ` Fabio Estevam
2022-01-02 6:34 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox