From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
kernel@pengutronix.de,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Kamel Bouhara <kamel.bouhara@bootlin.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 03/23] counter: microchip-tcb-capture: Drop unused platform_set_drvdata()
Date: Tue, 28 Dec 2021 17:38:18 +0000 [thread overview]
Message-ID: <20211228173818.418ab922@jic23-huawei> (raw)
In-Reply-To: <20211227094526.698714-4-u.kleine-koenig@pengutronix.de>
On Mon, 27 Dec 2021 10:45:06 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> The driver doesn't ever use platform_get_drvdata, so drop this unused
> call.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
FWIW sanity checked it is indeed not used that I can see.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/counter/microchip-tcb-capture.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
> index 0ab1b2716784..bb69f2e0ba93 100644
> --- a/drivers/counter/microchip-tcb-capture.c
> +++ b/drivers/counter/microchip-tcb-capture.c
> @@ -307,8 +307,6 @@ static int mchp_tc_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - platform_set_drvdata(pdev, priv);
> -
> match = of_match_node(atmel_tc_of_match, np->parent);
> tcb_config = match->data;
> if (!tcb_config) {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-28 17:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 9:45 [PATCH v2 00/23] counter: cleanups and device lifetime fixes Uwe Kleine-König
2021-12-27 9:45 ` [PATCH v2 03/23] counter: microchip-tcb-capture: Drop unused platform_set_drvdata() Uwe Kleine-König
2021-12-28 17:38 ` Jonathan Cameron [this message]
2021-12-29 6:44 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 07/23] counter: microchip-tcb-capture: Convert to counter_priv() wrapper Uwe Kleine-König
2021-12-28 18:05 ` Jonathan Cameron
2021-12-29 7:35 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 11/23] counter: stm32-lptimer-cnt: " Uwe Kleine-König
2021-12-28 18:08 ` Jonathan Cameron
2021-12-29 7:48 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 12/23] counter: stm32-timer-cnt: " Uwe Kleine-König
2021-12-28 18:08 ` Jonathan Cameron
2021-12-29 7:48 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 20/23] counter: stm32-timer-cnt: Convert to new counter registration Uwe Kleine-König
2021-12-28 18:25 ` Jonathan Cameron
2021-12-29 8:37 ` William Breathitt Gray
2021-12-27 9:45 ` [PATCH v2 21/23] counter: stm32-lptimer-cnt: " Uwe Kleine-König
2021-12-28 18:26 ` Jonathan Cameron
2021-12-29 8:39 ` William Breathitt Gray
2021-12-27 12:25 ` [PATCH v2 00/23] counter: cleanups and device lifetime fixes Lars-Peter Clausen
2021-12-28 17:35 ` Jonathan Cameron
2021-12-29 8:49 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211228173818.418ab922@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kamel.bouhara@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox