From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D88A1C433F5 for ; Wed, 5 Jan 2022 06:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=cFW3OOCgHF8mMtUuKDwhRUAAvum0EDyeJxbVrpYWFik=; b=QEkVrJSf1nxOpMol8Kg4Mo9IcR h106plDJHF63+9BGJdz/rB4aHXx0R4iXBczkKf2FfSizu3hEF6BPkhR2IQ8XDfz24l6XsIyACVZbG GRztMfEcCaPmkILRwp9seItXd7jZ47riFTlJdSl5DjFt7xv6a/PrKwAqud77DGA0p/2fH1lG7VjD4 v5N+xgPQobDel40Kgl3+jroKiC5ygRT+BcGx4KF42/HUX2f3Qdlakvgm3C0ZAtJVbJMOYNxk0XeHT tMVHbTAqc371VjVCgy8N1E/qS8J2+hvIusiU1EXdQye/TDRLsrEzX4yEF4d5KS1rA2nAg7KgLPyKP 50o2BDRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n509M-00DuFt-Qh; Wed, 05 Jan 2022 06:51:57 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4zaR-00Dgd6-Ar for linux-arm-kernel@lists.infradead.org; Wed, 05 Jan 2022 06:15:52 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id q81-20020a252a54000000b0060af1d7e063so57564135ybq.17 for ; Tue, 04 Jan 2022 22:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=l4aITqAr4kAWUMdh1BRMLGLBNjKWhPafS6IoiJKe+3o=; b=oq4qaiIdVmKbNmPSmU1ee7EYSBOWVUs0qBp1DNmNPiE1i6LOTJgd4U49eU8Qud+eAF BK9YPVFgysNVn0Jm0gzZFN+8U+8/pwXJB5sDD7nPgk/0MX309k1smI8yLpMytm2wK2G8 jLg7oTVi0CiVtoZgHy1xC/sT6JbceUZ9QjAARlngFZklHrkJTRLucA4QxGBgamZoYfjh qB50KKL9C5/cjkAx+UNaSgDC1VX/tQ9Vqg2DtKfJ8MNPRa4D9fbpZ8crbtlOj79WX5qG xqCVMQokJemgqj7YoOC/pIJCI+MPyNWib/3uJMLOGnZcfzdt8LP1eJPEdtPS+eYN9P/b TsuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=l4aITqAr4kAWUMdh1BRMLGLBNjKWhPafS6IoiJKe+3o=; b=n9WH2gnx4m3cvyU2/WOYnEMlta8YlqYqf0gyODdJaadTUiMQche+MXH/VxHsvLmo6v pmSjfZf2XR9Jf4IQoKDazTc9vQWxIn729B1/lj3VesB1N8addLsIdYE+Dg02S5dfCK2Y 9KqKDaIrQUYW5PghZ4C3yTnDTNnj1Z8p/OK1CL33PcnEFhoMw5yLJH/lFpsXU9TvZMiv oizBBZLw9lesGmnmSwZFLpKJX803U5g11JD3Jb921ag/ARk4evPQD1mFhH3J3vpbqZti 7MKOGm9qSs9J2fPSnP4isTnfuT1rgkLf2dsH654Xqk5DPLnExAtjlhqZh2A3VkWOg17t x9Wg== X-Gm-Message-State: AOAM530TGC5q44O4AeufSPAlODmUBz3XdT5h3mTmnx3BjrhKWcZYmkDC H5cnY01GSpDwDgJsBiPFOkDOhgfuUOWl X-Google-Smtp-Source: ABdhPJyPnXyAbZfjaFcz67v+Kw7nE2hg5GCzoqNQvaO7noAreCoYlyuiuJVgyHV9sb+ADV8pJ+AK+odgpgfW X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:3af1:caef:2937:5d2b]) (user=irogers job=sendgmr) by 2002:a25:40ca:: with SMTP id n193mr64096091yba.683.1641363349798; Tue, 04 Jan 2022 22:15:49 -0800 (PST) Date: Tue, 4 Jan 2022 22:13:48 -0800 In-Reply-To: <20220105061351.120843-1-irogers@google.com> Message-Id: <20220105061351.120843-46-irogers@google.com> Mime-Version: 1.0 References: <20220105061351.120843-1-irogers@google.com> X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog Subject: [PATCH v4 45/48] perf c2c: Use more intention revealing iterator From: Ian Rogers To: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com Cc: eranian@google.com, Ian Rogers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_221551_466141_2B2B31AE X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use perf_cpu_map__for_each_cpu in setup_nodes. Signed-off-by: Ian Rogers --- tools/perf/builtin-c2c.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index b5c67ef73862..ad1fbeafc93d 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -2015,7 +2015,7 @@ static int setup_nodes(struct perf_session *session) { struct numa_node *n; unsigned long **nodes; - int node, cpu; + int node, cpu, idx; int *cpu2node; if (c2c.node_info > 2) @@ -2057,13 +2057,13 @@ static int setup_nodes(struct perf_session *session) if (perf_cpu_map__empty(map)) continue; - for (cpu = 0; cpu < map->nr; cpu++) { - set_bit(map->map[cpu], set); + perf_cpu_map__for_each_cpu(cpu, idx, map) { + set_bit(cpu, set); - if (WARN_ONCE(cpu2node[map->map[cpu]] != -1, "node/cpu topology bug")) + if (WARN_ONCE(cpu2node[cpu] != -1, "node/cpu topology bug")) return -EINVAL; - cpu2node[map->map[cpu]] = node; + cpu2node[cpu] = node; } } -- 2.34.1.448.ga2b2bfdf31-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel