From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D199FC433EF for ; Thu, 6 Jan 2022 18:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=3nX6FgE8lJDPlV8chqljWLdXQ4GuQHReyT2mCz+g+No=; b=JtpCZ7WK3fmnW2 n6mju31jBbEdI3dl0PgJZkSTyxIr9Gpl0xIbwsoBGLkLBdWtHuf6AihdbBhhFpcIi+nd0jI+hZaBZ 9H/+YPs58ReAOq5/FdwTXmOTwY1mGrhQvH4BJGHdjlLJtTOp0KW3NWP0Wf8vBpBLxU53KVbDg7z3J 4ojT3b59KTIS0DkIziJSxGNLWmIpo/63+UNFP35yIQSUydkU1P4AFHZ962UxXKglInCRCjDAL18Vg 0e8mkbx31pqUGgP1C36n/10g0HBnTDqa3+jsPx9WnelGYcIZuB0mVnb9NQLopBbTJLVj/9sUKrswZ V/D58/nuJ/1gODVlj8Bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5X42-000uaE-Oj; Thu, 06 Jan 2022 18:00:38 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5X3t-000uXa-R4 for linux-arm-kernel@lists.infradead.org; Thu, 06 Jan 2022 18:00:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5CA5761CF3; Thu, 6 Jan 2022 18:00:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 992D8C36AEB; Thu, 6 Jan 2022 18:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641492028; bh=DYydbgnS2Q5LXHtJFrES1pqwbao4Pez939AcN9KBnvw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EOsILy3tM+xI/hjivi2NyurzDUrBiXloFSZzBXiTaFxplMSJHHuDMSw/uveKJpPko xjglSC2viJAaYds5RhVnMvlQi7OtPw91HxCXBINDMvmOyXmKm9OuBe0RMU4El8CPcs aZJS+/6iNnuhH2bqTohmg8FJXELmIs30dp76K1eOAVtk4kdA60kk0nAWbP1sD6ayvM 4XwHnnprTyOy+QtE3YtAMpyGLvuIud1axMj4fnNUzmjMQ6E7U+nxwL4vSKykxHf+E6 qknivFyA+YuMfvPPyLbpbW4q/MSHCr4JSWIKIVHjKnSkuzkLlfvOKSlLrvJBMA2QNA AEUBfAQuLA//Q== Date: Thu, 6 Jan 2022 12:00:26 -0600 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Ray Jui , Roman Bacik , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: iproc: Set all 24 bits of PCI class code Message-ID: <20220106180026.GA295674@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220105181306.mkratasqg36tjf4e@pali> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220106_100029_939536_3F7FA8C0 X-CRM114-Status: GOOD ( 22.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 05, 2022 at 07:13:06PM +0100, Pali Roh=E1r wrote: > On Wednesday 05 January 2022 09:51:48 Ray Jui wrote: > > On 1/5/2022 1:35 AM, Pali Roh=E1r wrote: > > 2. I suppose 'PCI_CLASS_BRIDGE_PCI_NORMAL' is defined in some common PCI > > header in a separate patch as described in the commit message. Then how > > come these patches are not constructed with a patch series? > = > Yes, PCI_CLASS_BRIDGE_PCI_NORMAL is a new constant for common pci header > file defined in patch linked in commit message. > https://lore.kernel.org/linux-pci/20211220145140.31898-1-pali@kernel.org/ > = > Originally I included this change in v1 of linked patch in December but > I realized that it does not match standard PCI config space (different > offset 0x43c vs 0x08 and also different shift 0x8 vs 0x0) and probably > there is something either incorrect or really non-standard. So later in > December I dropped iproc_pcie_check_link() change in v2 of the linked > patch where is introduced PCI_CLASS_BRIDGE_PCI_NORMAL and now sent new > change for iproc_pcie_check_link() separately. > = > Technically, linked patch in commit message is just extracting code into > the common macros without any functional changed. But change in this > iproc_pcie_check_link() has also functional change as now also lower 8 > bits of class code are changed. So in my opinion this patch should be > really separate of linked patch. > = > I hope that Lorenzo and Bjorn take patches in correct order... If patches are not sent together in a series, you can't assume anything about the order they'll be applied in. Adding a note about "this patch depends patch X" helps a little but adds a fair amount of friction to the process. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel