From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B916C433EF for ; Fri, 7 Jan 2022 11:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v+FR2AxSMgPgrEGVyP1bRfCqFV5FGJ/HDyMcReGDDg0=; b=grPbR4K7bBt+Ex 4MrrHgnKo1lHVSTcSWkUww91AyX2JV4yZWwkUrVdZYiN4aDVz/Kar07J5npGXqwB85+MS9CIXW7pE S8t+8fe6EOLuCoHYxkT8Gd63z1es2wMecfv0WpmVuyxTic5J4a4bB99WooCvaKCMYMm+L/6dwz38W EkkO73pxx2Q3bFl8ltrzbOS4c1pg21QSrpWmRg1unIiH1XIQUAo44BrXz1Y9vUz9p9aSkcs0qqoy9 p4sUGaaQFCXL6u0wHxz7FNJz8I3EP89KprK4O27nCiTge+SlRxnWJzushf4f4jFNeng5u6kfn22jk u5GmyHLsnujzFhJ/9vaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5neq-003fge-3l; Fri, 07 Jan 2022 11:43:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5nem-003ffM-Fx for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 11:43:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1E5DD13D5; Fri, 7 Jan 2022 03:43:39 -0800 (PST) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A38413F66F; Fri, 7 Jan 2022 03:43:37 -0800 (PST) Date: Fri, 7 Jan 2022 11:43:32 +0000 From: Lorenzo Pieralisi To: Bjorn Helgaas Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Ray Jui , Roman Bacik , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: iproc: Set all 24 bits of PCI class code Message-ID: <20220107114332.GA22419@lpieralisi> References: <20220105181306.mkratasqg36tjf4e@pali> <20220106180026.GA295674@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220106180026.GA295674@bhelgaas> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_034340_609110_D59ECD1E X-CRM114-Status: GOOD ( 24.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 06, 2022 at 12:00:26PM -0600, Bjorn Helgaas wrote: > On Wed, Jan 05, 2022 at 07:13:06PM +0100, Pali Roh=E1r wrote: > > On Wednesday 05 January 2022 09:51:48 Ray Jui wrote: > > > On 1/5/2022 1:35 AM, Pali Roh=E1r wrote: > = > > > 2. I suppose 'PCI_CLASS_BRIDGE_PCI_NORMAL' is defined in some common = PCI > > > header in a separate patch as described in the commit message. Then h= ow > > > come these patches are not constructed with a patch series? > > = > > Yes, PCI_CLASS_BRIDGE_PCI_NORMAL is a new constant for common pci header > > file defined in patch linked in commit message. > > https://lore.kernel.org/linux-pci/20211220145140.31898-1-pali@kernel.or= g/ > > = > > Originally I included this change in v1 of linked patch in December but > > I realized that it does not match standard PCI config space (different > > offset 0x43c vs 0x08 and also different shift 0x8 vs 0x0) and probably > > there is something either incorrect or really non-standard. So later in > > December I dropped iproc_pcie_check_link() change in v2 of the linked > > patch where is introduced PCI_CLASS_BRIDGE_PCI_NORMAL and now sent new > > change for iproc_pcie_check_link() separately. > > = > > Technically, linked patch in commit message is just extracting code into > > the common macros without any functional changed. But change in this > > iproc_pcie_check_link() has also functional change as now also lower 8 > > bits of class code are changed. So in my opinion this patch should be > > really separate of linked patch. > > = > > I hope that Lorenzo and Bjorn take patches in correct order... > = > If patches are not sent together in a series, you can't assume > anything about the order they'll be applied in. Adding a note about > "this patch depends patch X" helps a little but adds a fair amount of > friction to the process. Indeed, more so given that the dependency requires an ACK from other maintainers - I certainly can't pull this patch as-is. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel