From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AE5AC433F5 for ; Fri, 7 Jan 2022 18:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=c7Pv7zZ4J6YkVyII1WEim3XwOdC9fCxvAou7DoMRvyQ=; b=U/1JtSpOkQ3rYE ehsBVMdo4y7HUR8D2tZFUHgd1P3wWglP9rn8iVZAyGJ2GTRhEwttlqaHxaF/3iKj41RQVHwjxJ3xX dAom+RlzkFBJ6E2UUqfTZqgyqtI3njGuWgGBRwbOofCJrOMdnTjKvtFTzwZQ053yVksxx501e2pss Bs2fKwdHsiT/EMqOdN8k3wHQ4rlAsNorGzhE9zi4IxZGeUnDOIniQu1MiHOFisedxC8xoC7qdpADp iYJ2B5pkjtVF7qCmlpPvMCr8oj0gQUC6PSqXP/L0/n6sjacch3ho0xQ4v1fUw6ta1ShV5MYw2BkIg 1qZQaM+Nf95O3viIXJ2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5tlq-004pAP-6p; Fri, 07 Jan 2022 18:15:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5tlj-004p9G-3c for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 18:15:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A032361E8B; Fri, 7 Jan 2022 18:15:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C22F6C36AE0; Fri, 7 Jan 2022 18:15:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641579314; bh=KfKL7MpIagRPKLIHPgNwkikE/2lMY8PB5xDuLTe0wq8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=mhBz42H2UAPIGguatoTXJE2rOt0/4Z7LOduZe+kz2f1tnbd8pqDPrxgfK/UzY74Xz DqTajoP7bxiOJKBmRgB0C4pb1p7m1VfNT8v+HObunVhXScMvkLXABD/IpdGkFuqlh1 /HngyplPvbyq42ccCvYJ12N74RASq8POxrgumpcT/WLz7ygpx5tA3N3iD16OmiytTW Tmm4yONtjXlFAl5LcsXzx/2dYknPbcoGY/uI2fD92OK3v+2T3E2pgL+DNa1b8KNWUm x+kWjvmB+VkTRfvb064eHDIb32gknnEVuAcNgubdhQk5kihbThOYxIZeELObVslb+A 4nY8wchxB8ghQ== Date: Fri, 7 Jan 2022 12:15:12 -0600 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Thomas Petazzoni , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/15] PCI: mvebu: Check that PCI bridge specified in DT has function number zero Message-ID: <20220107181512.GA390598@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211125124605.25915-4-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_101515_218118_7F99E0CA X-CRM114-Status: GOOD ( 16.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 25, 2021 at 01:45:53PM +0100, Pali Roh=E1r wrote: > Driver cannot handle PCI bridges at non-zero function address. So add > appropriate check. Currently all in-tree kernel DTS files set PCI bridge > function to zero. Why can the driver not handle bridges at non-zero function addresses? The PCI spec allows that, doesn't it? Is this a hardware limitation? > Signed-off-by: Pali Roh=E1r > Cc: stable@vger.kernel.org > --- > drivers/pci/controller/pci-mvebu.c | 5 +++++ > 1 file changed, 5 insertions(+) > = > diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/= pci-mvebu.c > index 6197f7e7c317..08274132cdfb 100644 > --- a/drivers/pci/controller/pci-mvebu.c > +++ b/drivers/pci/controller/pci-mvebu.c > @@ -864,6 +864,11 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie *= pcie, > port->devfn =3D of_pci_get_devfn(child); > if (port->devfn < 0) > goto skip; > + if (PCI_FUNC(port->devfn) !=3D 0) { > + dev_err(dev, "%s: invalid function number, must be zero\n", > + port->name); > + goto skip; > + } > = > ret =3D mvebu_get_tgt_attr(dev->of_node, port->devfn, IORESOURCE_MEM, > &port->mem_target, &port->mem_attr); > -- = > 2.20.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel