From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4184C433EF for ; Fri, 7 Jan 2022 21:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=9PS3l3bPEfYOrN9EZ0P56VIWHMueD/qLfkR+S87CBlU=; b=1c+aKfoSYwMx0b apw2qXTj+yW2uKsmdABhubF7izoF9klyXQ2uAGFuNDJb76H3oGzKLBhahbo26X4xxz4n9+8QndpBA BSjCkqLcXkZiTWcirJVTBkSX/b/iL6TiV8j33R/CoicS/bpPVXBZc7pqwryxPZNiPnDcbkMa/Hvn7 CQsKIveVS07Q+avdbhi/d8+ojj2xORzgj3+zmGHlhwEAShGuq9M2UQub/tWsyQyvaUWsNFlE/pqut Q9UFh6NFiuOA6vDSkJePPg3TbH88fLPwC+4k8FtixBB1WgWD7XI8qhseys98ZjkThp01G/9L4khkY rYVeNb3y2Szsphpnv1tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5wly-005Hcf-AU; Fri, 07 Jan 2022 21:27:42 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5wlv-005Hc7-16 for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 21:27:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 81DA062003; Fri, 7 Jan 2022 21:27:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7F23C36AE5; Fri, 7 Jan 2022 21:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641590858; bh=O8L8frEPR6ADTtnoidH4cv+S5JH+gvpt/0dLHTkTmqI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=g8SKATUWnc60ODX1UIYn0yCqsB8WLouAN2c7XfsLrpLnokNgCMnVb7SPCnJ4xcwpA tbTxEhUuv3j5pZr8e/UTKx2t5sosuaPakdRcir6cyUZ7jOiOimmyCJx9yaBFtw3FA2 i8dMRMFw2LrblkHqBg/KyyjQkvcf6saQ4RJ8b5EufY14y/Fh+Ov0dR9Ad3805IegAN EbEryUqSJWAJC0gEU4Ki/Y7/hNfsOeJePrVGm3xhMpr/wbmSs+nR3oSCgvhWCIca7v 29hTSiHnx5yrFe99mPEWyY1kuXpRJATzHHQmRYx0BzWsXvscJkfQDISIzwQQcIoh5u HgzNc9NhhQDEQ== Date: Fri, 7 Jan 2022 15:27:36 -0600 From: Bjorn Helgaas To: Thomas Petazzoni Cc: Bjorn Helgaas , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Russell King , Antoine Tenart , Gregory Clement , Maxime Chevallier , Nadav Haklai , Victor Gu , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Zachary Zhang , Wilson Ding , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Message-ID: <20220107212736.GA404447@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180629092231.32207-4-thomas.petazzoni@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_132739_153136_F6BFF3F4 X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 29, 2018 at 11:22:31AM +0200, Thomas Petazzoni wrote: > +static void advk_sw_pci_bridge_init(struct advk_pcie *pcie) > +{ > + struct pci_sw_bridge *bridge = &pcie->bridge; > + /* Support interrupt A for MSI feature */ > + bridge->conf.intpin = PCIE_CORE_INT_A_ASSERT_ENABLE; Only 3.5 years later, IIUC, this is the value you get when you read PCI_INTERRUPT_PIN, so I think this should be PCI_INTERRUPT_INTA, not PCIE_CORE_INT_A_ASSERT_ENABLE. Readers expect to get the values defined in the PCI spec, i.e., PCI_INTERRUPT_UNKNOWN PCI_INTERRUPT_INTA PCI_INTERRUPT_INTB PCI_INTERRUPT_INTC PCI_INTERRUPT_INTD Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel