From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90C2CC433EF for ; Sat, 8 Jan 2022 00:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qrJnkDspQ9Ppr1TCY5dihRfbWtLXo369W6ac7qpmoSI=; b=MPF9GG0VYP4b6t fusblXVKqRrb9xx5u5gQ5ipjH8tV0VnuEGx5/ltUPP0DQA2XQvzpov3D4aszEUTX8y49C+sweSSXA z4jV2aDZ5rZz+kYCZFmHXmabLTFP6pqkkrJBMVrchju4H7b8YfmUKQT/2VtuiXuKI0MgIK8MZx/4j dhPVLvP1xYmQadLk6U5FW9SQWpmhpGra7PxeI8Dlt71/dtZf2DwS2ee5waQPuObhp7e6vhUyv0875 1aRC/uhoZEELt8ziKGK94XUa2P+SMcnNBR3WLwTnDGWgReJS+TJnPmYBQqalk1YQSKk6uRbRZz5ot IrrgGRVx+sRIV3WBqicA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5zHM-005e5A-B2; Sat, 08 Jan 2022 00:08:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5zHI-005e4K-Rl for linux-arm-kernel@lists.infradead.org; Sat, 08 Jan 2022 00:08:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 62C3E61FF6; Sat, 8 Jan 2022 00:08:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8373C36AE5; Sat, 8 Jan 2022 00:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641600491; bh=eRTFqRjFRgCxvmbchANikxM/bE3d5Z9QWcoIjpeA9No=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=q7NbhrGKV6ToLJTDT/XYgUGwPUbhiN8AEtI6Wg693M0CZuPXWEVz+MgWoYAq2hIkt ogidsf6NW0emarxkW/WFsbpWzrFGw/Yaf3ATe9pbnv8xa5RB2j/BgGZypx3IwkPJx4 Aae+3HWZ1Qo08Gp5Nz1RJClmeqAT29g4jYvtnVqQTa3pr6Yc+6ALJL6/3DxbVj8JBq RX0O+cFzp5j0UbKezAbDODbsuh1S7E0/Loumw/xUsELKpifGrCQLIX+LB67RZoLbdR I/uMVLX4zaG6CJ3ECT7lMhwvFVyIWY/NoHU94bmqAD+HCHwR2GN57RQzizf1Lqw1HT f3xD1828e65xw== MIME-Version: 1.0 In-Reply-To: <20220107183303.2337676-1-nathan@kernel.org> References: <20220107183303.2337676-1-nathan@kernel.org> Subject: Re: [PATCH] clk: visconti: Remove pointless NULL check in visconti_pll_add_lookup() From: Stephen Boyd Cc: Nick Desaulniers , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , kernel test robot To: Michael Turquette , Nathan Chancellor , Nobuhiro Iwamatsu Date: Fri, 07 Jan 2022 16:08:10 -0800 User-Agent: alot/0.9.1 Message-Id: <20220108000811.B8373C36AE5@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_160812_959956_E6F41BE4 X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nathan Chancellor (2022-01-07 10:33:03) > Clang warns: > > drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' will always evaluate to 'true' [-Wpointer-bool-conversion] > if (ctx->clk_data.hws && id) > ~~~~~~~~~~~~~~^~~ ~~ > 1 warning generated. > > This array cannot be NULL if ctx is not NULL, which is allocated in > visconti_init_pll(), so just remove the check, which matches other clk > drivers. > > Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/1564 > Reported-by: kernel test robot > Signed-off-by: Nathan Chancellor > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel