From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2E2AC433EF for ; Mon, 10 Jan 2022 17:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=jLnRxFdd5d8CRY2NgoPoqFZzPYQVSRe6FiTqBwPjH/8=; b=jLLI5kPkCY7POv Mfhpb4wQXhTU8qLPwY/3sGCRokJW8LP1lYUwAYwR5fVTJLun9XeP501rr9KR/QFfJ6sIoDHwdGfsB 0LSlb1jio50MtVLdONJzCkK1iqimDfYGWlNvlPKgDALm+tsPYsqatWXoDNit4cFeTcrCgYpoL62Gs 8TuNz2RAVWuepG6vHcWpGbeCaerXyjwlT7BXpfi3S8o6Z9OrTYviP9ZXr0qDA/Eo1/siwv2dpApxQ 5lgDuBvT8vtGvzaNitnVzM9BRYQIO6Y1Ty5nwL45cvNi8r/4IVO8kywdQycEhyg3yYdPR3sDs9qlx ce9BwDjv7Td8Txwr2bYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6y8W-00CTkz-74; Mon, 10 Jan 2022 17:07:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6y8S-00CTjX-SQ for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 17:07:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0CE86133C; Mon, 10 Jan 2022 17:07:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F131AC36AE3; Mon, 10 Jan 2022 17:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641834427; bh=uSRmcrk/rMxc6Y0vOkh+x1pTujA0vIxTYCIx+RH6btk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=XveBlLt+2AAkV+nD+QRtSqZ/vXLxzSuzYJL3V0LaWr8pJ8YEwOA7tFEJa2osk+aP8 6aVxOgWtkmzUpBHkO0UW43wPD0dvZTYZVjlTwqwRXNVSEZnOr+82lWnzG0ZVDyKDpK H01spAQ4paisJjYOKj95Bh9LDrGoBHyUD3OhnGsgGP678BPj2xmiSExRXzF+WA8bJG gMrCefqYApruZVsgRprxTdFXl2ybDJcae6r3FNNGx6wr49HIQ1OS5yTAA20rYPw6On tM9lk4oOU+fLmDN8FAkfhs0X5P1TAheCHtiwVdVMaD1+4G/KdPhitUERUjD26QBDNb rd8i0tff9gVVw== Date: Mon, 10 Jan 2022 11:07:04 -0600 From: Bjorn Helgaas To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Marc Zyngier , Lorenzo Pieralisi , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/23] PCI: aardvark: Replace custom PCIE_CORE_INT_* macros with PCI_INTERRUPT_* Message-ID: <20220110170704.GA60160@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220110015018.26359-2-kabel@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_090709_007373_89BF7AFA X-CRM114-Status: GOOD ( 18.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 10, 2022 at 02:49:56AM +0100, Marek Beh=FAn wrote: > From: Pali Roh=E1r > = > Header file linux/pci.h defines enum pci_interrupt_pin with corresponding > PCI_INTERRUPT_* values. > = > Signed-off-by: Pali Roh=E1r > Signed-off-by: Marek Beh=FAn Reviewed-by: Bjorn Helgaas Thanks! > --- > drivers/pci/controller/pci-aardvark.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > = > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controll= er/pci-aardvark.c > index ec0df426863d..62baddd2ca95 100644 > --- a/drivers/pci/controller/pci-aardvark.c > +++ b/drivers/pci/controller/pci-aardvark.c > @@ -39,10 +39,6 @@ > #define PCIE_CORE_ERR_CAPCTL_ECRC_CHK_TX_EN BIT(6) > #define PCIE_CORE_ERR_CAPCTL_ECRC_CHCK BIT(7) > #define PCIE_CORE_ERR_CAPCTL_ECRC_CHCK_RCV BIT(8) > -#define PCIE_CORE_INT_A_ASSERT_ENABLE 1 > -#define PCIE_CORE_INT_B_ASSERT_ENABLE 2 > -#define PCIE_CORE_INT_C_ASSERT_ENABLE 3 > -#define PCIE_CORE_INT_D_ASSERT_ENABLE 4 > /* PIO registers base address and register offsets */ > #define PIO_BASE_ADDR 0x4000 > #define PIO_CTRL (PIO_BASE_ADDR + 0x0) > @@ -968,7 +964,7 @@ static int advk_sw_pci_bridge_init(struct advk_pcie *= pcie) > bridge->conf.pref_mem_limit =3D cpu_to_le16(PCI_PREF_RANGE_TYPE_64); > = > /* Support interrupt A for MSI feature */ > - bridge->conf.intpin =3D PCIE_CORE_INT_A_ASSERT_ENABLE; > + bridge->conf.intpin =3D PCI_INTERRUPT_INTA; > = > /* Aardvark HW provides PCIe Capability structure in version 2 */ > bridge->pcie_conf.cap =3D cpu_to_le16(2); > -- = > 2.34.1 > = > = > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel